xtables-addons: Missing reference operator in xt_ECHO.c (for Jan Engelhardt)
PATCH 1/1 xtables-addons: Missing reference operator in xt_ECHO.c (for Jan Engelhardt)
Jan,
when you prepared commit ab27472eb44b0690f74d542ddb9a972460eceb9a, you probably overlooked some piece of code, because my gcc objects:
"2.6.26.5-t4/net/netfilter/xtables-addons/xt_ECHO.c:90: warning: passing argument 1 of ‘xtnu_ip_route_me_harder’ from incompatible pointer type"
extensions/xt_ECHO.c +1 -1
@@ -87,7 +87,7 @@ static unsigned int echo_tg4(struct sk_bdst_hold (oldskb->dst); newskb->dst = oldskb->dst; -if (ip_route_me_harder (newskb, addr_type) <0 ) +if (ip_route_me_harder (&newskb, addr_type) <0 ) goto free_nskb; newip->ttl =dst_metric (newskb->dst,RTAX_HOPLIMIT );
--
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · Jiri Moravec
Jan,
when you prepared commitab27472eb44b0690f74d542ddb9a972460eceb9a, you probably overlooked some piece of code, because my gcc objects:
"2.6.26.5-t4/net/netfilter/xtables-addons/xt_ECHO.c:90: warning: passing argument 1 of ‘xtnu_ip_route_me_harder’ from incompatible pointer type"
There is more than just that one.
I fixed it up, thanks for reporting!
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html