paride: fix up build warning on mips platforms
PATCH 1/1 paride: fix up build warning on mips platforms
MIPS include files define "PC" so when building the paride driver the following build warning shows up:
rivers/block/paride/bpck.c:32: warning: "PC" redefined
Fix this by undefining PC before redefining it as is done for other defines in this driver.
--- drivers/block/paride/bpck.c | 1 + 1 file changed, 1 insertion(+)
drivers/block/paride/bpck.c +1 -0
@@ -28,6 +28,7 @@#undef r2#undef w2 +#undef PC#define PC pi->private#define r2 () (PC=(in_p(2) & 0xff))
Signature · 1 line
2.34.1
Quoted 32 lines · Greg Kroah-Hartman
MIPS include files define "PC" so when building the paride driver the following build warning shows up:
rivers/block/paride/bpck.c:32: warning: "PC" redefinedFix this by undefining PC before redefining it as is done for other defines in this driver.
Cc Tim Waugh <[email protected]>Cc Jens Axboe <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/block/paride/bpck.c | 1 + 1 file changed, 1 insertion(+)drivers/block/paride/bpck.c +1
-0@@ -28,6 +28,7 @@#undef r2#undef w2 +#undef PC#define PC pi->private#define r2 () (PC=(in_p(2) & 0xff))Signature · 1 line
2.34.1
Given the lack of objections to this, I'll just take it through one of my trees for 5.17-rc1.
thanks,
greg k-h
Jens Axboe
maintainerQuoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Greg Kroah-Hartman
MIPS include files define "PC" so when building the paride driver the following build warning shows up:
rivers/block/paride/bpck.c:32: warning: "PC" redefinedFix this by undefining PC before redefining it as is done for other defines in this driver.
Cc Tim Waugh <[email protected]>Cc Jens Axboe <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/block/paride/bpck.c | 1 + 1 file changed, 1 insertion(+)drivers/block/paride/bpck.c +1
-0@@ -28,6 +28,7 @@#undef r2#undef w2 +#undef PC
Quoted 8 lines
Quoted 5 lines
drivers/block/paride/bpck.c +0
-0#define PC pi->private#define r2 () (PC=(in_p(2) & 0xff))Signature · 1 line
2.34.1Given the lack of objections to this, I'll just take it through one of my trees for 5.17-rc1.
Sorry about that, got lost. I can queue it up too, or you can add my acked-by, either is fine.
Signature · 1 line
Jens Axboe
Quoted 38 lines · Jens Axboe
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Greg Kroah-Hartman
MIPS include files define "PC" so when building the paride driver the following build warning shows up:
rivers/block/paride/bpck.c:32: warning: "PC" redefinedFix this by undefining PC before redefining it as is done for other defines in this driver.
Cc Tim Waugh <[email protected]>Cc Jens Axboe <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- drivers/block/paride/bpck.c | 1 + 1 file changed, 1 insertion(+)drivers/block/paride/bpck.c +1
-0@@ -28,6 +28,7 @@#undef r2#undef w2 +#undef PCQuoted 8 lines
Quoted 5 lines
drivers/block/paride/bpck.c +0
-0#define PC pi->private#define r2 () (PC=(in_p(2) & 0xff))Signature · 1 line
2.34.1Given the lack of objections to this, I'll just take it through one of my trees for 5.17-rc1.
Quoted 2 lines
Sorry about that, got lost. I can queue it up too, or you can add my acked-by, either is fine.
Easy enough for me to take it, now done, thanks!
greg k-h