Skip to contentSkip to conversation

paride: fix up build warning on mips platforms

PATCH In review Greg Kroah-Hartman 2 participants 4 messages Nov 30, 2021 – Dec 21, 2021 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 paride: fix up build warning on mips platforms

MIPS include files define "PC" so when building the paride driver the following build warning shows up:

rivers/block/paride/bpck.c:32: warning: "PC" redefined

Fix this by undefining PC before redefining it as is done for other defines in this driver.

---
 drivers/block/paride/bpck.c | 1 +
 1 file changed, 1 insertion(+)
drivers/block/paride/bpck.c +1 -0
index f5f63ca2889d..d880a9465e9b 100644
@@ -28,6 +28,7 @@
 
 #undef r2
 #undef w2
+#undef PC
 
 #define PC			pi->private
 #define r2()			(PC=(in_p(2) & 0xff))
Signature · 1 line
2.34.1
#1 lore raw
Quoted 32 lines · Greg Kroah-Hartman

MIPS include files define "PC" so when building the paride driver the following build warning shows up:

rivers/block/paride/bpck.c:32: warning: "PC" redefined

Fix this by undefining PC before redefining it as is done for other defines in this driver.

---
 drivers/block/paride/bpck.c | 1 +
 1 file changed, 1 insertion(+)
drivers/block/paride/bpck.c +1 -0
index f5f63ca2889d..d880a9465e9b 100644
@@ -28,6 +28,7 @@
 
 #undef r2
 #undef w2
+#undef PC
 
 #define PC			pi->private
 #define r2()			(PC=(in_p(2) & 0xff))
Signature · 1 line
2.34.1

Given the lack of objections to this, I'll just take it through one of my trees for 5.17-rc1.

thanks,

greg k-h

maintainer
#2 lore raw
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Greg Kroah-Hartman

MIPS include files define "PC" so when building the paride driver the following build warning shows up:

rivers/block/paride/bpck.c:32: warning: "PC" redefined

Fix this by undefining PC before redefining it as is done for other defines in this driver.

---
 drivers/block/paride/bpck.c | 1 +
 1 file changed, 1 insertion(+)
drivers/block/paride/bpck.c +1 -0
index f5f63ca2889d..d880a9465e9b 100644
@@ -28,6 +28,7 @@
 
 #undef r2
 #undef w2
+#undef PC
 
Quoted 8 lines
Quoted 5 lines
drivers/block/paride/bpck.c +0 -0
 #define PC			pi->private
 #define r2()			(PC=(in_p(2) & 0xff))
Signature · 1 line
2.34.1

Given the lack of objections to this, I'll just take it through one of my trees for 5.17-rc1.

Sorry about that, got lost. I can queue it up too, or you can add my acked-by, either is fine.

Signature · 1 line
Jens Axboe
#3 lore raw
Quoted 38 lines · Jens Axboe
Quoted 28 lines · Greg Kroah-Hartman
Quoted 27 lines · Greg Kroah-Hartman

MIPS include files define "PC" so when building the paride driver the following build warning shows up:

rivers/block/paride/bpck.c:32: warning: "PC" redefined

Fix this by undefining PC before redefining it as is done for other defines in this driver.

---
 drivers/block/paride/bpck.c | 1 +
 1 file changed, 1 insertion(+)
drivers/block/paride/bpck.c +1 -0
index f5f63ca2889d..d880a9465e9b 100644
@@ -28,6 +28,7 @@
 
 #undef r2
 #undef w2
+#undef PC
 
Quoted 8 lines
Quoted 5 lines
drivers/block/paride/bpck.c +0 -0
 #define PC			pi->private
 #define r2()			(PC=(in_p(2) & 0xff))
Signature · 1 line
2.34.1

Given the lack of objections to this, I'll just take it through one of my trees for 5.17-rc1.

Quoted 2 lines

Sorry about that, got lost. I can queue it up too, or you can add my acked-by, either is fine.

Easy enough for me to take it, now done, thanks!

greg k-h