powerpc: 83xx: add support for the kmeter1 board
PATCH v2 3/5 powerpc: 83xx: add support for the kmeter1 board
This patch adds support for the kmeter1 board from Keymile, based on a Freescale MPC8360 CPU.
- serial console on UART 1
- 256 MB DDR2 RAM
- 64 MB NOR Flash
- Ethernet RMII Mode over UCC4
- PHY SMSC LAN8700
---
changes since v1:
- rebased against current HEAD
commit e0b0ec843085f96f4fe0738424835ee90e58bc00
MAINTAINERS | 1 + MAKEALL | 1 + Makefile | 3 + board/keymile/kmeter1/Makefile | 51 ++++ board/keymile/kmeter1/config.mk | 24 ++ board/keymile/kmeter1/kmeter1.c | 153 ++++++++++++ include/configs/kmeter1.h | 521 +++++++++++++++++++++++++++++++++++++++ 7 files changed, 754 insertions(+), 0 deletions(-) create mode 100644 board/keymile/kmeter1/Makefile create mode 100644 board/keymile/kmeter1/config.mk create mode 100644 board/keymile/kmeter1/kmeter1.c create mode 100644 include/configs/kmeter1.h
MAINTAINERS +1 -0
@@ -374,6 +374,7 @@ Heiko Schocher <[email protected]> ids8247 MPC8247 jupiter MPC5200 + kmeter1 MPC8360 mgcoge MPC8247 mgsuvd MPC852 mucmc52 MPC5200
MAKEALL +1 -0
@@ -326,6 +326,7 @@ LIST_8260=" \ ######################################################################### LIST_83xx=" \ + kmeter1 \ MPC8313ERDB_33 \ MPC8313ERDB_NAND_66 \ MPC8315ERDB \
Makefile +3 -0
@@ -2175,6 +2175,9 @@ TASREG_config : unconfig ## MPC83xx Systems ######################################################################### +kmeter1_config: unconfig + @$(MKCONFIG) kmeter1 ppc mpc83xx kmeter1 keymile + MPC8313ERDB_33_config \ MPC8313ERDB_66_config \ MPC8313ERDB_NAND_33_config \
board/keymile/kmeter1/Makefile new file +51 -0
51 lines not on this page · raw message
board/keymile/kmeter1/config.mk new file +24 -0
@@ -0,0 +1,24 @@ +# +# (C) Copyright 2008 +# Heiko Schocher, DENX Software Engineering, hs at denx.de. +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +TEXT_BASE = 0xF0000000
board/keymile/kmeter1/kmeter1.c new file +153 -0
153 lines not on this page · raw message
include/configs/kmeter1.h new file +521 -0
521 lines not on this page · raw message
Signature · 5 lines
1.5.6.1 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
PATCH v2 3/5 powerpc: 83xx: add support for the kmeter1 board
Quoted 8 lines · On Wed, 19 Nov 2008 10:11:32 +0100 Heiko Schocher <[email protected]> wrote:
MAINTAINERS | 1 + MAKEALL | 1 + Makefile | 3 + board/keymile/kmeter1/Makefile | 51 ++++ board/keymile/kmeter1/config.mk | 24 ++ board/keymile/kmeter1/kmeter1.c | 153 ++++++++++++ include/configs/kmeter1.h | 521 +++++++++++++++++++++++++++++++++++++++ 7 files changed, 754 insertions(+), 0 deletions(-)
a doc/README.kmeter1 would be nice, esp. if the board has any h/w quirks such as with non-default dip switch settings and interactions with e.g., PIGGY.
Review
Quoted 3 lines
(quoted diff) +2
-0+#define CONFIG_SYS_LOAD_ADDR 0x200000 /* default load address */ + "fileaddr=200000\0" \
I believe this and your CONFIG_SYS_LOAD_ADDR setting above are one of the same; rm the latter?
include/configs/kmeter1.h line 511
Quoted 5 lines
include/configs/kmeter1.h new file +5
-0+"load=tftp ${fileaddr} ${u-boot}\0" \ +"update=protect off F0000000 F003FFFF;" \ +"era F0000000 f003FFFF;" \ +"cp.b ${fileaddr} F0000000 ${filesize};" \ +"setenv filesize;saveenv\0" \
can we use something based on TEXT_BASE instead? e.g.:
"protect off " MK_STR(TEXT_BASE) " +$filesize; " \
"erase " MK_STR(TEXT_BASE) " +$filesize; " \
"cp.b $loadaddr " MK_STR(TEXT_BASE) " $filesize; " \
"protect on " MK_STR(TEXT_BASE) " +$filesize; " \
"cmp.b $loadaddr " MK_STR(TEXT_BASE) " $filesize\0" \it'll be easier on people that modify TEXT_BASE.
other than that, looks good.
Kim