Skip to contentSkip to conversation

powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

PATCH New Heiko Schocher 2 participants 4 messages Jan 28, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 9/31 powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

The size of the serial RXBuffer is increased from 16 to 128 bytes to enable comfortable copy-and-paste of commands with the mouse

---
 include/configs/mgcoge.h |    2 +-
 include/configs/mgsuvd.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
include/configs/mgcoge.h +1 -1
index f772627..07e0b8e 100644
@@ -50,7 +50,7 @@
 #undef  CONFIG_CONS_ON_SCC		/* It's not on SCC           */
 #undef	CONFIG_CONS_NONE		/* It's not on external UART */
 #define CONFIG_CONS_INDEX	2	/* SMC2 is used for console  */
-#define CONFIG_SYS_SMC_RXBUFLEN	16
+#define CONFIG_SYS_SMC_RXBUFLEN	128
 
 /*
  * Select ethernet configuration
include/configs/mgsuvd.h +1 -1
index ee1da02..05e770e 100644
@@ -45,7 +45,7 @@
 #define CONFIG_SYS_SMC_UCODE_PATCH	1	/* Relocate SMC1 */
 #define CONFIG_SYS_SMC_DPMEM_OFFSET	0x1fc0
 #define CONFIG_8xx_CONS_SMC1	1	/* Console is on SMC1		*/
-#define CONFIG_SYS_SMC_RXBUFLEN		16
+#define CONFIG_SYS_SMC_RXBUFLEN		128
 
 #define CONFIG_SYS_CPM_BOOTCOUNT_ADDR	0x1eb0	/* In case of SMC relocation, the
 					 * default value is not working */
Signature · 5 lines
1.6.0.6

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

PATCH 9/31 powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

Dear Heiko Schocher,

Quoted 5 lines · In message <[email protected]> you wrote:

powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

The size of the serial RXBuffer is increased from
16 to 128 bytes to enable comfortable
copy-and-paste of commands with the mouse

Why do you initialize these settins as 16 in patch N when you increase the value in patch N+1? This makes little sense to me. Why not using the right value right from the beginning?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Things that try to look like things often do look  more  like  things
than things. Well-known fact.       - Terry Pratchett, _Wyrd Sisters_
#2 lore raw

PATCH 9/31 powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

Hello Wolfgang,

Quoted 10 lines · Wolfgang Denk
Quoted 5 lines · In message <[email protected]> you wrote:

powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

The size of the serial RXBuffer is increased from
16 to 128 bytes to enable comfortable
copy-and-paste of commands with the mouse

Why do you initialize these settins as 16 in patch N when you increase the value in patch N+1? This makes little sense to me. Why not using the right value right from the beginning?

Because it shows a development history.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 9/31 powerpc: mgcoge, mgsuvd: RxBuffer for serial input increased to 128 byte

Dear Heiko Schocher,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines

Why do you initialize these settins as 16 in patch N when you increase the value in patch N+1? This makes little sense to me. Why not using the right value right from the beginning?

Because it shows a development history.

I think it would be better to fold the second patch into the first one.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you are afraid of loneliness, don't marry."             - Chekhov