Skip to contentSkip to conversation

8xx, mgsuvd: size and position of environment corrected

PATCH New Heiko Schocher 2 participants 4 messages Jan 28, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 10/31 8xx, mgsuvd: size and position of environment corrected

adapted the position and size of the environment
sector to match the defines in mgcoge, kmeter1
and make them dependant of the MONITOR_LEN
instead of an absolute address

---
 include/configs/mgsuvd.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/mgsuvd.h +3 -3
index 05e770e..01f5bd3 100644
@@ -126,13 +126,13 @@
 #define CONFIG_SYS_FLASH_WRITE_TOUT	500	/* Timeout for Flash Write (in ms)	*/
 
 #define CONFIG_ENV_IS_IN_FLASH	1
-#define CONFIG_ENV_OFFSET		0x40000 /*   Offset   of Environment Sector	*/
-#define CONFIG_ENV_SIZE		0x08000 /* Total Size of Environment Sector	*/
+#define CONFIG_ENV_OFFSET	CONFIG_SYS_MONITOR_LEN
+#define CONFIG_ENV_SIZE	0x20000 /* Total Size of Environment	*/
 #define CONFIG_ENV_SECT_SIZE	0x20000 /* Total Size of Environment Sector	*/
 
 /* Address and size of Redundant Environment Sector	*/
 #define CONFIG_ENV_OFFSET_REDUND	(CONFIG_ENV_OFFSET+CONFIG_ENV_SECT_SIZE)
-#define CONFIG_ENV_SIZE_REDUND	(CONFIG_ENV_SIZE)
+#define CONFIG_ENV_SIZE_REDUND		(CONFIG_ENV_SIZE)
 #define CONFIG_ENV_BUFFER_PRINT		1
 
 /*-----------------------------------------------------------------------
Signature · 5 lines
1.6.0.6

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

PATCH 10/31 8xx, mgsuvd: size and position of environment corrected

Dear Heiko Schocher,

Quoted 16 lines · In message <[email protected]> you wrote:

adapted the position and size of the environment
sector to match the defines in mgcoge, kmeter1
and make them dependant of the MONITOR_LEN
instead of an absolute address

---
 include/configs/mgsuvd.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/mgsuvd.h +0 -0
index 05e770e..01f5bd3 100644

include/configs/mgsuvd.h line 131

Quoted 8 lines
include/configs/mgsuvd.h +2 -2
@@ -126,13 +126,13 @@
 #define CONFIG_SYS_FLASH_WRITE_TOUT	500	/* Timeout for Flash Write (in ms)	*/
 
 #define CONFIG_ENV_IS_IN_FLASH	1
-#define CONFIG_ENV_OFFSET		0x40000 /*   Offset   of Environment Sector	*/
-#define CONFIG_ENV_SIZE		0x08000 /* Total Size of Environment Sector	*/
+#define CONFIG_ENV_OFFSET	CONFIG_SYS_MONITOR_LEN
+#define CONFIG_ENV_SIZE	0x20000 /* Total Size of Environment	*/
 #define CONFIG_ENV_SECT_SIZE	0x20000 /* Total Size of Environment Sector	*/

Do you really need 128 kB environment storage? Note that this will slow down operation a lot because it means you always have to checksum for that much memory. The previously used value of 32 kB should be more than sufficient for all practical purposes.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
            - R.  Pirsig, "Zen and the Art of Motorcycle Maintenance"
#2 lore raw

PATCH 10/31 8xx, mgsuvd: size and position of environment corrected

Hello Wolfgang,

Quoted 19 lines · Wolfgang Denk
Quoted 18 lines · In message <[email protected]> you wrote:

adapted the position and size of the environment
sector to match the defines in mgcoge, kmeter1
and make them dependant of the MONITOR_LEN
instead of an absolute address

---
 include/configs/mgsuvd.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
include/configs/mgsuvd.h +0 -0
index 05e770e..01f5bd3 100644
@@ -126,13 +126,13 @@
 #define CONFIG_SYS_FLASH_WRITE_TOUT	500	/* Timeout for Flash Write (in ms)	*/
 
Quoted 11 lines

include/configs/mgsuvd.h line 131

Quoted 6 lines
include/configs/mgsuvd.h +2 -2
 #define CONFIG_ENV_IS_IN_FLASH	1
-#define CONFIG_ENV_OFFSET		0x40000 /*   Offset   of Environment Sector	*/
-#define CONFIG_ENV_SIZE		0x08000 /* Total Size of Environment Sector	*/
+#define CONFIG_ENV_OFFSET	CONFIG_SYS_MONITOR_LEN
+#define CONFIG_ENV_SIZE	0x20000 /* Total Size of Environment	*/
 #define CONFIG_ENV_SECT_SIZE	0x20000 /* Total Size of Environment Sector	*/

Do you really need 128 kB environment storage? Note that this will slow down operation a lot because it means you always have to checksum for that much memory. The previously used value of 32 kB should be more than sufficient for all practical purposes.

As you see in the Signed-off-by, this patch comes from the manufacturer from the board, and he needs such a big space.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 10/31 8xx, mgsuvd: size and position of environment corrected

Dear Heiko Schocher,

Quoted 3 lines · In message <[email protected]> you wrote:

As you see in the Signed-off-by, this patch comes from the manufacturer from the board, and he needs such a big space.

I recom,mend you contact and ask him again, pointing out the performance impact he is going to suffer from.

Even with the old settings (32 kB environment) - did you ever try a "printenv" for 32 kB environment settings? I seriously doubt that this is managable any more.

Please help the customer and prevent him from doing stupid things.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Time is a drug. Too much of it kills you.
                                      - Terry Pratchett, _Small Gods_