Skip to contentSkip to conversation

8xx, icache: enabling ICache not before running from RAM

PATCH New Heiko Schocher 2 participants 2 messages Mar 12, 2009 – Mar 18, 2009

v2 of 3 New Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/6 8xx, icache: enabling ICache not before running from RAM

with the new CONFIG_SYS_DELAYED_ICACHE config option, ICache is not enabled before code runs from RAM.

---
 README                    |    5 +++++
 cpu/mpc8xx/start.S        |    2 +-
 include/configs/FLAGADM.h |    3 +++
 include/configs/IP860.h   |    3 +++
 include/configs/pcu_e.h   |    3 +++
 lib_ppc/board.c           |    3 +--
 6 files changed, 16 insertions(+), 3 deletions(-)
README +5 -0
index 43fb1c0..46181a4 100644
@@ -318,6 +318,11 @@ The following options need to be configured:
 		that this requires a (stable) reference clock (32 kHz
 		RTC clock or CONFIG_SYS_8XX_XIN)
 
+		CONFIG_SYS_DELAYED_ICACHE
+
+		Define this option if you want to enable the
+		ICache only when Code runs from RAM.
+
 - Intel Monahans options:
 		CONFIG_SYS_MONAHANS_RUN_MODE_OSC_RATIO
 
cpu/mpc8xx/start.S +1 -1
index 45c902e..8864c37 100644
@@ -142,7 +142,7 @@ boot_warm:
 	lis	r3, IDC_DISABLE at h	/* Disable data cache */
 	mtspr	DC_CST, r3
 
-#if !(defined(CONFIG_IP860) || defined(CONFIG_PCU_E) || defined (CONFIG_FLAGADM))
+#if !defined(CONFIG_SYS_DELAYED_ICACHE)
 					/* On IP860 and PCU E,
 					 * we cannot enable IC yet
 					 */
include/configs/FLAGADM.h +3 -0
index d831238..0f4277c 100644
@@ -173,6 +173,9 @@
 #if defined(CONFIG_CMD_KGDB)
 #define CONFIG_SYS_CACHELINE_SHIFT	4	/* log base 2 of the above value	*/
 #endif
+#define CONFIG_SYS_DELAYED_ICACHE	1	/* enable ICache not before
+						 * running in RAM.
+						 */
 
 /*-----------------------------------------------------------------------
  * SYPCR - System Protection Control				11-9
include/configs/IP860.h +3 -0
index b9c5713..125aa6c 100644
@@ -209,6 +209,9 @@
 #if defined(CONFIG_CMD_KGDB)
 #define CONFIG_SYS_CACHELINE_SHIFT	4	/* log base 2 of the above value	*/
 #endif
+#define CONFIG_SYS_DELAYED_ICACHE	1	/* enable ICache not before
+						 * running in RAM.
+						 */
 
 /*-----------------------------------------------------------------------
  * SYPCR - System Protection Control				11-9
include/configs/pcu_e.h +3 -0
index 9214519..7c2bf1b 100644
@@ -246,6 +246,9 @@
  */
 #define CONFIG_SYS_CACHELINE_SIZE	16	/* For all MPC8xx CPUs			*/
 #define CONFIG_SYS_CACHELINE_SHIFT	4	/* log base 2 of the above value	*/
+#define CONFIG_SYS_DELAYED_ICACHE	1	/* enable ICache not before
+						 * running in RAM.
+						 */
 
 /*-----------------------------------------------------------------------
  * SYPCR - System Protection Control				11-9
lib_ppc/board.c +1 -2
index 6d29303..f69c5f4 100644
@@ -736,8 +736,7 @@ void board_init_r (gd_t *id, ulong dest_addr)
 
 	WATCHDOG_RESET();
 
-#if defined(CONFIG_IP860) || defined(CONFIG_PCU_E) || \
-	defined (CONFIG_FLAGADM) || defined(CONFIG_MPC83XX)
+#if defined(CONFIG_SYS_DELAYED_ICACHE) || defined(CONFIG_MPC83XX)
 	icache_enable ();	/* it's time to enable the instruction cache */
 #endif
 
Signature · 5 lines
1.6.0.6

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#1 lore raw

PATCH v2 2/6 8xx, icache: enabling ICache not before running from RAM

Dear Heiko Schocher,

Quoted 4 lines · In message <[email protected]> you wrote:

with the new CONFIG_SYS_DELAYED_ICACHE config option, ICache is not enabled before code runs from RAM.

Quoted 8 lines
---
 README                    |    5 +++++
 cpu/mpc8xx/start.S        |    2 +-
 include/configs/FLAGADM.h |    3 +++
 include/configs/IP860.h   |    3 +++
 include/configs/pcu_e.h   |    3 +++
 lib_ppc/board.c           |    3 +--
 6 files changed, 16 insertions(+), 3 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are no data that cannot be plotted on a straight  line  if  the
axis are chosen correctly.