Fix crash on resolution change -> screen dump -> vga redraw
PATCH 1/1 Fix crash on resolution change -> screen dump -> vga redraw
The vga screen dump function updates last_width and last_height, but does not change the DisplaySurface that these variables describe. A consequent vga_draw_graphic() will therefore fail to resize the surface and crash.
Fix by invalidating the display state after a screen dump, forcing vga_draw_graphic() to reallocate the DisplaySurface.
--- hw/vga.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
hw/vga.c +1 -0
@@ -2678,4 +2678,5 @@ static void vga_screen_dump(void *opaque, const char *filename)vga_screen_dump_graphic (s, filename); elsevga_screen_dump_text (s ,filename ); +vga_invalidate_display (s); }
Signature · 1 line
1.6.0.6
Anthony Liguori
AppliedQuoted 10 lines · Avi Kivity
The vga screen dump function updates
last_widthandlast_height, but does not change the DisplaySurface that these variables describe. A consequentvga_draw_graphic()will therefore fail to resize the surface and crash.Fix by invalidating the display state after a screen dump, forcing
vga_draw_graphic()to reallocate the DisplaySurface.Signed-off-by Avi Kivity <[email protected]>
Applied. Thanks.
Regards,
Anthony Liguori
Quoted 15 lines
--- hw/vga.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)hw/vga.c +1
-0@@ -2678,4 +2678,5 @@ static void vga_screen_dump(void *opaque, const char *filename)vga_screen_dump_graphic (s, filename); elsevga_screen_dump_text (s ,filename ); +vga_invalidate_display (s); }
Signature · 3 lines
Regards, Anthony Liguori