Skip to contentSkip to conversation

powerpc/86xx: Add binding for LAWs and MCM

PATCH New Kumar Gala 3 participants 3 messages Apr 27, 2009 – Apr 28, 2009

Subsystems (3)
lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/2 powerpc/86xx: Add binding for LAWs and MCM

The first 4k region of CCSR space is well defined for local access windows, CCSRBAR, etc. The second 4k region is well defined as register for configuring and getting errors for the MPX coherency module.

---
 Documentation/powerpc/dts-bindings/fsl/mcm.txt |   64 ++++++++++++++++++++++++
 1 files changed, 64 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/powerpc/dts-bindings/fsl/mcm.txt
Documentation/powerpc/dts-bindings/fsl/mcm.txt new file +64 -0
new file mode 100644
index 0000000..4ceda9b
@@ -0,0 +1,64 @@
+=====================================================================
+MPX LAW & Coherency Module Device Tree Binding
+Copyright (C) 2009 Freescale Semiconductor Inc.
+=====================================================================
+
+Local Access Window (LAW) Node
+
+The LAW node represents the region of CCSR space where local access
+windows are configured.  For MCM based devices this is the first 4k
+of CCSR space that includes CCSRBAR, ALTCBAR, ALTCAR, BPTR, and some
+number of local access windows as specified by fsl,num-laws.
+
+PROPERTIES
+
+  - compatible
+      Usage: required
+      Value type: <string>
+      Definition: Must include "fsl,mcm-law"
+
+  - reg
+      Usage: required
+      Value type: <prop-encoded-array>
+      Definition: A standard property.  The value specifies the
+          physical address offset and length of the CCSR space
+          registers.
+
+  - fsl,num-laws
+      Usage: required
+      Value type: <u32>
+      Definition: The value specifies the number of local access
+          windows for this device.
+
+=====================================================================
+
+MPX Coherency Module Node
+
+The MPX LAW node represents the region of CCSR space where MCM config
+and error reporting registers exist, this is the second 4k (0x1000)
+of CCSR space.
+
+PROPERTIES
+
+  - compatible
+      Usage: required
+      Value type: <string>
+      Definition: Must include "fsl,CHIP-mcm", "fsl,mcm" where
+      CHIP is the processor (mpc8641, mpc8610, etc.)
+
+  - reg
+      Usage: required
+      Value type: <prop-encoded-array>
+      Definition: A standard property.  The value specifies the
+          physical address offset and length of the CCSR space
+          registers.
+
+   - interrupts
+      Usage: required
+      Value type: <prop-encoded-array>
+
+   - interrupt-parent
+      Usage: required
+      Value type: <phandle>
+
+=====================================================================
Signature · 1 line
1.6.0.6
#1 lore raw

PATCH 2/2 powerpc/86xx: Add new LAW & MCM device tree nodes for all 86xx systems

---
 arch/powerpc/boot/dts/gef_ppc9a.dts        |   13 +++++++++++++
 arch/powerpc/boot/dts/gef_sbc310.dts       |   13 +++++++++++++
 arch/powerpc/boot/dts/gef_sbc610.dts       |   13 +++++++++++++
 arch/powerpc/boot/dts/mpc8610_hpcd.dts     |   13 +++++++++++++
 arch/powerpc/boot/dts/mpc8641_hpcn.dts     |   13 +++++++++++++
 arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts |   13 +++++++++++++
 arch/powerpc/boot/dts/sbc8641d.dts         |   13 +++++++++++++
 7 files changed, 91 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/gef_ppc9a.dts +13 -0
index d47ad07..cbf135c 100644
@@ -166,6 +166,19 @@
 		reg = <0xfef00000 0x100000>;	// CCSRBAR 1M
 		bus-frequency = <33333333>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8641-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c1: i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/powerpc/boot/dts/gef_sbc310.dts +13 -0
index 1569117..155776c 100644
@@ -166,6 +166,19 @@
 		reg = <0xfef00000 0x100000>;	// CCSRBAR 1M
 		bus-frequency = <33333333>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8641-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c1: i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/powerpc/boot/dts/gef_sbc610.dts +13 -0
index 6582dbd..6898d7e 100644
@@ -131,6 +131,19 @@
 		reg = <0xfef00000 0x100000>;	// CCSRBAR 1M
 		bus-frequency = <33333333>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8641-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c1: i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/powerpc/boot/dts/mpc8610_hpcd.dts +13 -0
index 4f081bb..252db6e 100644
@@ -115,6 +115,19 @@
 		reg = <0xe0000000 0x1000>;
 		bus-frequency = <0>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8610-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/powerpc/boot/dts/mpc8641_hpcn.dts +13 -0
index 51852e6..8bcccd7 100644
@@ -117,6 +117,19 @@
 		reg = <0xffe00000 0x00001000>;	// CCSRBAR
 		bus-frequency = <0>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8641-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts +13 -0
index b5dc942..d4c909d 100644
@@ -110,6 +110,19 @@
 		reg = <0x0f 0xffe00000 0x0 0x00001000>;	// CCSRBAR
 		bus-frequency = <0>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8641-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
arch/powerpc/boot/dts/sbc8641d.dts +13 -0
index cfd5782..aa8f931 100644
@@ -129,6 +129,19 @@
 		reg = <0xf8000000 0x00001000>;	// CCSRBAR
 		bus-frequency = <0>;
 
+		mcm-law@0 {
+			compatible = "fsl,mcm-law";
+			reg = <0x0 0x1000>;
+			fsl,num-laws = <10>;
+		};
+
+		mcm@1000 {
+			compatible = "fsl,mpc8641-mcm", "fsl,mcm";
+			reg = <0x1000 0x1000>;
+			interrupts = <17 2>;
+			interrupt-parent = <&mpic>;
+		};
+
 		i2c@3000 {
 			#address-cells = <1>;
 			#size-cells = <0>;
Signature · 1 line
1.6.0.6
#2 lore raw

Re: [PATCH 2/2] powerpc/86xx: Add new LAW & MCM device tree nodes for all 86xx systems

Quoted 11 lines · Kumar Gala
---
 arch/powerpc/boot/dts/gef_ppc9a.dts        |   13 +++++++++++++
 arch/powerpc/boot/dts/gef_sbc310.dts       |   13 +++++++++++++
 arch/powerpc/boot/dts/gef_sbc610.dts       |   13 +++++++++++++
 arch/powerpc/boot/dts/mpc8610_hpcd.dts     |   13 +++++++++++++
 arch/powerpc/boot/dts/mpc8641_hpcn.dts     |   13 +++++++++++++
 arch/powerpc/boot/dts/mpc8641_hpcn_36b.dts |   13 +++++++++++++
 arch/powerpc/boot/dts/sbc8641d.dts         |   13 +++++++++++++
 7 files changed, 91 insertions(+), 0 deletions(-)

Am I right in thinking that this patch doesn't (as yet) enable any added functionality, or have I missed something?

I assume this is destined for next (as it relies on Becky's "powerpc/86xx: Add 36-bit device tree for mpc8641hpcn"), assuming this, fwiw, seems good to me.

Martyn

Signature · 4 lines
Martyn Welch MEng MPhil MIET (Principal Software Engineer)   T:+44(0)1327322748
GE Fanuc Intelligent Platforms Ltd,        |Registered in England and Wales
Tove Valley Business Park, Towcester,      |(3828642) at 100 Barbirolli Square,
Northants, NN12 6PF, UK T:+44(0)1327359444 |Manchester,M2 3AB  VAT:GB 927559189