Skip to contentSkip to conversation

coretemp: Add Lynnfield CPU

PATCH In review Huaxu Wan 4 participants 6 messages Sep 15, 2009 – Oct 12, 2009

Subsystems (2)
lore
Share & tools
lore

Huaxu Wan

author
#0 lore raw

PATCH 1/1 coretemp: Add Lynnfield CPU

Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.

---
 drivers/hwmon/coretemp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/coretemp.c +2 -2
index 93c1722..a9a21dc 100644
@@ -413,11 +413,11 @@ static int __init coretemp_init(void)
        for_each_online_cpu(i) {
                struct cpuinfo_x86 *c = &cpu_data(i);
 
-               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */
+               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A, 0x1E */
                if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
                    !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
                        (c->x86_model = 0x16) || (c->x86_model = 0x17) ||
-                       (c->x86_model = 0x1A))) {
+                       (c->x86_model = 0x1A) || (c->x86_model = 0x1E))) {
 
                        /* supported CPU not found, but report the unknown
                           family 6 CPU */

--

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#1 lore raw

Hi,

Looks good. However I would like to see the Documentation/hwmon/coretemp updated too.

Maybe Intel can overtake the driver maintainership because I'm quite struggling to get any info from Intel. Second reason is lack of free time.

Thank you,

Rudolf

Huaxu Wan napsal(a):

Quoted 17 lines

Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.

---
 drivers/hwmon/coretemp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/coretemp.c +0 -1
index 93c1722..a9a21dc 100644
@@ -413,11 +413,11 @@ static int __init coretemp_init(void)
        for_each_online_cpu(i) {
                struct cpuinfo_x86 *c = &cpu_data(i);
 
-               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */

drivers/hwmon/coretemp.c static int __init coretemp_init(void)

Quoted 10 lines
drivers/hwmon/coretemp.c +2 -2
+               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A, 0x1E */
                if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
                    !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
                        (c->x86_model = 0x16) || (c->x86_model = 0x17) ||
-                       (c->x86_model = 0x1A))) {
+                       (c->x86_model = 0x1A) || (c->x86_model = 0x1E))) {
 
                        /* supported CPU not found, but report the unknown
                           family 6 CPU */
--

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw
In reply to Huaxu Wan
Quoted 5 lines · Jean Delvare
Quoted 2 lines · Rudolf Marek

Looks good. However I would like to see the Documentation/hwmon/coretemp updated too.

I'll take care of that.

Thanks Jean.

Quoted 5 lines
Quoted 3 lines

Maybe Intel can overtake the driver maintainership because I'm quite struggling to get any info from Intel. Second reason is lack of free time.

Huaxu, Kent, can you please comment on this?

Hmmm... I am looking for an Intel internal support for this maintainership, since I usually not receive such documents either. I would like to take once this can be resolved.

Quoted 5 lines
Quoted 3 lines

Huaxu Wan napsal(a):

Quoted 1 line

Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.

What are the TjMax and TTarget temperatures for these CPUs?

So far I do not find them in datasheet. Let me check what I can find more.

Thanks,
Kent

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw
In reply to Huaxu Wan

Hello Rudolf

Yes. I think Huaxu and I can take this, even though I am still on the way to acquire enough documents from hardware team. As I have a lot of processors on hand to test, maybe it's better to gain more coverage in coretemp driver.

Please let me know what I need to do regarding to take the maintainership. We are not experienced in doing so.

Thanks,
Kent

Quoted 38 lines · Rudolf Marek

Hi,

Looks good. However I would like to see the Documentation/hwmon/coretemp updated too.

Maybe Intel can overtake the driver maintainership because I'm quite struggling to get any info from Intel. Second reason is lack of free time.

Thank you,

Rudolf

Huaxu Wan napsal(a):

Quoted 24 lines

Add Lynnfield processor support. Lynnfield is a quad-core Nehalem based microprocessor for Desktop market, which is introduced in September 2009.

---
 drivers/hwmon/coretemp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/coretemp.c +2 -2
index 93c1722..a9a21dc 100644
@@ -413,11 +413,11 @@ static int __init coretemp_init(void)
        for_each_online_cpu(i) {
                struct cpuinfo_x86 *c = &cpu_data(i);
 
-               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A */
+               /* check if family 6, models 0xe, 0xf, 0x16, 0x17, 0x1A, 0x1E */
                if ((c->cpuid_level < 0) || (c->x86 != 0x6) ||
                    !((c->x86_model = 0xe) || (c->x86_model = 0xf) ||
                        (c->x86_model = 0x16) || (c->x86_model = 0x17) ||
-                       (c->x86_model = 0x1A))) {
+                       (c->x86_model = 0x1A) || (c->x86_model = 0x1E))) {
 
Quoted 4 lines

drivers/hwmon/coretemp.c static int __init coretemp_init(void)

Quoted 3 lines
drivers/hwmon/coretemp.c +0 -1
                        /* supported CPU not found, but report the unknown
                           family 6 CPU */
--

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#4 lore raw
In reply to Huaxu Wan

Hi Kent,

Quoted 6 lines · Kent Liu

Yes. I think Huaxu and I can take this, even though I am still on the way to acquire enough documents from hardware team. As I have a lot of processors on hand to test, maybe it's better to gain more coverage in coretemp driver.

Please let me know what I need to do regarding to take the maintainership. We are not experienced in doing so.

Simply send us a patch updating the "CORETEMP HARDWARE MONITORING DRIVER" entry in file MAINTAINERS. Set the M: field to the new maintainer (format is "name <address>"). You can have several M: fields if there will be several maintainers. And that's all :)

Once we receive the patch, I'll pick it and push it upstream in a timely manner.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#5 lore raw
In reply to Huaxu Wan

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Kent,

Quoted 2 lines

Please let me know what I need to do regarding to take the maintainership. We are not experienced in doing so.

Yes thats it what Jean said to you. Many thanks for this!

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkrTl88ACgkQ3J9wPJqZRNV2hwCgopnemKT4J5dBmiir3Q8qjGhu vP0AniGrMsD+aZRAzcubADm4wINHLT23
=Vukl
-----END PGP SIGNATURE-----

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors