Skip to contentSkip to conversation

Fix for Void function returning value in sbc35-a9g20

PATCH New s-paulraj at ti.com 3 participants 3 messages Oct 28, 2009 – Nov 23, 2009 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix for Void function returning value in sbc35-a9g20

From: Sandeep Paulraj <[email protected]>

Void function was returning 0 in the m41t94 rtc driver. This makes it similar to m41t62 rtc driver.

---
 drivers/rtc/m41t94.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/m41t94.c +0 -1
index 02b41d9..5b665bb 100644
@@ -120,5 +120,4 @@ void rtc_reset(void)
 	 * Could not be tested as the reset pin is not wired on
 	 * the sbc35-ag20 board
 	 */
-	return 0;
 }
Signature · 1 line
1.6.0.4
Applied
#1 lore raw

PATCH 1/1 Fix for Void function returning value in sbc35-a9g20

Quoted 15 lines · s-paulraj at ti.com

From: Sandeep Paulraj <[email protected]>

Void function was returning 0 in the m41t94 rtc driver. This makes it similar to m41t62 rtc driver.

---
 drivers/rtc/m41t94.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/m41t94.c +0 -0
index 02b41d9..5b665bb 100644

drivers/rtc/m41t94.c void rtc_reset(void) · line 123

Quoted 5 lines
drivers/rtc/m41t94.c +0 -1
@@ -120,5 +120,4 @@ void rtc_reset(void)
 	 * Could not be tested as the reset pin is not wired on
 	 * the sbc35-ag20 board
 	 */
-	return 0;
 }

Yes this does kill the warning.
Ack-ed

pushed to arm/next.
Tom

#2 lore raw

PATCH 1/1 Fix for Void function returning value in sbc35-a9g20

Dear Tom,

Quoted 25 lines · In message <[email protected]> you wrote:
Quoted 15 lines · s-paulraj at ti.com

From: Sandeep Paulraj <[email protected]>

Void function was returning 0 in the m41t94 rtc driver. This makes it similar to m41t62 rtc driver.

---
 drivers/rtc/m41t94.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/rtc/m41t94.c +0 -0
index 02b41d9..5b665bb 100644

drivers/rtc/m41t94.c void rtc_reset(void) · line 123

Quoted 5 lines
drivers/rtc/m41t94.c +0 -1
@@ -120,5 +120,4 @@ void rtc_reset(void)
 	 * Could not be tested as the reset pin is not wired on
 	 * the sbc35-ag20 board
 	 */
-	return 0;
 }

Yes this does kill the warning.
Ack-ed

Quoted 1 line

pushed to arm/next.

Why next? This is a bug fix, isn't it? Let's include it now.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Niklaus Wirth has lamented that, whereas Europeans pronounce his name
correctly (Ni-klows Virt), Americans invariably mangle it into (Nick-
les Worth). Which is to say that Europeans  call  him  by  name,  but
Americans call him by value.