Skip to contentSkip to conversation

e1000 fix: read access to some registers is missing.

PATCH In review Kay Ackermann 2 participants 2 messages Oct 31, 2009 – Nov 1, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000 fix: read access to some registers is missing.

While writing working on an e1000 driver for my university's OS I noticed that some registers aren't readable in QEMU, but they should be readable as stated in Intels Driver Developer Manual (and also verified on real hardware).

hw/e1000.c +2 -0
index 028afd1..3987e70 100644
@@ -789,6 +789,8 @@ static uint32_t (*macreg_readops[])(E1000State *, int) = {
     getreg(MANC),	getreg(MDIC),	getreg(SWSM),	getreg(STATUS),
     getreg(TORL),	getreg(TOTL),	getreg(IMS),	getreg(TCTL),
     getreg(RDH),	getreg(RDT),	getreg(VET),	getreg(ICS),
+    getreg(TDBAL),	getreg(TDBAH),	getreg(RDBAH),	getreg(RDBAL),
+    getreg(TDLEN),	getreg(RDLEN),
 
     [TOTH] = mac_read_clr8,	[TORH] = mac_read_clr8,	[GPRC] = mac_read_clr4,
     [GPTC] = mac_read_clr4,	[TPR] = mac_read_clr4,	[TPT] = mac_read_clr4,

Oh and is there any specific reason why Jumbo-Frames are limited to 4k instead of i.e. Alteon 9014 bytes?

Regards,
Kay Ackermann

#1 lore raw
Quoted 45 lines · Kay Ackermann

While writing working on an e1000 driver for my university's OS I

noticed that some registers aren't readable in QEMU, but they should

be readable as stated in Intels Driver Developer Manual (and also

verified on real hardware).

hw/e1000.c +0 -0

index 028afd1..3987e70 100644

--- a/hw/e1000.c

+++ b/hw/e1000.c

hw/e1000.c +2 -0
@@ -789,6 +789,8 @@ static uint32_t (*macreg_readops[])(E1000State *, 
 int) = {
 
     getreg(MANC),        getreg(MDIC),        getreg(SWSM),       
 getreg(STATUS),
 
     getreg(TORL),        getreg(TOTL),        getreg(IMS),       
 getreg(TCTL),
 
     getreg(RDH),        getreg(RDT),        getreg(VET),       
 getreg(ICS),
 
+    getreg(TDBAL),        getreg(TDBAH),        getreg(RDBAH),       
 getreg(RDBAL),
 
+    getreg(TDLEN),        getreg(RDLEN),
 
     [TOTH] = mac_read_clr8,        [TORH] = mac_read_clr8,       
 [GPRC] = mac_read_clr4,
 
     [GPTC] = mac_read_clr4,        [TPR] = mac_read_clr4,       
 [TPT] = mac_read_clr4,
Quoted 4 lines

Oh and is there any specific reason why Jumbo-Frames are limited to 4k instead of i.e. Alteon 9014 bytes?

There used to be a 4K buffer somewhere in the path. I think it's larger now.

Signature · 1 line
error compiling committee.c: too many arguments to function