Skip to contentSkip to conversation

v4l-dvb daily build 2.6.22 and up: ERRORS, 2.6.16-2.6.21: OK

cron job In review Hans Verkuil 3 participants 4 messages Jan 3, 2010 – Jan 4, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below.

Results of the daily build of v4l-dvb:

date:        Sun Jan  3 19:00:03 CET 2010
path:        http://www.linuxtv.org/hg/v4l-dvb
changeset:   13879:b6b82258cf5e
gcc version: gcc (GCC) 4.3.1
hardware:    x86_64
host os:     2.6.26

linux-2.6.30-armv5: OK
linux-2.6.31-armv5: OK
linux-2.6.32-armv5: OK
linux-2.6.33-rc2-armv5: ERRORS
linux-2.6.32-armv5-davinci: OK
linux-2.6.33-rc2-armv5-davinci: ERRORS
linux-2.6.30-armv5-ixp: OK
linux-2.6.31-armv5-ixp: OK
linux-2.6.32-armv5-ixp: OK
linux-2.6.33-rc2-armv5-ixp: ERRORS
linux-2.6.30-armv5-omap2: OK
linux-2.6.31-armv5-omap2: OK
linux-2.6.32-armv5-omap2: OK
linux-2.6.33-rc2-armv5-omap2: ERRORS
linux-2.6.22.19-i686: OK
linux-2.6.23.12-i686: OK
linux-2.6.24.7-i686: OK
linux-2.6.25.11-i686: OK
linux-2.6.26-i686: OK
linux-2.6.27-i686: OK
linux-2.6.28-i686: OK
linux-2.6.29.1-i686: WARNINGS
linux-2.6.30-i686: OK
linux-2.6.31-i686: WARNINGS
linux-2.6.32-i686: WARNINGS
linux-2.6.33-rc2-i686: ERRORS
linux-2.6.30-m32r: OK
linux-2.6.31-m32r: OK
linux-2.6.32-m32r: OK
linux-2.6.33-rc2-m32r: ERRORS
linux-2.6.30-mips: WARNINGS
linux-2.6.31-mips: OK
linux-2.6.32-mips: OK
linux-2.6.33-rc2-mips: ERRORS
linux-2.6.30-powerpc64: WARNINGS
linux-2.6.31-powerpc64: OK
linux-2.6.32-powerpc64: WARNINGS
linux-2.6.33-rc2-powerpc64: ERRORS
linux-2.6.22.19-x86_64: OK
linux-2.6.23.12-x86_64: OK
linux-2.6.24.7-x86_64: OK
linux-2.6.25.11-x86_64: OK
linux-2.6.26-x86_64: OK
linux-2.6.27-x86_64: OK
linux-2.6.28-x86_64: OK
linux-2.6.29.1-x86_64: WARNINGS
linux-2.6.30-x86_64: OK
linux-2.6.31-x86_64: WARNINGS
linux-2.6.32-x86_64: WARNINGS
linux-2.6.33-rc2-x86_64: ERRORS
spec: OK
sparse (linux-2.6.32): ERRORS
sparse (linux-2.6.33-rc2): ERRORS
linux-2.6.16.61-i686: OK
linux-2.6.17.14-i686: OK
linux-2.6.18.8-i686: OK
linux-2.6.19.5-i686: OK
linux-2.6.20.21-i686: OK
linux-2.6.21.7-i686: OK
linux-2.6.16.61-x86_64: OK
linux-2.6.17.14-x86_64: OK
linux-2.6.18.8-x86_64: OK
linux-2.6.19.5-x86_64: OK
linux-2.6.20.21-x86_64: OK
linux-2.6.21.7-x86_64: OK

Detailed results are available here:

http://www.xs4all.nl/~hverkuil/logs/Sunday.log

Full logs are available here:

http://www.xs4all.nl/~hverkuil/logs/Sunday.tar.bz2

The V4L-DVB specification from this daily build is here:

http://www.xs4all.nl/~hverkuil/spec/media.html

#1 lore raw

PATCH 1/1 rj54n1cb0c: remove compiler warning

From: Márton Németh <[email protected]>

Remove the following compiler warning: 'dummy' is used uninitialized in this function. Although the result in the dummy variable is not used the program flow in soc_camera_limit_side() depends on the value in dummy. The program flow is better to be deterministic.

---

linux/drivers/media/video/rj54n1cb0c.c +1 -1
diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c
@@ -563,7 +563,7 @@
 	struct i2c_client *client = sd->priv;
 	struct rj54n1 *rj54n1 = to_rj54n1(client);
 	struct v4l2_rect *rect = &a->c;
-	unsigned int dummy, output_w, output_h,
+	unsigned int dummy = 0, output_w, output_h,
 		input_w = rect->width, input_h = rect->height;
 	int ret;
 
#2 lore raw

Re: [PATCH] rj54n1cb0c: remove compiler warning

Hi Márton

Quoted 8 lines · Németh Márton

From: Márton Németh <[email protected]>

Remove the following compiler warning: 'dummy' is used uninitialized in this function. Although the result in the dummy variable is not used the program flow in soc_camera_limit_side() depends on the value in dummy. The program flow is better to be deterministic.

The patch is good, the only slight problem - you have non-ASCII characters in your name and you didn't use UTF-8 to send this mail, which, I think, is the accepted encoding in the Linux kernel. I converted your patch to utf8 and attached to this mail. Please verify that the result is correct.

linux/drivers/media/video/rj54n1cb0c.c line 569

Quoted 13 lines

---
diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c

linux/drivers/media/video/rj54n1cb0c.c +1 -1
@@ -563,7 +563,7 @@
 	struct i2c_client *client = sd->priv;
 	struct rj54n1 *rj54n1 = to_rj54n1(client);
 	struct v4l2_rect *rect = &a->c;
-	unsigned int dummy, output_w, output_h,
+	unsigned int dummy = 0, output_w, output_h,
 		input_w = rect->width, input_h = rect->height;
 	int ret;
 

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

From [email protected] Sun Jan 3 21:38:51 2010
Date: Sun, 03 Jan 2010 21:34:59 +0100
From: Németh Márton <[email protected]>
To: Guennadi Liakhovetski <[email protected]>
Cc: Hans Verkuil <[email protected]>, V4L Mailing List <[email protected]>
Subject: [PATCH] rj54n1cb0c: remove compiler warning

From: Márton Németh <[email protected]>

Remove the following compiler warning: 'dummy' is used uninitialized in this function. Although the result in the dummy variable is not used the program flow in soc_camera_limit_side() depends on the value in dummy. The program flow is better to be deterministic.

---

linux/drivers/media/video/rj54n1cb0c.c +1 -1
diff -r 62ee2b0f6556 linux/drivers/media/video/rj54n1cb0c.c
@@ -563,7 +563,7 @@
 	struct i2c_client *client = sd->priv;
 	struct rj54n1 *rj54n1 = to_rj54n1(client);
 	struct v4l2_rect *rect = &a->c;
-	unsigned int dummy, output_w, output_h,
+	unsigned int dummy = 0, output_w, output_h,
 		input_w = rect->width, input_h = rect->height;
 	int ret;
#3 lore raw

Re: [PATCH] rj54n1cb0c: remove compiler warning

Quoted 11 lines · Guennadi Liakhovetski

Hi Márton

Quoted 7 lines · Németh Márton

From: Márton Németh <[email protected]>

Remove the following compiler warning: 'dummy' is used uninitialized in this function. Although the result in the dummy variable is not used the program flow in soc_camera_limit_side() depends on the value in dummy. The program flow is better to be deterministic.

Quoted 6 lines
Quoted 1 line

The patch is good, the only slight problem - you have non-ASCII characters in your name and you didn't use UTF-8 to send this mail, which, I think, is the accepted encoding in the Linux kernel. I converted your patch to utf8 and attached to this mail. Please verify that the result is correct.

Your conversion is OK. Sorry about this issue.

Regards,

Márton Németh