Skip to contentSkip to conversation

tx25: fix crash while booting Linux

PATCH New Anatolij Gustschin 4 participants 5 messages Apr 21, 2010 – May 6, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tx25: fix crash while booting Linux

Currently booting Linux on TX25 board doesn't work since there is no correct mach-id and boot parameters setup for tx25 board. Fix it now.

---
 board/karo/tx25/tx25.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
board/karo/tx25/tx25.c +3 -0
index 4d6a96d..2608698 100644
@@ -145,6 +145,9 @@ int board_init()
 
 	mx25_uart_init_pins();
 #endif
+	/* board id for linux */
+	gd->bd->bi_arch_number = MACH_TYPE_TX25;
+	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 	return 0;
 }
 
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 1/1 tx25: fix crash while booting Linux

Dear Stefano,

In message <[email protected]> Anatolij

Quoted 10 lines · Gustschin

Currently booting Linux on TX25 board doesn't work since there is no correct mach-id and boot parameters setup for tx25 board. Fix it now.

---
 board/karo/tx25/tx25.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I wish Captain Vimes were here. He wouldn't have  known  what  to  do
either, but he's got a much better vocabulary to be baffled in.
                                 - Terry Pratchett, _Guards! Guards!_
#2 lore raw

PATCH 1/1 tx25: fix crash while booting Linux

In reply to Anatolij Gustschin
Quoted 16 lines · Anatolij Gustschin

Currently booting Linux on TX25 board doesn't work since there is no correct mach-id and boot parameters setup for tx25 board. Fix it now.

---
 board/karo/tx25/tx25.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
board/karo/tx25/tx25.c +0 -0
index 4d6a96d..2608698 100644

board/karo/tx25/tx25.c int board_init() · line 153

Quoted 9 lines
board/karo/tx25/tx25.c +3 -0
@@ -145,6 +145,9 @@ int board_init()
 
 	mx25_uart_init_pins();
 #endif
+	/* board id for linux */
+	gd->bd->bi_arch_number = MACH_TYPE_TX25;
+	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 	return 0;
 }
 

Applied to u-boot-imx, thanks.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 tx25: fix crash while booting Linux

Dear Stefano Babic,

Quoted 18 lines · In message <[email protected]> you wrote:
Quoted 17 lines · Anatolij Gustschin

Currently booting Linux on TX25 board doesn't work since there is no correct mach-id and boot parameters setup for tx25 board. Fix it now.

---
 board/karo/tx25/tx25.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
board/karo/tx25/tx25.c +0 -0
index 4d6a96d..2608698 100644
@@ -145,6 +145,9 @@ int board_init()
 
Quoted 10 lines

board/karo/tx25/tx25.c int board_init() · line 153

Quoted 8 lines
board/karo/tx25/tx25.c +3 -0
 	mx25_uart_init_pins();
 #endif
+	/* board id for linux */
+	gd->bd->bi_arch_number = MACH_TYPE_TX25;
+	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 	return 0;
 }
 

Applied to u-boot-imx, thanks.

Will you send a pull request to Tom any time soon?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4
#4 lore raw

PATCH 1/1 tx25: fix crash while booting Linux

Hi Wolfgang,

Quoted 38 lines · Wolfgang Denk

From: Wolfgang Denk <[email protected]>
Subject: Re: [U-Boot] [PATCH] tx25: fix crash while booting Linux
To: "Stefano Babic" <[email protected]>
Cc: u-boot at lists.denx.de, "John Rigby" <[email protected]>
Date: Wednesday, May 5, 2010, 7:40 PM
Dear Stefano Babic,

In message <[email protected]>

Quoted 2 lines · you
Quoted 1 line · Anatolij Gustschin

Currently booting Linux on TX25 board doesn't

work

Quoted 1 line
Quoted 1 line

since there is no correct mach-id and boot

parameters

Quoted 7 lines
Quoted 7 lines

setup for tx25 board. Fix it now.

---
? board/karo/tx25/tx25.c |? ? 3

+++

Quoted 1 line
Quoted 1 line

? 1 files changed, 3 insertions(+), 0

deletions(-)

Quoted 2 lines

Review

Quoted 2 lines
(quoted diff) +0 -0

b/board/karo/tx25/tx25.c

Quoted 9 lines
Quoted 9 lines

index 4d6a96d..2608698 100644

board/karo/tx25/tx25.c +0 -0
@@ -145,6 +145,9 @@ int board_init()

?
? ??? mx25_uart_init_pins();
? #endif
+??? /* board id for linux */
+??? gd->bd->bi_arch_number

= MACH_TYPE_TX25;

Quoted 1 line
Quoted 1 line

+??? gd->bd->bi_boot_params

Quoted 8 lines

= PHYS_SDRAM_1 + 0x100;

Quoted 5 lines
Quoted 3 lines

? ??? return 0;
? }
?

Applied to u-boot-imx, thanks.

Will you send a pull request to Tom any time soon?

Stefano sent the pull request : http://www.mail-archive.com/u-boot at lists.denx.de/msg31966.html

Regards,

Fabio Estevam