OMAP: features: export symbol omap3_features
Subsystems (3)
PATCH 1/2 OMAP: features: export symbol omap3_features
From: Kevin Hilman <[email protected]>
Since omap3_features is a global variable, only code built-in the kernel can make use of it and thus use omap_has ##feat functions; exporting this as a kernel symbol makes modules able to use feature detection framework too.
Thread: http://marc.info/?l=linux-omap&m=128528822902211&w=2
--- arch/arm/mach-omap2/id.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/id.c +1 -0
@@ -31,6 +31,7 @@ static struct omap_chip_id omap_chip;static unsigned int omap_revision;u32 omap3_features; +EXPORT_SYMBOL (omap3_features);unsigned int omap_rev (void ) {
Signature · 1 line
1.7.1
PATCH 2/2 omap: mailbox: fix detection for previously supported chips
Fix the mailbox detection for OMAP3630, 3530/25 and 2430.
Given that 2430 has an iva too include it, as the same steps for omap3 apply.
--- arch/arm/mach-omap2/mailbox.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/mailbox.c +8 -4
@@ -394,15 +394,19 @@ static int __devinit omap2_mbox_probe(struct platform_device *pdev)if (false) ; -#if defined(CONFIG_ARCH_OMAP3430 ) - else if (cpu_is_omap3430()) { +#if defined(CONFIG_ARCH_OMAP3 ) + else if (omap3_has_iva()) { list = omap3_mboxes; list[0 ]->irq =platform_get_irq_byname (pdev,"dsp" ); }#endif -#if defined(CONFIG_ARCH_OMAP2420 ) - else if (cpu_is_omap2420()) { +#if defined(CONFIG_ARCH_OMAP2 ) + else if (cpu_is_omap2430()) { + list = omap2_mboxes; + + list[0 ]->irq =platform_get_irq_byname (pdev,"dsp" ); + } else if (cpu_is_omap2420()) { list = omap2_mboxes; list[0 ]->irq =platform_get_irq_byname (pdev,"dsp" );
Signature · 1 line
1.7.1
PATCH 1/2 OMAP: features: export symbol omap3_features
In reply to Omar Ramirez LunaQuoted 1 line · Omar Ramirez Luna
From: Kevin Hilman <[email protected]>
Minor nit, can you make the subject something like:
OMAP: features: make feature checks available to modules
Thanks,
Kevin
Quoted 33 lines
Since
omap3_featuresis a global variable, only code built-in the kernel can make use of it and thus useomap_has##feat functions; exporting this as a kernel symbol makes modules able to use feature detection framework too.Thread: http://marc.info/?l=linux-omap&m=128528822902211&w=2
Signed-off-by Kevin Hilman <[email protected]>Signed-off-by Omar Ramirez Luna <[email protected]>CC Tony Lindgren <[email protected]>CC Russell King <[email protected]>CC Nishanth Menon <[email protected]>CC Paul Walmsley <[email protected]>CC Sanjeev Premi <[email protected]>CC linux-omap at vger.kernel.orgCC linux-arm-kernel at lists.infradead.org--- arch/arm/mach-omap2/id.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-omap2/id.c +1
-0@@ -31,6 +31,7 @@ static struct omap_chip_id omap_chip;static unsigned int omap_revision;u32 omap3_features; +EXPORT_SYMBOL (omap3_features);unsigned int omap_rev (void ) {
PATCH 1/2 OMAP: features: export symbol omap3_features
In reply to Omar Ramirez LunaHi Omar, Kevin,
Quoted 38 lines · Omar Ramirez Luna
From: Kevin Hilman <[email protected]>
Since
omap3_featuresis a global variable, only code built-in the kernel can make use of it and thus useomap_has##feat functions; exporting this as a kernel symbol makes modules able to use feature detection framework too.Thread: http://marc.info/?l=linux-omap&m=128528822902211&w=2
Signed-off-by Kevin Hilman <[email protected]>Signed-off-by Omar Ramirez Luna <[email protected]>CC Tony Lindgren <[email protected]>CC Russell King <[email protected]>CC Nishanth Menon <[email protected]>CC Paul Walmsley <[email protected]>CC Sanjeev Premi <[email protected]>CC linux-omap at vger.kernel.orgCC linux-arm-kernel at lists.infradead.org--- arch/arm/mach-omap2/id.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-omap2/id.c +1
-0@@ -31,6 +31,7 @@ static struct omap_chip_id omap_chip;static unsigned int omap_revision;u32 omap3_features; +EXPORT_SYMBOL (omap3_features);unsigned int omap_rev (void ) {Signature · 1 line
1.7.1
This omap3_features variable should not be used directly by any device drivers since it is an OMAP-ism. This type of feature info should be passed through struct platform_data. Looks like this would be quite easy to add by editing mach-omap2/devices.c and adding platform_data?
...
In the medium-term, definitely all of those
#if defined(CONFIG_ARCH_OMAP*)
and
if (cpu_is_omap*()) {in this driver need to be removed. The integration code (currently in mach-omap2/devices.c) is what should handle this, or better yet, struct dev_attr from hwmod.
Also the entire mailboxes driver at some point should be moved into drivers/* ...
- Paul
PATCH 1/2 OMAP: features: export symbol omap3_features
Paul Walmsley had written, on 09/24/2010 10:34 AM, the following:
[...]
Quoted 23 lines
Quoted 9 lines
u32
omap3_features;
+EXPORT_SYMBOL(omap3_features);unsigned int
omap_rev(void)
{Signature · 1 line
1.7.1This
omap3_featuresvariable should not be used directly by any device drivers since it is an OMAP-ism. This type of feature info should be passed through structplatform_data. Looks like this would be quite easy to add by editingmach-omap2/devices.cand addingplatform_data?...
In the medium-term, definitely all of those
#if defined(CONFIG_ARCH_OMAP*)and
Quoted 8 lines
if (cpu_is_omap*()) {in this driver need to be removed. The integration code (currently in
mach-omap2/devices.c) is what should handle this, or better yet, structdev_attrfrom hwmod.Also the entire mailboxes driver at some point should be moved into
drivers/*...
just my 2 cents:
The intent of omap_has_featureX() is to ensure that the drivers dont do cpu_is_omap123(). Now if we had OMAP dma driver which has DMA chaining - what options do we have DMA driver?
a) we introduce it based on cpu_is_omap123() -> bad bad nightmare for maintenance
b) we introduce it based on module h/w block(TI internal terminology "IP block") revision -> unfortunately no luck in some of the h/w blocks.
c) we use if (omap_has_dma_chaining())
If the hwmod itself was expanded to contain feature, and erratas then it is excellent solution - one stop information source for all drivers and a standardized soln as well.. (but we dont have it on omap1).
by not exporting this, the drivers are restricted to being static, and exporting allows those omap specific ones to be loadable (if someone really wants so minimalist a system - i believe i2c is an example of loadable module)..
I believe omap_has_feature() is a readable and maintainable way of handling features and exporting helps those drivers to become modules (yes with the risk of some other driver misusing it as well) - this definitely is something we've been doing for some time in l-o I guess.. a better alternative might be hwmod - but I am no expert to comment on it's feasibility..
Signature · 2 lines
Regards, Nishanth Menon
PATCH 1/2 OMAP: features: export symbol omap3_features
Quoted 35 lines · Nishanth Menon
Paul Walmsley had written, on 09/24/2010 10:34 AM, the following:
[...]Quoted 19 lines
Quoted 7 lines
u32
omap3_features;
+EXPORT_SYMBOL(omap3_features);
unsigned intomap_rev(void)
{Signature · 1 line
1.7.1This
omap3_featuresvariable should not be used directly by any device drivers since it is an OMAP-ism. This type of feature info should be passed through structplatform_data. Looks like this would be quite easy to add by editingmach-omap2/devices.cand addingplatform_data?...
In the medium-term, definitely all of those
#if defined(CONFIG_ARCH_OMAP*)and
Quoted 8 lines
if (cpu_is_omap*()) {in this driver need to be removed. The integration code (currently in
mach-omap2/devices.c) is what should handle this, or better yet, structdev_attrfrom hwmod.Also the entire mailboxes driver at some point should be moved into
drivers/*...just my 2 cents:
The intent of
omap_has_featureX()is to ensure that the drivers dont docpu_is_omap123(). Now if we had OMAP dma driver which has DMA chaining - what options do we have DMA driver?
Quoted 5 lines
a) we introduce it based on
cpu_is_omap123()-> bad bad nightmare for maintenance
b) we introduce it based on module h/wblock(TI internal terminology "IP block")revision -> unfortunately no luck in some of the h/w blocks.
c) we use if (omap_has_dma_chaining())
d) you pass in errata/feature flags via a platform_data struct, like McBSP, McSPI, MMC, MUSB, I2C, etc. already do on OMAP. On OMAP1, which doesn't have hwmod support, you set your platform_data in your OMAP1 integration code. On OMAP2+ (which has hwmod support), you define your errata/feature flags and any other integration data that you need to pass via the struct omap_hwmod.dev_attr field, then pass that data via struct platform_data in the OMAP2+ integration code. See for example
http://www.mail-archive.com/linux-omap at vger.kernel.org/msg13288.html
and
http://marc.info/?l=linux-omap&m=124419789124570&w=2
(search for "dev_attr" in both cases)
...
As an aside, I think that any errata/features that can be automatically discriminated by the IP block revision register are better handled that way than by platform_data; but of course, as you mention, the hardware people sometimes neglect to bump that when they change something.
- Paul
PATCH 1/2 OMAP: features: export symbol omap3_features
Quoted 12 lines · Paul Walmsley
Quoted 9 lines · Nishanth Menon
The intent of
omap_has_featureX()is to ensure that the drivers dont docpu_is_omap123(). Now if we had OMAP dma driver which has DMA chaining - what options do we have DMA driver?a) we introduce it based on
cpu_is_omap123()-> bad bad nightmare for maintenance
b) we introduce it based on module h/wblock(TI internal terminology "IP block")revision -> unfortunately no luck in some of the h/w blocks.
c) we use if (omap_has_dma_chaining())
Quoted 7 lines
d) you pass in errata/feature flags via a
platform_datastruct, like McBSP, McSPI, MMC, MUSB, I2C, etc. already do on OMAP. On OMAP1, which doesn't have hwmod support, you set yourplatform_datain your OMAP1 integration code. On OMAP2+ (which has hwmod support), you define your errata/feature flags and any other integration data that you need to pass via the struct omap_hwmod.dev_attr field, then pass that data via structplatform_datain the OMAP2+ integration code.
Just to clarify something that may be unclear: there's no problem with calling cpu_is_omapXXXX(), or any other OMAP core-specific function, from the OMAP<->driver integration code, living in arch/arm/*omap*. The results of those functions can then be passed through platform_data. But there is a problem with calling OMAP core-specific functions directly from the driver code itself, since driver code should be completely platform-independent -- e.g., the same DMA controller could exist on OMAP, DaVinci, etc.
- Paul
PATCH 1/2 OMAP: features: export symbol omap3_features
Paul Walmsley had written, on 09/24/2010 12:17 PM, the following:
Quoted 21 lines · Paul Walmsley
Quoted 12 lines · Nishanth Menon
Quoted 10 lines
The intent of
omap_has_featureX()is to ensure that the drivers dont docpu_is_omap123(). Now if we had OMAP dma driver which has DMA chaining - what options do we have DMA driver?a) we introduce it based on
cpu_is_omap123()-> bad bad nightmare for maintenance
b) we introduce it based on module h/wblock(TI internal terminology "IP block")revision -> unfortunately no luck in some of the h/w blocks.
c) we use if (omap_has_dma_chaining())Quoted 7 lines
d) you pass in errata/feature flags via a
platform_datastruct, like McBSP, McSPI, MMC, MUSB, I2C, etc. already do on OMAP. On OMAP1, which doesn't have hwmod support, you set yourplatform_datain your OMAP1 integration code. On OMAP2+ (which has hwmod support), you define your errata/feature flags and any other integration data that you need to pass via the struct omap_hwmod.dev_attr field, then pass that data via structplatform_datain the OMAP2+ integration code.
Quoted 9 lines
Just to clarify something that may be unclear: there's no problem with calling
cpu_is_omapXXXX(), or any other OMAP core-specific function, from the OMAP<->driver integration code, living inarch/arm/*omap*. The results of those functions can then be passed throughplatform_data. But there is a problem with calling OMAP core-specific functions directly from the driver code itself, since driver code should be completely platform-independent -- e.g., the same DMA controller could exist on OMAP, DaVinci, etc.
yep. your comment makes sense now. thanks for clarifying. NAK from me as well.
Signature · 2 lines
Regards, Nishanth Menon