Skip to contentSkip to conversation

arm: arm926ejs: use ELF relocations

RFC PATCH New Albert Aribaud 5 participants 19 messages Oct 4, 2010 – Oct 5, 2010 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

This patch is *not* a submission for master!

It is a proof of concept of ELF relocations for ARM, hastily done in a day's work time for people on the list to try and to comment. All comments are welcome, as several suggestions have been made today on the list that I did not have time to incorporate, such as rewriting the elf table fixup code in C.

The basic idea of this patch is to replace the -fPIC compile-time option with the -pie link-time option. This removes the GOT but adds the .rel.dyn and .dynsym tables, which together allow fixing up code more completely than with -fPIC and the GOT; for instance, all pointers inside structures are fixed up with -pie, whereas they are not with GOT.

Note that references to linker-file-generated symbols were also made relative to _start rather than absolute. This is not needed as such, but it will be useful when optimizing the relocation tables. Actually I should have separated this from the ELF relocation support per se.

The edminiv2.h config file is there for reference only; this is the one I used for tests. Latest numbers are:

With GOT relocs:

text data bss dec hex filename .bin size
141376 4388 16640 162404 27a64 ./u-boot 145764

With ELF relocs:

text data bss dec hex filename .bin size
149677 3727 16636 170040 29838 ./u-boot 153408

The size difference is essentially due to .rel.dyn not being optimal. As discussed, an added build step should allow reducing it by half and making ELF sizes roughly similar to GOT ones.

Tests and comments not only welcome but also heartily called for.

Amicalement,
Albert.

---
 arch/arm/config.mk                |    3 +-
 arch/arm/cpu/arm926ejs/start.S    |  172 +++++++++++++++++++++----------------
 arch/arm/cpu/arm926ejs/u-boot.lds |    9 ++
 arch/arm/include/asm/u-boot-arm.h |   14 ++--
 arch/arm/lib/board.c              |    8 +-
 board/LaCie/edminiv2/config.mk    |    5 +-
 include/configs/edminiv2.h        |    1 +
 7 files changed, 123 insertions(+), 89 deletions(-)
arch/arm/config.mk +2 -1
index 6923f6d..e9e02da 100644
@@ -35,7 +35,7 @@ endif
 
 ifndef CONFIG_SYS_ARM_WITHOUT_RELOC
 # needed for relocation
-PLATFORM_RELFLAGS += -fPIC
+#PLATFORM_RELFLAGS += -fPIC
 endif
 
 ifdef CONFIG_SYS_ARM_WITHOUT_RELOC
@@ -72,3 +72,4 @@ PLATFORM_LIBS += $(OBJTREE)/arch/arm/lib/eabi_compat.o
 endif
 endif
 LDSCRIPT := $(SRCTREE)/$(CPUDIR)/u-boot.lds
+PLATFORM_LDFLAGS += -pie
\ No newline at end of file
arch/arm/cpu/arm926ejs/start.S +96 -76

267 lines not on this page · raw message

arch/arm/cpu/arm926ejs/u-boot.lds +9 -0
index 02eb8ca..f07a54a 100644
@@ -51,6 +51,14 @@ SECTIONS
 		*(.data.rel.ro)
 	}
 
+	. = ALIGN(4);
+	__rel_dyn_start = .;
+	.rel.dyn : { *(.rel.dyn) }
+	__rel_dyn_end = .;
+
+	__dynsym_start = .;
+	.dynsym : { *(.dynsym) }
+
 	__got_start = .;
 	. = ALIGN(4);
 	.got : { *(.got) }
@@ -65,4 +73,5 @@ SECTIONS
 	__bss_start = .;
 	.bss (NOLOAD) : { *(.bss) . = ALIGN(4); }
 	_end = .;
+	
 }
arch/arm/include/asm/u-boot-arm.h +7 -7
index faf800a..4ac4f61 100644
@@ -30,18 +30,18 @@
 #define _U_BOOT_ARM_H_	1
 
 /* for the following variables, see start.S */
-extern ulong _bss_start;	/* code + data end == BSS start */
-extern ulong _bss_end;		/* BSS end */
+extern ulong _bss_start_ofs;	/* BSS start relative to _start */
+extern ulong _bss_end_ofs;		/* BSS end relative to _start */
 extern ulong IRQ_STACK_START;	/* top of IRQ stack */
 extern ulong FIQ_STACK_START;	/* top of FIQ stack */
 #if defined(CONFIG_SYS_ARM_WITHOUT_RELOC)
-extern ulong _armboot_start;	/* code start */
+extern ulong _armboot_start_ofs;	/* code start */
 #else
 extern ulong _TEXT_BASE;	/* code start */
-extern ulong _datarel_start;
-extern ulong _datarelrolocal_start;
-extern ulong _datarellocal_start;
-extern ulong _datarelro_start;
+extern ulong _datarel_start_ofs;
+extern ulong _datarelrolocal_start_ofs;
+extern ulong _datarellocal_start_ofs;
+extern ulong _datarelro_start_ofs;
 extern ulong IRQ_STACK_START_IN;	/* 8 bytes in IRQ stack */
 #endif
 
arch/arm/lib/board.c +5 -3
index 5f2dfd0..e411d93 100644
@@ -147,7 +147,7 @@ static int display_banner (void)
 #else
 	       _armboot_start,
 #endif
-	       _bss_start, _bss_end);
+	       _bss_start_ofs+_TEXT_BASE, _bss_end_ofs+_TEXT_BASE);
 #ifdef CONFIG_MODEM_SUPPORT
 	debug ("Modem Support enabled\n");
 #endif
@@ -517,7 +517,7 @@ void board_init_f (ulong bootflag)
 
 	memset ((void*)gd, 0, sizeof (gd_t));
 
-	gd->mon_len = _bss_end - _TEXT_BASE;
+	gd->mon_len = _bss_end_ofs;
 
 	for (init_fnc_ptr = init_sequence; *init_fnc_ptr; ++init_fnc_ptr) {
 		if ((*init_fnc_ptr)() != 0) {
@@ -679,6 +679,7 @@ static char *failed = "*** failed ***\n";
  *
  ************************************************************************
  */
+
 void board_init_r (gd_t *id, ulong dest_addr)
 {
 	char *s;
@@ -702,7 +703,7 @@ void board_init_r (gd_t *id, ulong dest_addr)
 
 	gd->flags |= GD_FLG_RELOC;	/* tell others: relocation done */
 
-	monitor_flash_len = _bss_start - _TEXT_BASE;
+	monitor_flash_len = _bss_start_ofs;
 	debug ("monitor flash len: %08lX\n", monitor_flash_len);
 	board_init();	/* Setup chipselects */
 
@@ -914,6 +915,7 @@ extern void davinci_eth_set_mac_addr (const u_int8_t *addr);
 
 	/* NOTREACHED - no way out of command loop except booting */
 }
+
 #endif /* defined(CONFIG_SYS_ARM_WITHOUT_RELOC) */
 
 void hang (void)
board/LaCie/edminiv2/config.mk +3 -2
index bb444b5..f8bdc3a 100644
@@ -24,5 +24,6 @@
 # MA 02110-1301 USA
 #
 
-# with relocation TEXT_BASE now *must* be in FLASH
-TEXT_BASE = 0xfff90000
+# with relocation TEXT_BASE can be anything, and making it 0
+# makes relative and absolute relocation fixups interchangeable.
+TEXT_BASE = 0
include/configs/edminiv2.h +1 -0
index e6537fc..8bcdfcc 100644
@@ -224,6 +224,7 @@
 #define CONFIG_SYS_MAXARGS		16
 
 /* additions for new relocation code, must be added to all boards */
+#define CONFIG_RELOC_FIXUP_WORKS
 #undef CONFIG_SYS_ARM_WITHOUT_RELOC
 #define CONFIG_SYS_SDRAM_BASE		0
 #define CONFIG_SYS_INIT_SP_ADDR	\
Signature · 1 line
1.7.0.4
#1 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Afterthought: I have not explained how to test this patch.

If your board is based on arm926ejs and does not have its own u-boot.lds, then you can simply applly the patch and modify your board config file as I modified edminiv2.h, basically by adding the config option CONFIG_RELOC_FIXUP_WORKS which will remove all calls to manual fixup code.

If your board is arm926ejs but has its own start.S or u-boot.lds (or both) then you'll also have to apply them the changes I made to their arm926 counterparts.

Ditto if your board is ARM but not arm926.

You should then be able to build and run.

Remember: this patch only applies to boards which boot from NOR FLASH! You can test it on other types of boards (NAND-based, etc) for regression testing, but nothing more.

Amicalement,

Signature · 1 line
Albert.
#2 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

On Mon, Oct 4, 2010 at 4:09 PM, Albert ARIBAUD <[email protected]> wrote:
....

Quoted 4 lines

Remember: this patch only applies to boards which boot from NOR FLASH! You can test it on other types of boards (NAND-based, etc) for regression testing, but nothing more.

Dumb question, how is the case of a NAND SPL, or similar loader loading u-boot first to a low RAM address then u-boot relocating itself to top of RAM different than u-boot relocating itself from NOR to top of RAM?

Thanks,
John

#3 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Quoted 12 lines · John Rigby

On Mon, Oct 4, 2010 at 4:09 PM, Albert ARIBAUD <[email protected]> wrote:
....

Quoted 4 lines

Remember: this patch only applies to boards which boot from NOR FLASH! You can test it on other types of boards (NAND-based, etc) for regression testing, but nothing more.

Dumb question, how is the case of a NAND SPL, or similar loader loading u-boot first to a low RAM address then u-boot relocating itself to top of RAM different than u-boot relocating itself from NOR to top of RAM?

Can NAND SPL initialise and size memory before loading U-Boot into RAM? If so, could the relocation code be added to NAND SPL so only one copy operation is performed?

Regards,

Graeme

#4 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Dear Graeme Russ,

Quoted 2 lines · In message <[email protected]> you…

Can NAND SPL initialise and size memory before loading U-Boot into RAM?

It has to. You cannot load into and run from uninitialized RAM ;-)

Quoted 2 lines

If so, could the relocation code be added to NAND SPL so only one copy operation is performed?

I'm afraid it cannot, due to size limitations. The NAND loader often hast to fit into as little a 2 or 4 KiB...

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Language shapes the way we think, and determines what we  can  think
about."                                                 - B. L. Whorf
#5 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Quoted 6 lines · Wolfgang Denk

Dear Graeme Russ,

Quoted 2 lines · In message <[email protected]> you…

Can NAND SPL initialise and size memory before loading U-Boot into RAM?

Quoted 8 lines

It has to. You cannot load into and run from uninitialized RAM ;-)

Quoted 2 lines

If so, could the relocation code be added to NAND SPL so only one copy operation is performed?

I'm afraid it cannot, due to size limitations. The NAND loader often hast to fit into as little a 2 or 4 KiB...

For x86, the actual relocation calculations can be done in a probably a few dozen bytes of code. It contains:

- One offset calculation
- A single tight loop
- Two comparisons (probably not needed in the generic case as they are used to filter out x86 specific code outside .text)
- An offset addition

If the only constraint is space then it _may_ be possible in some scenarios (although I do acknowledge that previous trival changes have caused the size constaint to be violated)

Regards,

Graeme

#6 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Quoted 25 lines · Graeme Russ
Quoted 6 lines · Wolfgang Denk

Dear Graeme Russ,

Quoted 2 lines · In message <[email protected]> you…

Can NAND SPL initialise and size memory before loading U-Boot into RAM?

Quoted 8 lines

It has to. You cannot load into and run from uninitialized RAM ;-)

Quoted 2 lines

If so, could the relocation code be added to NAND SPL so only one copy operation is performed?

I'm afraid it cannot, due to size limitations. The NAND loader often hast to fit into as little a 2 or 4 KiB...

For x86, the actual relocation calculations can be done in a probably a few dozen bytes of code. It contains:

- One offset calculation
- A single tight loop
- Two comparisons (probably not needed in the generic case as they are used to filter out x86 specific code outside .text)
- An offset addition

Quoted 4 lines

If the only constraint is space then it _may_ be possible in some scenarios (although I do acknowledge that previous trival changes have caused the size constaint to be violated)

Another alternative is to load into upper memory and have the relocation code detect that U-Boot is already there and skip the copy operation

Regards,

Graeme

#7 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Le 05/10/2010 07:42, Graeme Russ a ?crit :

Quoted 26 lines · Graeme Russ
Quoted 25 lines · Wolfgang Denk
Quoted 6 lines

Dear Graeme Russ,

Quoted 2 lines · In message<[email protected]> you…

Can NAND SPL initialise and size memory before loading U-Boot into RAM?

Quoted 8 lines

It has to. You cannot load into and run from uninitialized RAM ;-)

Quoted 2 lines

If so, could the relocation code be added to NAND SPL so only one copy operation is performed?

I'm afraid it cannot, due to size limitations. The NAND loader often hast to fit into as little a 2 or 4 KiB...

For x86, the actual relocation calculations can be done in a probably a few dozen bytes of code. It contains:

- One offset calculation
- A single tight loop
- Two comparisons (probably not needed in the generic case as they are used to filter out x86 specific code outside .text)
- An offset addition

Quoted 7 lines
Quoted 4 lines

If the only constraint is space then it _may_ be possible in some scenarios (although I do acknowledge that previous trival changes have caused the size constaint to be violated)

Another alternative is to load into upper memory and have the relocation code detect that U-Boot is already there and skip the copy operation

The loader would have to know something about the way u-boot relocates itself, and this may change based on configuration.

For instance, on ARM, if either icache or dcache are configured, u-boot will reserve the upper 64 KB for TLB and thus relocate 64 KB lower than if neither icache nor dcache are configured. Ditto for VFD, LCD framebuffer, etc. Only after these allocations, and thus below them, is u-boot finally relocated.

An independent loader would thus have to figure all this out in order to know how exactly where u-boot expects to relocate, otherwise it may put u-boot at a location which would be almost, but not quite, entirely unlike the intended one -- and that's the worst possible choice, as we now hit the dreaded 'relocate over oneself' issue.

OTOH, the u-boot board.c may possibly be modified so that the the final location of the u-boot code only depend on its code size, not its configuration options. Something like, in descending order: u-boot code, data and bss; TLBs, VFDs, framebuffers, etc; malloc arena; and stack.

Quoted 3 lines

Regards,

Graeme

Amicalement,

Signature · 1 line
Albert.
#8 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

In reply to Albert ARIBAUD

Dear Albert ARIBAUD,

Quoted 4 lines · In message <[email protected]> you wrote:

Remember: this patch only applies to boards which boot from NOR FLASH! You can test it on other types of boards (NAND-based, etc) for regression testing, but nothing more.

Assuming the NAND loder does not load U-Boot to it's final location at the upper end of RAM, but - say - somewhere in lower memory, the standard relocation preocess will be running, so I think there should be no real difference between (such) NAND booting systems and NOR booting ones - or am I missing something?

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you use modules, you pay the price. Sane embedded solutions
running in "tight" environments don't use modules :-)
    -- Benjamin Herrenschmidt in <1258234866.2140.451.camel@pasglop>
#9 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Quoted 11 lines · Wolfgang Denk

Dear Albert ARIBAUD,

Quoted 3 lines · In message<[email protected]> you wrote:

Remember: this patch only applies to boards which boot from NOR FLASH! You can test it on other types of boards (NAND-based, etc) for regression testing, but nothing more.

Assuming the NAND loder does not load U-Boot to it's final location at the upper end of RAM, but - say - somewhere in lower memory, the standard relocation preocess will be running, so I think there should be no real difference between (such) NAND booting systems and NOR booting ones - or am I missing something?

FWIW I think you are right. If u-boot is linked for the address where the NAND loader put it, everything should work fine. It can size memory, move a copy of u-boot to the top of memory, and branch to the entry point that continues initialization.

Bill Campbell

Quoted 4 lines

Best regards,

Wolfgang Denk

#10 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

In reply to Wolfgang Denk

Le 05/10/2010 07:30, Wolfgang Denk a ?crit :

Quoted 8 lines

Dear Albert ARIBAUD,

Quoted 4 lines · In message<[email protected]> you wrote:

Remember: this patch only applies to boards which boot from NOR FLASH! You can test it on other types of boards (NAND-based, etc) for regression testing, but nothing more.

Quoted 5 lines

Assuming the NAND loder does not load U-Boot to it's final location at the upper end of RAM, but - say - somewhere in lower memory, the standard relocation preocess will be running, so I think there should be no real difference between (such) NAND booting systems and NOR booting ones - or am I missing something?

No, you're not; instead of "but [you can test] nothing more", I should have written "but don't expect much more" -- NAND testers may find it works because yes, relocation does not differ whether from FLASH or from RAM; however I did nothing to make sure NAND booting (and other similar methods) works, whereas I spent quite some time to make NOR boot work.

Quoted 3 lines

Best regards,

Wolfgang Denk

Amicalement,

Signature · 1 line
Albert.
#11 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

In reply to Albert Aribaud
Quoted 7 lines · Albert Aribaud

This patch is *not* a submission for master!

It is a proof of concept of ELF relocations for ARM, hastily done in a day's work time for people on the list to try and to comment. All comments are welcome, as several suggestions have been made today on the list that I did not have time to incorporate, such as rewriting the elf table fixup code in C.

Yes, this would be nice. I imagine it would look somewhat like the version for x86. It would be nice to have a generic function which will work for all arches.

[snip]

Quoted 9 lines

With GOT relocs:

text data bss dec hex filename .bin size
141376 4388 16640 162404 27a64 ./u-boot 145764

With ELF relocs:

text data bss dec hex filename .bin size
149677 3727 16636 170040 29838 ./u-boot 153408

Hmm, I'm a bit suprised by the text increase - Can you provide a more detailed breakdown of before and after sizes by section?

As I have mentioned before, x86 has an in-RAM increase of only 284 bytes (0.3 %) with an additional 22424 bytes in .rel.dyn

Regards,

Graeme

#12 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Le 05/10/2010 00:22, Graeme Russ a ?crit :

Quoted 20 lines · Albert Aribaud
Quoted 7 lines

This patch is *not* a submission for master!

It is a proof of concept of ELF relocations for ARM, hastily done in a day's work time for people on the list to try and to comment. All comments are welcome, as several suggestions have been made today on the list that I did not have time to incorporate, such as rewriting the elf table fixup code in C.

Yes, this would be nice. I imagine it would look somewhat like the version for x86. It would be nice to have a generic function which will work for all arches.

[snip]

Quoted 5 lines

With GOT relocs:

text data bss dec hex filename .bin size
141376 4388 16640 162404 27a64 ./u-boot 145764

Quoted 7 lines
Quoted 4 lines

With ELF relocs:

text data bss dec hex filename .bin size
149677 3727 16636 170040 29838 ./u-boot 153408

Hmm, I'm a bit suprised by the text increase - Can you provide a more detailed breakdown of before and after sizes by section?

The output from MAKEALL is curiously calculated... If I look at objdumps of the GOT and ELF binaries, I find that:

- the GOT .text section is 118960 bytes and the ELF .text section only 108112. This is due to the fact that GOT relocation requires additional instruction for GOT indirection whereas ELF relocations work by patching the code.

- the .rodata section is 22416 for GOT, 22698 for ELF, whereas the .data section is 2908 for GOT, 2627 for ELF. Some initialized data apparently moved from non-const ton const for some reason, but basically, initialized data remains constant.

- the .bss section remains constant too, 16640 for GOT vs. 16636 for ELF. I'm not going to track what causes the 4 byte difference. :)

Many sections are output in the ELF file which do not appear in the GOT file, such as .interp, .dynamic, .dynstr etc. They probably pollute MAKEALL's figures.

So actually the code (.text+.rodata+.data) is smaller for ELF than for GOT (which is normal as GOT causes adding indirection instructions whereas ELF does not alter the code size) but the .rel.dyn is way bigger than the .got (which is also normal as GOT does not relocate all that ELF does).

Quoted 2 lines

As I have mentioned before, x86 has an in-RAM increase of only 284 bytes (0.3 %) with an additional 22424 bytes in .rel.dyn

That's roughly consistent with the numbers I get: about 19 KB of .rel.dyn plus .dynsym, which we will be able to cut by half if we preprocess it.

Quoted 3 lines

Regards,

Graeme

Amicalement,

Signature · 1 line
Albert.
#13 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Quoted 6 lines · Albert ARIBAUD

Le 05/10/2010 00:22, Graeme Russ a ?crit :

Quoted 4 lines
Quoted 1 line · Albert Aribaud
Quoted 7 lines

The output from MAKEALL is curiously calculated... If I look at objdumps of the GOT and ELF binaries, I find that:

- the GOT .text section is 118960 bytes and the ELF .text section only 108112. This is due to the fact that GOT relocation requires additional instruction for GOT indirection whereas ELF relocations work by patching the code.

It would be interesting to compare against the basline non-relocatable version

Quoted 6 lines

- the .rodata section is 22416 for GOT, 22698 for ELF, whereas the .data section is 2908 for GOT, 2627 for ELF. Some initialized data apparently moved from non-const ton const for some reason, but basically, initialized data remains constant.

Quoted 6 lines

- the .bss section remains constant too, 16640 for GOT vs. 16636 for ELF. I'm not going to track what causes the 4 byte difference. :)

Many sections are output in the ELF file which do not appear in the GOT file, such as .interp, .dynamic, .dynstr etc. They probably pollute MAKEALL's figures.

I now discard a few sections:

	/DISCARD/ : { *(.dynstr*) }
	/DISCARD/ : { *(.dynamic*) }
	/DISCARD/ : { *(.plt*) }
	/DISCARD/ : { *(.interp*) }
	/DISCARD/ : { *(.gnu*) }

Not that it makes a huge difference - most of these are trivially small

Quoted 6 lines

So actually the code (.text+.rodata+.data) is smaller for ELF than for GOT (which is normal as GOT causes adding indirection instructions whereas ELF does not alter the code size) but the .rel.dyn is way bigger than the .got (which is also normal as GOT does not relocate all that ELF does).

Quoted 6 lines
Quoted 2 lines

As I have mentioned before, x86 has an in-RAM increase of only 284 bytes (0.3 %) with an additional 22424 bytes in .rel.dyn

That's roughly consistent with the numbers I get: about 19 KB of .rel.dyn plus .dynsym, which we will be able to cut by half if we preprocess it.

Which is not copied to RAM, so not as nasty as the .got related increase

I'm also looking at moving the low-level intialisation and relocation code into a seperate section (outside .text) so I even less to relocate to RAM

Then I could even compress the relocatable section, but that is just being silly ;)

Regards,

Graeme

#14 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Le 05/10/2010 01:21, Graeme Russ a ?crit :

Quoted 10 lines · Albert ARIBAUD
Quoted 9 lines

Le 05/10/2010 00:22, Graeme Russ a ?crit :

Quoted 4 lines
Quoted 1 line · Albert Aribaud

The output from MAKEALL is curiously calculated... If I look at objdumps of the GOT and ELF binaries, I find that:

Quoted 7 lines
Quoted 4 lines

- the GOT .text section is 118960 bytes and the ELF .text section only 108112. This is due to the fact that GOT relocation requires additional instruction for GOT indirection whereas ELF relocations work by patching the code.

It would be interesting to compare against the basline non-relocatable version

I #defined CONFIG_RELOC_FIXUP_WORKS and removed -pie from the ARM config.mk. This puts the edminiv2 code in the non-reloc build case, and produces identical .text and .data, and almost identical .rodata, as the ELF case.

Quoted 14 lines
Quoted 11 lines

- the .rodata section is 22416 for GOT, 22698 for ELF, whereas the .data section is 2908 for GOT, 2627 for ELF. Some initialized data apparently moved from non-const ton const for some reason, but basically, initialized data remains constant.

- the .bss section remains constant too, 16640 for GOT vs. 16636 for ELF. I'm not going to track what causes the 4 byte difference. :)

Many sections are output in the ELF file which do not appear in the GOT file, such as .interp, .dynamic, .dynstr etc. They probably pollute MAKEALL's figures.

I now discard a few sections:

Quoted 7 lines
	/DISCARD/ : { *(.dynstr*) }
	/DISCARD/ : { *(.dynamic*) }
	/DISCARD/ : { *(.plt*) }
	/DISCARD/ : { *(.interp*) }
	/DISCARD/ : { *(.gnu*) }

Not that it makes a huge difference - most of these are trivially small

Thanks. I'll add this to the .lds as a measure of clarity.

Quoted 4 lines
Quoted 2 lines

That's roughly consistent with the numbers I get: about 19 KB of .rel.dyn plus .dynsym, which we will be able to cut by half if we preprocess it.

Which is not copied to RAM, so not as nasty as the .got related increase

True also. Note that we could probably shrink the table to 1/4 of its current size by taking advantage from the fact that the few non-program-base-relative relocations it has can easily be converted to program-base-relative, and that two consecutive relocations are always less than 64 KB away from each other. Of course that moves away from using the ELF structures as-is, and requires additional build steps, but people with small FLASH devices may want it.

Quoted 2 lines

I'm also looking at moving the low-level intialisation and relocation code into a seperate section (outside .text) so I even less to relocate to RAM

As Wolfgang pointed out, there might be issues in that all the code that runs in FLASH should be truly PI, which might not be a piece of cake. ARM C code, for instance, tends to generate literals which need to be relocated if you don't run the code where it was linked for.

Quoted 2 lines

Then I could even compress the relocatable section, but that is just being silly ;)

:)

Quoted 3 lines

Regards,

Graeme

Amicalement,

Signature · 1 line
Albert.
#15 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Quoted 43 lines · Albert ARIBAUD

Le 05/10/2010 01:21, Graeme Russ a ?crit :

Quoted 7 lines · Albert ARIBAUD
Quoted 6 lines

Le 05/10/2010 00:22, Graeme Russ a ?crit :

Quoted 2 lines

On Tue, Oct 5, 2010 at 9:01 AM, Albert Aribaud<[email protected]>
wrote:

The output from MAKEALL is curiously calculated... If I look at objdumps of the GOT and ELF binaries, I find that:

Quoted 6 lines
Quoted 4 lines

- the GOT .text section is 118960 bytes and the ELF .text section only 108112. This is due to the fact that GOT relocation requires additional instruction for GOT indirection whereas ELF relocations work by patching the code.

It would be interesting to compare against the basline non-relocatable version

I #defined CONFIG_RELOC_FIXUP_WORKS and removed -pie from the ARM config.mk. This puts the edminiv2 code in the non-reloc build case, and produces identical .text and .data, and almost identical .rodata, as the ELF case.

Quoted 13 lines
Quoted 11 lines

- the .rodata section is 22416 for GOT, 22698 for ELF, whereas the .data section is 2908 for GOT, 2627 for ELF. Some initialized data apparently moved from non-const ton const for some reason, but basically, initialized data remains constant.

- the .bss section remains constant too, 16640 for GOT vs. 16636 for ELF. I'm not going to track what causes the 4 byte difference. :)

Many sections are output in the ELF file which do not appear in the GOT file, such as .interp, .dynamic, .dynstr etc. They probably pollute MAKEALL's figures.

I now discard a few sections:

Quoted 7 lines
	/DISCARD/ : { *(.dynstr*) }
	/DISCARD/ : { *(.dynamic*) }
	/DISCARD/ : { *(.plt*) }
	/DISCARD/ : { *(.interp*) }
	/DISCARD/ : { *(.gnu*) }

Not that it makes a huge difference - most of these are trivially small

Thanks. I'll add this to the .lds as a measure of clarity.

Quoted 2 lines
Quoted 2 lines

That's roughly consistent with the numbers I get: about 19 KB of .rel.dyn plus .dynsym, which we will be able to cut by half if we preprocess it.

Quoted 8 lines
Quoted 1 line

Which is not copied to RAM, so not as nasty as the .got related increase

True also. Note that we could probably shrink the table to 1/4 of its current size by taking advantage from the fact that the few non-program-base-relative relocations it has can easily be converted to program-base-relative, and that two consecutive relocations are always less than 64 KB away from each other. Of course that moves away from using the ELF structures as-is, and requires additional build steps, but people with small FLASH devices may want it.

Hi All,
This may be pushing it in the more general case. ARM has only a
few relocation types. Other CPU types have more types, and therefore still may need a type field. You can certainly get 1/2 in all cases, and more if you are willing to get a bit more complex in the preprocessing. That said, I think this is best left to later when all CPUs are in the relocatable state.

Quoted 6 lines
Quoted 2 lines

I'm also looking at moving the low-level intialisation and relocation code into a seperate section (outside .text) so I even less to relocate to RAM

As Wolfgang pointed out, there might be issues in that all the code that runs in FLASH should be truly PI, which might not be a piece of cake. ARM C code, for instance, tends to generate literals which need to be relocated if you don't run the code where it was linked for.

True, but the code WILL be running at the address it was linked for. It just won't be copied and relocated to the "new" address, as it would never be run again anyway. This goal is along the lines of the "two stage u-boot" that has been/is being considered, where all execute only once code can be concentrated into a segment that is not moved into ram.

Bill Campbell

Quoted 8 lines
Quoted 2 lines

Then I could even compress the relocatable section, but that is just being silly ;)

:)

Quoted 3 lines

Regards,

Graeme

Amicalement,

#16 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

In reply to Albert Aribaud
Quoted 8 lines · Albert Aribaud

This patch is *not* a submission for master!

It is a proof of concept of ELF relocations for ARM, hastily done in a day's work time for people on the list to try and to comment. All comments are welcome, as several suggestions have been made today on the list that I did not have time to incorporate, such as rewriting the elf table fixup code in C.

Quoted 6 lines

The basic idea of this patch is to replace the -fPIC compile-time option with the -pie link-time option. This removes the GOT but adds the .rel.dyn and .dynsym tables, which together allow fixing up code more completely than with -fPIC and the GOT; for instance, all pointers inside structures are fixed up with -pie, whereas they are not with GOT.

So does this make all of Heiko's ARM relocation patches redundant?

Regards,

Graeme

#17 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

Le 05/10/2010 01:23, Graeme Russ a ?crit :

Quoted 1 line

So does this make all of Heiko's ARM relocation patches redundant?

Yes, it does, I'm afraid.

Amicalement,

Signature · 1 line
Albert.
#18 lore raw

RFC PATCH 1/1 arm: arm926ejs: use ELF relocations

In reply to Albert Aribaud

Dear Albert Aribaud,

Quoted 1 line · In message <[email protected]> you wrote:

This patch is *not* a submission for master!

I'm trying this on arm1136 (i.MX31) at the moment. It seems the patch was not taken against latest mainline, but probably against a previous state in your local tree.

I get:

Configuring for qong board...
arch/arm/lib/libarm.a(board.o): In function `board_init_r':
/home/wd/git/u-boot/work/arch/arm/lib/board.c:913: undefined reference to `_bss_start_ofs'
arch/arm/lib/libarm.a(board.o): In function board_init_f': /home/wd/git/u-boot/work/arch/arm/lib/board.c:664: undefined reference to _bss_end_ofs'

Seems that entries for _bss_start_ofs and _bss_end_ofs are missing in my version of the linker script, and I don't see these in your patch either.

[There are aslo rejects in board/LaCie/edminiv2/config.mk and include/configs/edminiv2.h, probably d=ue to the same reason.]

Can you please provide an updated patch against mainline? Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Punishment becomes ineffective after a certain point. Men become  in-
sensitive.
	-- Eneg, "Patterns of Force", stardate 2534.7