Skip to contentSkip to conversation

Drivers: char: ip2: Makefile: replace the use of <module>-objs with <module>-y

PATCH In review Tracey Dent 2 participants 8 messages Oct 16, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/5 Drivers: char: ip2: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/ip2/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ip2/Makefile +1 -1
index bc397d9..7b78e0d 100644
@@ -4,5 +4,5 @@
 
 obj-$(CONFIG_COMPUTONE)         += ip2.o
 
-ip2-objs			:= ip2main.o
+ip2-y			:= ip2main.o
 
Signature · 1 line
1.7.3.1.104.gc752e
#1 lore raw

PATCH 2/5 Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/ipmi/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/Makefile +1 -1
index eb8a1a8..16a9364 100644
@@ -2,7 +2,7 @@
 # Makefile for the ipmi drivers.
 #
 
-ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
+ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
 
 obj-$(CONFIG_IPMI_HANDLER) += ipmi_msghandler.o
 obj-$(CONFIG_IPMI_DEVICE_INTERFACE) += ipmi_devintf.o
Signature · 1 line
1.7.3.1.104.gc752e
#2 lore raw

Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

Quoted 12 lines · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/ipmi/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/Makefile +0 -0
index eb8a1a8..16a9364 100644

drivers/char/ipmi/Makefile line 5

Quoted 5 lines
drivers/char/ipmi/Makefile +1 -1
@@ -2,7 +2,7 @@
 # Makefile for the ipmi drivers.
 #
 
-ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
+ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o

NACK (and all of these). This will try to build 4 modules instead of one. Read Documentation/kbuild/makefiles.txt

regards,

Signature · 1 line
js
#3 lore raw

Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

Quoted 16 lines · Jiri Slaby
Quoted 15 lines · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/ipmi/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/Makefile +0 -0
index eb8a1a8..16a9364 100644
@@ -2,7 +2,7 @@
 # Makefile for the ipmi drivers.
 #
 
Quoted 5 lines

drivers/char/ipmi/Makefile line 5

Quoted 2 lines
drivers/char/ipmi/Makefile +1 -1
-ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
+ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o

NACK (and all of these). This will try to build 4 modules instead of one. Read Documentation/kbuild/makefiles.txt

Please disregard my NACK, I misread the patch.

regards,

Signature · 1 line
js
#4 lore raw

Re: [PATCH 02/05] Drivers: char: impi: Makefile: replace the use of <module>-objs with <module>-y

Quoted 17 lines · Jiri Slaby
Quoted 16 lines · Jiri Slaby
Quoted 15 lines · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/ipmi/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/ipmi/Makefile +0 -0
index eb8a1a8..16a9364 100644
@@ -2,7 +2,7 @@
 # Makefile for the ipmi drivers.
 #
 
Quoted 8 lines
Quoted 5 lines

drivers/char/ipmi/Makefile line 5

Quoted 2 lines
drivers/char/ipmi/Makefile +1 -1
-ipmi_si-objs := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o
+ipmi_si-y := ipmi_si_intf.o ipmi_kcs_sm.o ipmi_smic_sm.o ipmi_bt_sm.o

NACK (and all of these). This will try to build 4 modules instead of one. Read Documentation/kbuild/makefiles.txt

Please disregard my NACK, I misread the patch.

Okay, no problem. So instead of getting your NACK does it get a ACK by you?

Quoted 4 lines

regards,
--
js

Thanks,

Tracey D

#5 lore raw

PATCH 3/5 Drivers: Char: mwave: Makefile: Makefile clean up

In reply to Tracey Dent

Changed <module>-objs to <module>-y in Makefile and use ccflags-y option.

---
 drivers/char/mwave/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/char/mwave/Makefile +2 -2
index 754c9e2..26b4fce 100644
@@ -6,10 +6,10 @@
 
 obj-$(CONFIG_MWAVE) += mwave.o
 
-mwave-objs := mwavedd.o smapi.o tp3780i.o 3780i.o
+mwave-y := mwavedd.o smapi.o tp3780i.o 3780i.o
 
 # To have the mwave driver disable other uarts if necessary
 # EXTRA_CFLAGS += -DMWAVE_FUTZ_WITH_OTHER_DEVICES
 
 # To compile in lots (~20 KiB) of run-time enablable printk()s for debugging:
-EXTRA_CFLAGS += -DMW_TRACE
+ccflags-y := -DMW_TRACE
Signature · 1 line
1.7.3.1.104.gc752e
#6 lore raw

PATCH 4/5 Drivers: char: pcmcia: ipwireless: Makefile: replace the use of <module>-objs with <module>-y

In reply to Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/pcmcia/ipwireless/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/pcmcia/ipwireless/Makefile +1 -1
index b71eb59..db80873 100644
@@ -6,5 +6,5 @@
 
 obj-$(CONFIG_IPWIRELESS) += ipwireless.o
 
-ipwireless-objs := hardware.o main.o network.o tty.o
+ipwireless-y := hardware.o main.o network.o tty.o
 
Signature · 1 line
1.7.3.1.104.gc752e
#7 lore raw

PATCH 5/5 Drivers: char: rio: Makefile: replace the use of <module>-objs with <module>-y

In reply to Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/char/rio/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/rio/Makefile +1 -1
index 2d1c5a7..1661875 100644
@@ -8,5 +8,5 @@
 
 obj-$(CONFIG_RIO) += rio.o
 
-rio-objs := rio_linux.o rioinit.o rioboot.o riocmd.o rioctrl.o riointr.o \
+rio-y := rio_linux.o rioinit.o rioboot.o riocmd.o rioctrl.o riointr.o \
             rioparam.o rioroute.o riotable.o riotty.o
Signature · 1 line
1.7.3.1.104.gc752e