sparc: prom: Use the return value from prom_nbputchar()
RFC 2/8 sparc: prom: Use the return value from prom_nbputchar()
As prom_nbputchar() now returns 1 when it succeeds, use it instead of decrementing len or incrementing buf - as this matches the behaviour of prom_console_write_buf() in console_64.c
Signed-off-by Julian Calaby <[email protected]>
--- arch/sparc/prom/console_32.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
arch/sparc/prom/console_32.c +2 -3
@@ -50,8 +50,7 @@ void prom_console_write_buf(const char *buf, int len)int n =prom_nbputchar (buf);if (n <0 )continue ; - len--; - buf++; + len -= n; + buf += n; } } -
David Miller
maintainerRe: [RFC 2/8] sparc: prom: Use the return value from
From: Julian Calaby <[email protected]>
Date: Sat, 04 Dec 2010 14:56:09 +1100
Quoted 5 lines
As
prom_nbputchar()now returns 1 when it succeeds, use it instead of decrementing len or incrementing buf - as this matches the behaviour ofprom_console_write_buf()inconsole_64.cSigned-off-by Julian Calaby <[email protected]>
Since we're not doing patch #5 this change no longer makes any sense.