Skip to content

RFC prom/console cleanups

Julian Calaby sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest8 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8sparc: prom: Sanitize return value from prom_nbputchar()arch/sparc/prom/console_32.c+4 -30 replies
2/8sparc: prom: Use the return value from prom_nbputchar()arch/sparc/prom/console_32.c+2 -31 reply
3/8sparc: prom: Use n instead of len to decrement bufarch/sparc/prom/console_64.c+1 -10 replies
4/8sparc: prom: Remove unused definition of prom_stdinarch/sparc/prom/console_64.c+1 -10 replies
5/8sparc: prom: Merge console_*.c into printf.carch/sparc/prom/Makefile arch/sparc/prom/console_32.c arch/sparc/prom/console_64.c +1 more+69 -1072 replies
6/8sparc: oplib: Remove prom_console_write_buf() definitionarch/sparc/include/asm/oplib_32.h arch/sparc/include/asm/oplib_64.h+0 -61 reply
7/8sparc: prom: Make prom_console_write_buf() staticarch/sparc/prom/printf.c+1 -11 reply
8/8sparc: prom: Update DaveM's email addressarch/sparc/prom/printf.c+1 -12 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/8] prom/console cleanups

Dave,

After having a good poke around in the patches you sent to address the PROM call regressions, I saw a few places where some files could be cleaned up and dropped.

These haven't even been compile tested as I currently lack the equipment - hence the RFC tags, however they're a few obvious changes and moving some code so they *should* be safe. ..... er scratch that. Test them, please?

Oh, and I hope this doesn't increase your workload any =)

Thanks,

Julian Calaby

Julian Calaby (8):
sparc: prom: Sanitize return value from prom_nbputchar()
sparc: prom: Use the return value from prom_nbputchar()
sparc: prom: Use n instead of len to decrement buf
sparc: prom: Remove unused definition of prom_stdin
sparc: prom: Merge console_*.c into printf.c
sparc: oplib: Remove prom_console_write_buf() definition
sparc: prom: Make prom_console_write_buf() static
sparc: prom: Update DaveM's email address

 arch/sparc/include/asm/oplib_32.h |    3 --
 arch/sparc/include/asm/oplib_64.h |    3 --
 arch/sparc/prom/Makefile          |    1 -
 arch/sparc/prom/console_32.c      |   56 ----------------------------
 arch/sparc/prom/console_64.c      |   48 ------------------------
 arch/sparc/prom/printf.c          |   73 +++++++++++++++++++++++++++++++++++--
 6 files changed, 70 insertions(+), 114 deletions(-)
 delete mode 100644 arch/sparc/prom/console_32.c
 delete mode 100644 arch/sparc/prom/console_64.c