Skip to contentSkip to conversation

Add Bluewater Systems Snapper 9260/9G20 module support

PATCH Superseded Ryan Mallon 5 participants 15 messages Jan 25, 2011 – Jan 27, 2011 I2C

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Ryan Mallon

author
#0 lore raw

v2 cover Add Bluewater Systems Snapper 9260/9G20 module support

Add support for Bluewater Systems Snapper9260/9G20 modules. The modules are based on the AT91SAM9260 and AT91SAM9G20 processors respectively and support NAND flash and Ethernet.

This patches apply against the rework101229 branch of
git://git.denx.de/u-boot-atmel.git.

Changes since v1:
- Updated for recent at91 changes
- Use CONFIG_AT91FAMILY in soft_i2c driver
- Fixed missing snapper9260.h config file
- Add config to boards.cfg not Makefile
- Removed config.mk (now in snapper9260.h)

Ryan Mallon (3):
Fix at91 includes in soft_i2c driver
Add support for Bluewater Systems Snapper 9260 and 9G20 modules Add Bluewater Systems Snapper 9260 and 9G20 modules to top-level
boards.cfg

 board/bluewater/snapper9260/Makefile      |   53 ++++++++
 board/bluewater/snapper9260/snapper9260.c |  169 +++++++++++++++++++++++++
 boards.cfg                                |    2 +
 drivers/i2c/soft_i2c.c                    |    4 +-
 include/configs/snapper9260.h             |  191 +++++++++++++++++++++++++++++
 5 files changed, 416 insertions(+), 3 deletions(-)
 create mode 100644 board/bluewater/snapper9260/Makefile
 create mode 100644 board/bluewater/snapper9260/snapper9260.c
 create mode 100644 include/configs/snapper9260.h
author
#1 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

Signed-off-by Ryan Mallon <[email protected]>
---
 drivers/i2c/soft_i2c.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
drivers/i2c/soft_i2c.c +1 -3
index 1a1809a..d3803a2 100644
@@ -30,9 +30,7 @@
 #include <ioports.h>
 #include <asm/io.h>
 #endif
-#if defined(CONFIG_AT91RM9200) || \
-	defined(CONFIG_AT91SAM9260) ||  defined(CONFIG_AT91SAM9261) || \
-	defined(CONFIG_AT91SAM9263)
+#if defined(CONFIG_AT91RM9200) || defined(CONFIG_AT91FAMILY)
 #include <asm/io.h>
 #include <asm/arch/hardware.h>
 #include <asm/arch/at91_pio.h>
Signature · 1 line
1.7.0.4
author
#2 lore raw

PATCH v2 2/3 Add support for Bluewater Systems Snapper 9260 and 9G20 modules

Signed-off-by Ryan Mallon <[email protected]>
---
 board/bluewater/snapper9260/Makefile      |   53 ++++++++
 board/bluewater/snapper9260/snapper9260.c |  169 +++++++++++++++++++++++++
 include/configs/snapper9260.h             |  191 +++++++++++++++++++++++++++++
 3 files changed, 413 insertions(+), 0 deletions(-)
 create mode 100644 board/bluewater/snapper9260/Makefile
 create mode 100644 board/bluewater/snapper9260/snapper9260.c
 create mode 100644 include/configs/snapper9260.h
board/bluewater/snapper9260/Makefile new file +53 -0
new file mode 100644
index 0000000..4fccdaa
@@ -0,0 +1,53 @@
+#
+# (C) Copyright 2003-2008
+# Wolfgang Denk, DENX Software Engineering, wd at denx.de.
+#
+# (C) Copyright 2011 Bluewater Systems
+# Ryan Mallon <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB	= $(obj)lib$(BOARD).o
+
+COBJS-y	+= snapper9260.o
+
+SRCS	:= $(SOBJS:.o=.S) $(COBJS-y:.o=.c)
+OBJS	:= $(addprefix $(obj),$(COBJS-y))
+SOBJS	:= $(addprefix $(obj),$(SOBJS))
+
+$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
+	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+
+clean:
+	rm -f $(SOBJS) $(OBJS)
+
+distclean:	clean
+	rm -f $(LIB) core *.bak $(obj).depend
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################
board/bluewater/snapper9260/snapper9260.c new file +169 -0

169 lines not on this page · raw message

include/configs/snapper9260.h new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
1.7.0.4
author
#3 lore raw

PATCH v2 3/3 Add Bluewater Systems Snapper 9260 and 9G20 modules to top-level boards.cfg

Signed-off-by Ryan Mallon <[email protected]>
---
 boards.cfg |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
boards.cfg +2 -0
index 9b15026..370ab02 100644
@@ -113,6 +113,8 @@ imx27lite                    arm         arm926ejs   imx27lite           logicpd
 magnesium                    arm         arm926ejs   imx27lite           logicpd        mx27
 omap5912osk                  arm         arm926ejs   -                   ti             omap
 edminiv2                     arm         arm926ejs   -                   LaCie          orion5x
+snapper9260                  arm         arm926ejs   -                   bluewater      at91        snapper9260:AT91SAM9260
+snapper9g20                  arm         arm926ejs   snapper9260         bluewater      at91        snapper9260:AT91SAM9G20
 ca9x4_ct_vxp                 arm         armv7       vexpress            armltd
 mx51evk                      arm         armv7       mx51evk             freescale      mx5
 vision2                      arm         armv7       vision2             ttcontrol      mx5
Signature · 1 line
1.7.0.4
#4 lore raw

PATCH v2 3/3 Add Bluewater Systems Snapper 9260 and 9G20 modules to top-level boards.cfg

Dear Ryan Mallon,

Quoted 5 lines · In message <b31f9ead63a567931f8dbf5170bbd34a4adb2612.1295995460.git.ryan@bluewa…
Signed-off-by Ryan Mallon <[email protected]>
---
 boards.cfg |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

This needs to be folded into previous patch.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As in certain cults it is possible to kill a process if you know  its
true name.                      -- Ken Thompson and Dennis M. Ritchie
#5 lore raw

PATCH v2 2/3 Add support for Bluewater Systems Snapper 9260 and 9G20 modules

In reply to Ryan Mallon

Dear Ryan Mallon,

Quoted 10 lines · In message <e3e679839f735fff180547840a3fe3cec2b1d535.1295995460.git.ryan@bluewa…
Signed-off-by Ryan Mallon <[email protected]>
---
 board/bluewater/snapper9260/Makefile      |   53 ++++++++
 board/bluewater/snapper9260/snapper9260.c |  169 +++++++++++++++++++++++++
 include/configs/snapper9260.h             |  191 +++++++++++++++++++++++++++++
 3 files changed, 413 insertions(+), 0 deletions(-)
 create mode 100644 board/bluewater/snapper9260/Makefile
 create mode 100644 board/bluewater/snapper9260/snapper9260.c
 create mode 100644 include/configs/snapper9260.h

Entry to MAINTAINERS and boards.cfg missing.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Ja, mach' nur einen Plan,    sei nur ein grosses Licht
und mach' dann noch 'nen zweiten Plan,    geh'n tun sie beide nicht."
                                     -- Bert Brecht, Dreigroschenoper
#6 lore raw

PATCH v2 2/3 Add support for Bluewater Systems Snapper 9260 and 9G20 modules

Dear Wolfgang Denk,

Quoted 14 lines

Dear Ryan Mallon,

Quoted 10 lines · In message<e3e679839f735fff180547840a3fe3cec2b1d535.1295995460.git.ryan@bluewat…
Signed-off-by Ryan Mallon<[email protected]>
---
  board/bluewater/snapper9260/Makefile      |   53 ++++++++
  board/bluewater/snapper9260/snapper9260.c |  169 +++++++++++++++++++++++++
  include/configs/snapper9260.h             |  191 +++++++++++++++++++++++++++++
  3 files changed, 413 insertions(+), 0 deletions(-)

create mode 100644 board/bluewater/snapper9260/Makefile create mode 100644 board/bluewater/snapper9260/snapper9260.c create mode 100644 include/configs/snapper9260.h

Quoted 1 line

Entry to MAINTAINERS and boards.cfg missing.

I am already engaged into this. There are minor coding issues involved, I will comment on them later.

Best Regards,
Reinhard

author
#7 lore raw

PATCH v2 2/3 Add support for Bluewater Systems Snapper 9260 and 9G20 modules

Quoted 19 lines · Reinhard Meyer

Dear Wolfgang Denk,

Quoted 18 lines

Dear Ryan Mallon,

In message<e3e679839f735fff180547840a3fe3cec2b1d535.1295995460.git.ryan@bluewatersys.com>

Quoted 12 lines · you
Signed-off-by Ryan Mallon<[email protected]>
---
  board/bluewater/snapper9260/Makefile      |   53 ++++++++
  board/bluewater/snapper9260/snapper9260.c |  169
+++++++++++++++++++++++++
  include/configs/snapper9260.h             |  191
+++++++++++++++++++++++++++++
  3 files changed, 413 insertions(+), 0 deletions(-)

create mode 100644 board/bluewater/snapper9260/Makefile create mode 100644 board/bluewater/snapper9260/snapper9260.c create mode 100644 include/configs/snapper9260.h

Quoted 4 lines
Quoted 1 line

Entry to MAINTAINERS and boards.cfg missing.

I am already engaged into this. There are minor coding issues involved, I will comment on them later.

Hi Reinhard,

Did you have any additional changes you want made for the Snapper9260/9G20 patches other than adding a MAINTAINERS entry and rolling the boards.cfg change into a single patch?

Thanks,
~Ryan

Signature · 7 lines
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934
#8 lore raw

PATCH v2 2/3 Add support for Bluewater Systems Snapper 9260 and 9G20 modules

Dear Ryan Mallon,

Quoted 3 lines

Did you have any additional changes you want made for the Snapper9260/9G20 patches other than adding a MAINTAINERS entry and rolling the boards.cfg change into a single patch?

Yes, the following things should be changed:

1. sort the boards.cfg entry to the right place.
See top of boards.cfg for the rules.
bluewater would be between atmel and emk ;)

2. #define SOMETHING 1. The "1" is depreciated if it serves no numeric meaning. Remove them in your board config.
(Make sure the white space goes as well)

3. SZ_* macros are depreciated. Use numeric values. (256 << 20) is preferred to denote 256MiB.

Sorry I had no time to look deeper into details, but it looked good otherwise.

Can you confirm that the code builds and runs after the changes? I can't verify the "runs" part...

Best Regards,
Reinhard

#9 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

In reply to Ryan Mallon

Dear Heiko & Reinhard,

Quoted 5 lines · In message <7bc3ea96fb41d5e41ac53281d77d3158bffd3b21.1295995460.git.ryan@bluewa…
Signed-off-by Ryan Mallon <[email protected]>
---
 drivers/i2c/soft_i2c.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

I think this one goes through as a bug fix, i. e. for the upcoming release.

The other patches of this series go into next.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Stupidity, like virtue, is its own reward.
#10 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

Hello Wolfgang and Reinhard,

Quoted 8 lines · Wolfgang Denk

Dear Heiko & Reinhard,

Quoted 4 lines · In message <7bc3ea96fb41d5e41ac53281d77d3158bffd3b21.1295995460.git.ryan@bluewa…
Signed-off-by Ryan Mallon <[email protected]>
---
 drivers/i2c/soft_i2c.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
Quoted 4 lines

I think this one goes through as a bug fix, i. e. for the upcoming release.

The other patches of this series go into next.

Ok. Reinhard? Do you pick up this patch? If so, I give my:

Acked-by Heiko Schocher <[email protected]>

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#11 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

Dear Heiko Schocher,

Quoted 11 lines

Hello Wolfgang and Reinhard,

Quoted 8 lines · Wolfgang Denk

Dear Heiko& Reinhard,

Quoted 4 lines · In message<7bc3ea96fb41d5e41ac53281d77d3158bffd3b21.1295995460.git.ryan@bluewat…
Signed-off-by Ryan Mallon<[email protected]>
---
  drivers/i2c/soft_i2c.c |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)
Quoted 8 lines
Quoted 4 lines

I think this one goes through as a bug fix, i. e. for the upcoming release.

The other patches of this series go into next.

Ok. Reinhard? Do you pick up this patch? If so, I give my:

Acked-by Heiko Schocher<[email protected]>

I was going to complain that it was not alphabetically sorted as I suggested to him, however I am now considering to remove the AT91RM9200 case altogether. That one has to be forced into AT91FAMILY.

Once corrected, I will pickup this patch then.

Best Regards,
Reinhard

#12 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

Hello Reinhard,

Quoted 21 lines · Reinhard Meyer

Dear Heiko Schocher,

Quoted 20 lines

Hello Wolfgang and Reinhard,

Quoted 10 lines · Wolfgang Denk

Dear Heiko& Reinhard,

In message<7bc3ea96fb41d5e41ac53281d77d3158bffd3b21.1295995460.git.ryan@bluewatersys.com>

Quoted 4 lines · Ryan Mallon
Signed-off-by Ryan Mallon<[email protected]>
---
  drivers/i2c/soft_i2c.c |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)
Quoted 4 lines

I think this one goes through as a bug fix, i. e. for the upcoming release.

The other patches of this series go into next.

Ok. Reinhard? Do you pick up this patch? If so, I give my:

Quoted 8 lines
Quoted 1 line
Acked-by Heiko Schocher<[email protected]>

I was going to complain that it was not alphabetically sorted as I suggested to him,
however I am now considering to remove the AT91RM9200 case altogether. That one has to be forced into AT91FAMILY.

Once corrected, I will pickup this patch then.

Ok, thanks!

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#13 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

Dear Ryan Mellon, dear Heiko Schocher:

Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 9 lines
Quoted 4 lines
Signed-off-by Ryan Mallon<[email protected]>
---
  drivers/i2c/soft_i2c.c |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)

I think this one goes through as a bug fix, i. e. for the upcoming release.

The other patches of this series go into next.

Ok. Reinhard? Do you pick up this patch? If so, I give my:

Quoted 8 lines
Quoted 8 lines
Quoted 1 line
Acked-by Heiko Schocher<[email protected]>

I was going to complain that it was not alphabetically sorted as I suggested to him,
however I am now considering to remove the AT91RM9200 case altogether. That one has to be forced into AT91FAMILY.

Once corrected, I will pickup this patch then.

I made up my mind, it should only test for AT91FAMILY.

AT91RM9200 is supposed to join AT91FAMILY anyway, so lets do this correctly right now.

#if defined(CONFIG_AT91FAMILY)

If its done that way, here is my

Acked-by Reinhard Meyer<[email protected]>

Ryan, can you please change it as such, and preferably post it as a separate patch (not with your new board)? So Heiko can pick it up and make it go as a bug fix to mainline faster than I could do it right now through the "atmel" tree.

Best Regards,
Reinhard

#14 lore raw

PATCH v2 1/3 Fix at91 includes in soft_i2c driver

Dear Reinhard Meyer,

Am 26.01.2011 um 09:18 schrieb Reinhard Meyer:

Quoted 20 lines

Dear Ryan Mellon, dear Heiko Schocher:

Quoted 19 lines
Quoted 19 lines
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Signed-off-by Ryan Mallon<[email protected]>
---
 drivers/i2c/soft_i2c.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
Quoted 8 lines
Quoted 4 lines

I think this one goes through as a bug fix, i. e. for the upcoming release.

The other patches of this series go into next.

Ok. Reinhard? Do you pick up this patch? If so, I give my:

Acked-by Heiko Schocher<[email protected]>

I was going to complain that it was not alphabetically sorted as I suggested to him,
however I am now considering to remove the AT91RM9200 case altogether. That one has to be forced into AT91FAMILY.

Quoted 5 lines
Quoted 1 line
Quoted 1 line

Once corrected, I will pickup this patch then.

I made up my mind, it should only test for AT91FAMILY.

AT91RM9200 is supposed to join AT91FAMILY anyway, so lets do this correctly right now.

that is the plan ...

Quoted 1 line

#if defined(CONFIG_AT91FAMILY)

regards

Andreas Bie?mann