Skip to contentSkip to conversation

Docs: Typo: coordinate{,s}

PATCH Arend van Spriel 2 participants 2 messages Jul 29, 2011 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 10 lines · Michael Witten
---
  include/linux/cordic.h |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/cordic.h +0 -0
index f932093..de741da 100644

include/linux/cordic.h struct cordic_iq { · line 42

Quoted 10 lines
include/linux/cordic.h +2 -2
@@ -35,8 +35,8 @@ struct cordic_iq {
   * @theta: angle in degrees for which i/q coordinate is to be calculated.
   * @coord: function output parameter holding the i/q coordinate.
   *
- * The function calculates the i/q coordinate for a given angle using
- * cordic algorithm. The coordinate consists of a real (i) and an
+ * The function calculates the i/q coordinates for a given angle using
+ * cordic algorithm. The coordinates consist of a real (i) and an
   * imaginary (q) part. The real part is essentially the cosine of the
   * angle and the imaginary part is the sine of the angle. The returned
   * values are scaled by 2^16 for precision. The range for theta is

Most patches in this series are fine by me. However, the function takes a single angle as input and returns a single two-dimensional coordinate as output. The coordinate itself is represented by the two axis i and q. So I tend to say changing coordinate to coordinates is not justified here. However, I not a native english speaker so I may be wrong here.

Gr. AvS

Signature · 2 lines
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
#3 lore raw
Quoted 20 lines · Arend van Spriel
Quoted 19 lines · Michael Witten

---
 include/linux/cordic.h |    4 ++--

 1 files changed, 2 insertions(+), 2 deletions(-)
include/linux/cordic.h +2 -2
index f932093..de741da 100644
@@ -35,8 +35,8 @@ struct cordic_iq {
   * @theta: angle in degrees for which i/q coordinate is to be calculated.
   * @coord: function output parameter holding the i/q coordinate.
   *
- * The function calculates the i/q coordinate for a given angle using
- * cordic algorithm. The coordinate consists of a real (i) and an
+ * The function calculates the i/q coordinates for a given angle using
+ * cordic algorithm. The coordinates consist of a real (i) and an
   * imaginary (q) part. The real part is essentially the cosine of the
Quoted 8 lines

include/linux/cordic.h struct cordic_iq { · line 42

Quoted 2 lines
include/linux/cordic.h +0 -0
   * angle and the imaginary part is the sine of the angle. The returned
   * values are scaled by 2^16 for precision. The range for theta is

Most patches in this series are fine by me. However, the function takes a single angle as input and returns a single two-dimensional coordinate as output. The coordinate itself is represented by the two axis i and q. So I tend to say changing coordinate to coordinates is not justified here. However, I not a native english speaker so I may be wrong here.

Sure.

Jiri, I'll send you a pull request later with the update(s).