add support for mcf5307 cpu

PATCH Superseded Angelo Dureghello 3 participants 5 messages Aug 11, 2011 – Oct 6, 2011 m68k architecture

Share & tools

Angelo Dureghello

author

2011-08-11 21:20 UTC #0 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files.

Signed-off-by Angelo Dureghello <[email protected]>

---
 arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
 arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
 arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
 arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
 arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
 arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
 arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
 arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
 arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
 arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
 10 files changed, 846 insertions(+), 0 deletions(-)
 create mode 100644 arch/m68k/cpu/mcf530x/Makefile
 create mode 100644 arch/m68k/cpu/mcf530x/config.mk
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.c
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.h
 create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c
 create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
 create mode 100644 arch/m68k/cpu/mcf530x/speed.c
 create mode 100644 arch/m68k/cpu/mcf530x/start.S
 create mode 100644 arch/m68k/include/asm/immap_5307.h
 create mode 100644 arch/m68k/include/asm/m5307.h

arch/m68k/cpu/mcf530x/Makefile new file +48 -0

new file mode 100644
index 0000000..3c5a1c2
@@ -0,0 +1,48 @@
+#
+# Copyright (c) 2011 Angelo Dureghello <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+# CFLAGS += -DET_DEBUG
+
+LIB	= $(obj)lib$(CPU).o
+
+START	= start.o
+COBJS	= interrupts.o cpu.o speed.o cpu_init.o
+
+SRCS	:= $(START:.o=.S) $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS	:= $(addprefix $(obj),$(SOBJS) $(COBJS))
+START	:= $(addprefix $(obj),$(START))
+
+all:	$(obj).depend $(START) $(LIB)
+
+$(LIB):	$(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
+
+#########################################################################
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#########################################################################

arch/m68k/cpu/mcf530x/config.mk new file +25 -0

new file mode 100644
index 0000000..2ba1644
@@ -0,0 +1,25 @@
+#
+# Copyright (c) 2011 Angelo Dureghello <[email protected]>
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+PLATFORM_RELFLAGS += -ffixed-d7 -msep-data
+
+PLATFORM_CPPFLAGS += -m5307 -fPIC

arch/m68k/cpu/mcf530x/cpu.c new file +48 -0

48 lines not on this page · raw message

arch/m68k/cpu/mcf530x/cpu.h new file +33 -0

new file mode 100644
index 0000000..c1227eb
@@ -0,0 +1,33 @@
+/*
+ *  cpu.h
+ *
+ *  Copyright (c) 2009 Freescale Semiconductor, Inc.
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef _CPU_H_
+#define _CPU_H_
+
+#include <command.h>
+
+/* Use this to create board specific reset functions */
+void board_reset(void) __attribute__((__weak__));
+
+#endif /* _CPU_H_ */

arch/m68k/cpu/mcf530x/cpu_init.c new file +164 -0

164 lines not on this page · raw message

arch/m68k/cpu/mcf530x/interrupts.c new file +42 -0

42 lines not on this page · raw message

arch/m68k/cpu/mcf530x/speed.c new file +36 -0

new file mode 100644
index 0000000..426bd9e
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2011 Angelo Dureghello <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/processor.h>
+#include <asm/immap.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+/* get_clocks() fills in gd->cpu_clock and gd->bus_clk */
+int get_clocks (void)
+{
+	gd->cpu_clk = CONFIG_SYS_CLK;
+	gd->bus_clk = gd->cpu_clk / 2;
+
+	return (0);
+}

arch/m68k/cpu/mcf530x/start.S new file +253 -0

253 lines not on this page · raw message

arch/m68k/include/asm/immap_5307.h new file +78 -0

78 lines not on this page · raw message

arch/m68k/include/asm/m5307.h new file +119 -0

119 lines not on this page · raw message

Signature · 1 line

1.7.2.3

Jin Zhengxiong-R64188

2011-08-22 03:49 UTC #1 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

Quoted 25 lines

-----Original Message-----
From: Angelo Dureghello [mailto:angelo70 at gmail.com]
Sent: Friday, August 12, 2011 5:20 AM
To: U-Boot at lists.denx.de
Cc: Jin Zhengxiong-R64188
Subject: [PATCH 1/1 V2] add support for mcf5307 cpu
Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files.
Signed-off-by Angelo Dureghello <[email protected]>
---
 arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
 arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
 arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
 arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
 arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
 arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
 arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
 arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
 arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
 arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
 10 files changed, 846 insertions(+), 0 deletions(-)
 create mode 100644 arch/m68k/cpu/mcf530x/Makefile
 create mode 100644 arch/m68k/cpu/mcf530x/config.mk

Quoted 8 lines

 create mode 100644 arch/m68k/cpu/mcf530x/cpu.c
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.h
 create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c
 create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
 create mode 100644 arch/m68k/cpu/mcf530x/speed.c
 create mode 100644 arch/m68k/cpu/mcf530x/start.S
 create mode 100644 arch/m68k/include/asm/immap_5307.h
 create mode 100644 arch/m68k/include/asm/m5307.h

[Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 boards
except the cpu_init.c file.

Thanks.

Jason

angelo

author

2011-08-22 08:07 UTC #2 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

Quoted 40 lines · On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote:

Quoted 23 lines
-----Original Message-----
From: Angelo Dureghello [mailto:angelo70 at gmail.com]
Sent: Friday, August 12, 2011 5:20 AM
To: U-Boot at lists.denx.de
Cc: Jin Zhengxiong-R64188
Subject: [PATCH 1/1 V2] add support for mcf5307 cpu
Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files.
Signed-off-by Angelo Dureghello<[email protected]>
---
  arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
  arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
  arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
  arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
  arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
  arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
  arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
  arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
  arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
  arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
  10 files changed, 846 insertions(+), 0 deletions(-)
Quoted 11 lines
create mode 100644 arch/m68k/cpu/mcf530x/Makefile create mode 100644 arch/m68k/cpu/mcf530x/config.mk create mode 100644 arch/m68k/cpu/mcf530x/cpu.c create mode 100644 arch/m68k/cpu/mcf530x/cpu.h create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c create mode 100644 arch/m68k/cpu/mcf530x/speed.c create mode 100644 arch/m68k/cpu/mcf530x/start.S create mode 100644 arch/m68k/include/asm/immap_5307.h create mode 100644 arch/m68k/include/asm/m5307.h
[Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 boards
except the cpu_init.c file.

Quoted 5 lines

Thanks.
Jason

Hi Jason,

thanks for the feedbacks,
sure i can review the patch as you suggest. Will repost the patch asap, in some days.

Regards,
angelo

<http://www.sysam.it>

Angelo Dureghello

author

2011-08-23 20:05 UTC #3 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

In reply to Jin Zhengxiong-R64188

Hello Jason and all,
i started to work to rewrite the patch.

Starting from mcf532x/cpu.c, i am not sure this is the right place to add MCF5307.

1) On "checkcpu", mcf5307 don't have ccm->cir where to read mask/ver.
2) About "do_reset", here also mcf5307 don't have MMAP_RCM, memory map and reset procedure are different.
3) In general, as memory map, mcf5307 is much more similar to some mcf52x2 cpu. This is the reason why i thought to treat it as a separate family. Looking here:
http://www.freescale.com/webapp/sps/site/taxonomy.jsp?code=68KCFV3
seems Freescale also treat it as the only cpu of the MCF530X family.

I can still go ahead, but cpu.c should have a great #ifdef CONFIG_MCF5307 to handle separately this cpu. How do you think i should proceed ?

regards
angelo

Quoted 44 lines · On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote:

Quoted 25 lines
-----Original Message-----
From: Angelo Dureghello [mailto:angelo70 at gmail.com]
Sent: Friday, August 12, 2011 5:20 AM
To: U-Boot at lists.denx.de
Cc: Jin Zhengxiong-R64188
Subject: [PATCH 1/1 V2] add support for mcf5307 cpu
Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files.
Signed-off-by Angelo Dureghello <[email protected]>
---
 arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
 arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
 arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
 arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
 arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
 arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
 arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
 arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
 arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
 arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
 10 files changed, 846 insertions(+), 0 deletions(-)
 create mode 100644 arch/m68k/cpu/mcf530x/Makefile
 create mode 100644 arch/m68k/cpu/mcf530x/config.mk
Quoted 8 lines
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.c
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.h
 create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c
 create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
 create mode 100644 arch/m68k/cpu/mcf530x/speed.c
 create mode 100644 arch/m68k/cpu/mcf530x/start.S
 create mode 100644 arch/m68k/include/asm/immap_5307.h
 create mode 100644 arch/m68k/include/asm/m5307.h
[Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 boards
except the cpu_init.c file.
Thanks.
Jason

Wolfgang Denk

2011-10-06 22:00 UTC #4 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

In reply to Angelo Dureghello

Dear Angelo Dureghello,

Quoted 18 lines · In message <[email protected]> you wrote:

Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files.

Signed-off-by Angelo Dureghello <[email protected]>

---
 arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
 arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
 arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
 arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
 arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
 arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
 arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
 arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
 arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
 arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
 10 files changed, 846 insertions(+), 0 deletions(-)
 create mode 100644 arch/m68k/cpu/mcf530x/Makefile
 create mode 100644 arch/m68k/cpu/mcf530x/config.mk

Quoted 8 lines

 create mode 100644 arch/m68k/cpu/mcf530x/cpu.c
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.h
 create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c
 create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
 create mode 100644 arch/m68k/cpu/mcf530x/speed.c
 create mode 100644 arch/m68k/cpu/mcf530x/start.S
 create mode 100644 arch/m68k/include/asm/immap_5307.h
 create mode 100644 arch/m68k/include/asm/m5307.h

CamelCase identifiers are not allowed.

Also, checkpatch says:

total: 34 errors, 31 warnings, 846 lines checked

Please clean up and resubmit. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Too much of anything, even love, isn't necessarily a good thing.
	-- Kirk, "The Trouble with Tribbles", stardate 4525.6