add support for mcf5307 cpu

PATCH Superseded angelo 2 participants 2 messages Sep 2, 2011 – Sep 5, 2011

lore

Share & tools

lore

angelo

author

2011-09-02 11:41 UTC #0 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

Hi Jason and all,

i am really interested to bring mcf5307 inside u-boot. But still waiting for your feedback/help on my comments below.

Let me know your comments.

Many thanks,

Regards,
angelo

Quoted 18 lines

Hello Jason and all,
i started to work to rewrite the patch.
Starting from mcf532x/cpu.c, i am not sure this is the right place to add MCF5307.
1) On "checkcpu", mcf5307 don't have ccm->cir where to read mask/ver.
2) About "do_reset", here also mcf5307 don't have MMAP_RCM, memory map and reset \
procedure are different. 3) In general, as memory map, mcf5307 is much more similar \
to some mcf52x2 cpu. This is the reason why i thought to treat it as a separate \
family. Looking here:
http://www.freescale.com/webapp/sps/site/taxonomy.jsp?code=68KCFV3
seems Freescale also treat it as the only cpu of the MCF530X family.
I can still go ahead, but cpu.c should have a great #ifdef CONFIG_MCF5307 to handle \
separately this cpu. How do you think i should proceed ?
regards
angelo

Quoted 43 lines · On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote:

Quoted 25 lines
-----Original Message-----
From: Angelo Dureghello [mailto:angelo70 at gmail.com]
Sent: Friday, August 12, 2011 5:20 AM
To: U-Boot at lists.denx.de
Cc: Jin Zhengxiong-R64188
Subject: [PATCH 1/1 V2] add support for mcf5307 cpu
Add cpu related files and memory map includes. Apply the related minor changes to general coldfire architecture include files.
Signed-off-by Angelo Dureghello<[email protected]>
---
 arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
 arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
 arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
 arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
 arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
 arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
 arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
 arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
 arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
 arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
 10 files changed, 846 insertions(+), 0 deletions(-)
 create mode 100644 arch/m68k/cpu/mcf530x/Makefile
 create mode 100644 arch/m68k/cpu/mcf530x/config.mk
Quoted 8 lines
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.c
 create mode 100644 arch/m68k/cpu/mcf530x/cpu.h
 create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c
 create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
 create mode 100644 arch/m68k/cpu/mcf530x/speed.c
 create mode 100644 arch/m68k/cpu/mcf530x/start.S
 create mode 100644 arch/m68k/include/asm/immap_5307.h
 create mode 100644 arch/m68k/include/asm/m5307.h
[Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such \
as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 \
boards except the cpu_init.c file.
Thanks.
Jason

Jin Zhengxiong-R64188

2011-09-05 09:02 UTC #1 lore raw

PATCH v2 1/1 add support for mcf5307 cpu

Quoted 7 lines

-----Original Message-----
From: angelo [mailto:angelo70 at gmail.com]
Sent: Friday, September 02, 2011 7:41 PM
To: Jin Zhengxiong-R64188
Cc: U-Boot at lists.denx.de
Subject: [U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu

Quoted 9 lines

Hi Jason and all,
i am really interested to bring mcf5307 inside u-boot. But still waiting for your feedback/help on my comments below.
Let me know your comments.
Many thanks,

Hi, angelo,

Could you please try as seperate MCF530X family but send out the complete patchset? You previous patch seems only include the new files. Thanks.

Regards,
Jason

Quoted 70 lines

Regards,
angelo
Quoted 4 lines
Hello Jason and all,
i started to work to rewrite the patch.
Starting from mcf532x/cpu.c, i am not sure this is the right place to add
MCF5307.
Quoted 11 lines
1) On "checkcpu", mcf5307 don't have ccm->cir where to read mask/ver.
2) About "do_reset", here also mcf5307 don't have MMAP_RCM, memory
map and reset \ procedure are different. 3) In general, as memory map, mcf5307 is much more similar \ to some mcf52x2 cpu. This is the reason why i thought to treat it as a separate \ family. Looking here:
http://www.freescale.com/webapp/sps/site/taxonomy.jsp?code=68KCFV3
seems Freescale also treat it as the only cpu of the MCF530X family.
I can still go ahead, but cpu.c should have a great #ifdef
CONFIG_MCF5307 to handle \ separately this cpu. How do you think i should
proceed ?
Quoted 3 lines
regards
angelo
Quoted 17 lines · On 22/08/2011 05:49, Jin Zhengxiong-R64188 wrote:
Quoted 2 lines
-----Original Message-----
From: Angelo Dureghello [mailto:angelo70 at gmail.com] > Sent:
Friday, August 12, 2011 5:20 AM > To: U-Boot at lists.denx.de > Cc:
Jin Zhengxiong-R64188 > Subject: [PATCH 1/1 V2] add support for mcf5307 cpu > > Add cpu related files and memory map includes. Apply the related > minor changes to general coldfire architecture include files.
Quoted 10 lines
Signed-off-by Angelo Dureghello<[email protected]> > ---
 arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
 arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
 arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
 arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
 arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
 arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
 arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
 arch/m68k/cpu/mcf530x/start.S      |  253
++++++++++++++++++++++++++++++++++++
Quoted 12 lines
Quoted 3 lines
 arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
 arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
 10 files changed, 846 insertions(+), 0 deletions(-)  >  create
mode 100644 arch/m68k/cpu/mcf530x/Makefile > create mode 100644 arch/m68k/cpu/mcf530x/config.mk > create mode 100644
arch/m68k/cpu/mcf530x/cpu.c  >  create mode 100644
arch/m68k/cpu/mcf530x/cpu.h  >  create mode 100644
arch/m68k/cpu/mcf530x/cpu_init.c > create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
Quoted 1 line
 create mode 100644 arch/m68k/cpu/mcf530x/speed.c  >  create mode
100644 arch/m68k/cpu/mcf530x/start.S > create mode 100644 arch/m68k/include/asm/immap_5307.h
Quoted 7 lines
Quoted 1 line
 create mode 100644 arch/m68k/include/asm/m5307.h
[Jin Zhengxiong-R64188] Could you please try to merge the 5307 cpu to
mcf532x as we already have two ColdFire V3 boards here(We can try to rename the mcf532x to such \ as mcf53xx later for less confuse). You can keep the immap_5307.h and m5307.h for the 5307 cpu. All the other files are similar with the files for the two V3 \ boards except the
cpu_init.c file.
Quoted 4 lines
Thanks.
Jason