Skip to contentSkip to conversation

Disable functionality that doesn't work on MINGW32

PATCH In review Mario Limonciello 2 participants 2 messages Sep 21, 2011

lore
Share & tools
lore
#0 lore raw

cover Disable functionality that doesn't work on MINGW32

The following two patches are for disabling some specifics that will not work on MINGW32.

Vladimir explicitly expressed disinterest in going the route of #undef GRUB_UTIL, but it seems to be the most appropriate method in the first patch to me because MINGW32 does not support ttys and won't ever.

The second patch just matches other code, since there is no grub_util_get_fd_sectors defined on MINGW32. This will at least get the file compiling with potentially broken functionality, which I see as an improvement over not compiling and no functionality.

Signature · 3 lines
*Mario Limonciello*
Linux Engineer
*Dell*| OS Engineering
#1 lore raw
Quoted 7 lines · Mario Limonciello

The following two patches are for disabling some specifics that will not work on MINGW32.

Vladimir explicitly expressed disinterest in going the route of #undef GRUB_UTIL, but it seems to be the most appropriate method in the first patch to me because MINGW32 does not support ttys and won't ever.

GRUB_UTIL means that we run under an OS and use it. While Windows is a low-quality one, it's still one, so GRUB_UTIL must be defined. Correct way to dial with this issue is to add a windows equivalent of this code (requesting password from user).

Quoted 5 lines

The second patch just matches other code, since there is no grub_util_get_fd_sectors defined on MINGW32. This will at least get the file compiling with potentially broken functionality, which I see as an improvement over not compiling and no functionality.

Signature · 2 lines
Regards
Vladimir 'φ-coder/phcoder' Serbinenko