Disable functionality that doesn't work on MINGW32
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | Undefine GRUB_UTIL in grub-core/lib/crypto.c for MINGW32 as termios is not supported.ChangeLog ChangeLog 2011-09-21 21:00:59 +0000 lib/ +1 more | +16 | 1 reply | |
| 2/2 | Disable unsupported grub_util_get_fd_sectors in geli on MINGW32ChangeLog 2011-09-21 21:18:21 +0000 disk/ | +4 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] Disable functionality that doesn't work on MINGW32
The following two patches are for disabling some specifics that will not work on MINGW32.
Vladimir explicitly expressed disinterest in going the route of #undef GRUB_UTIL, but it seems to be the most appropriate method in the first patch to me because MINGW32 does not support ttys and won't ever.
The second patch just matches other code, since there is no grub_util_get_fd_sectors defined on MINGW32. This will at least get the file compiling with potentially broken functionality, which I see as an improvement over not compiling and no functionality.
Signature · 3 lines
*Mario Limonciello* Linux Engineer *Dell*| OS Engineering