Skip to contentSkip to conversation

QA check with cppcheck

PATCH In review Thomas Jarosch 1 participant 1 message Oct 3, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover QA check with cppcheck

Hi there,

I've given iproute2 a good run with the free
cppcheck static code analysis tool.
(http://cppcheck.sourceforge.net/)

Following are eleven patches correcting minor
resource leaks and two real bugs.

Cheers,
Thomas

Thomas Jarosch (11):
Fix pipe I/O stream descriptor leak in init_service_resolver() Fix file descriptor leak on error in rtnl_hash_initialize() Fix wrong comparison in cmp_print_eopt()
Fix wrong sanity check in choke_parse_opt()
Fix memory leak of lname variable in get_target_name() Add missing closedir() call in do_show()
Fix file descriptor leak on error in iproute_flush_cache() Fix file descriptor leak on error in read_viftable() Fix file descriptor leak on error in read_mroute_list() Fix file descriptor leak in do_tunnels_list()
Fix file descriptor leak on error in read_igmp()

 ip/ipmaddr.c   |    4 +++-
 ip/ipmroute.c  |    9 ++++++---
 ip/iproute.c   |    1 +
 ip/iptunnel.c  |    3 +++
 ip/iptuntap.c  |    1 +
 lib/rt_names.c |    2 ++
 misc/ss.c      |    1 +
 tc/em_cmp.c    |    2 +-
 tc/m_ipt.c     |    3 +++
 tc/q_choke.c   |    2 +-
 10 files changed, 22 insertions(+), 6 deletions(-)
Signature · 1 line
1.7.4.4