QA check with cppcheck
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest11 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | Fix pipe I/O stream descriptor leak in init_service_resolver()misc/ | +1 | 0 replies | |
| 2/11 | Fix file descriptor leak on error in rtnl_hash_initialize()lib/ | +2 | 0 replies | |
| 3/11 | Fix wrong comparison in cmp_print_eopt()tc/ | +1 | 0 replies | |
| 4/11 | Fix wrong sanity check in choke_parse_opt()tc/ | +1 | 0 replies | |
| 5/11 | Fix memory leak of lname variable in get_target_name()tc/ | +3 | 0 replies | |
| 6/11 | Add missing closedir() call in do_show()ip/ | +1 | 0 replies | |
| 7/11 | Fix file descriptor leak on error in iproute_flush_cache()ip/ | +1 | 0 replies | |
| 8/11 | Fix file descriptor leak on error in read_viftable()ip/ | +3 | 0 replies | |
| 9/11 | Fix file descriptor leak on error in read_mroute_list()ip/ | +3 | 0 replies | |
| 10/11 | Fix file descriptor leak in do_tunnels_list()ip/ | +3 | 0 replies | |
| 11/11 | Fix file descriptor leak on error in read_igmp()ip/ | +3 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [iproute2 PATCH 00/11] QA check with cppcheck
Hi there,
I've given iproute2 a good run with the free
cppcheck static code analysis tool.
(http://cppcheck.sourceforge.net/)
Following are eleven patches correcting minor
resource leaks and two real bugs.
Cheers,
Thomas
Thomas Jarosch (11):
Fix pipe I/O stream descriptor leak in init_service_resolver() Fix file descriptor leak on error in rtnl_hash_initialize() Fix wrong comparison in cmp_print_eopt()
Fix wrong sanity check in choke_parse_opt()
Fix memory leak of lname variable in get_target_name() Add missing closedir() call in do_show()
Fix file descriptor leak on error in iproute_flush_cache() Fix file descriptor leak on error in read_viftable() Fix file descriptor leak on error in read_mroute_list() Fix file descriptor leak in do_tunnels_list()
Fix file descriptor leak on error in read_igmp()
ip/ipmaddr.c | 4 +++- ip/ipmroute.c | 9 ++++++--- ip/iproute.c | 1 + ip/iptunnel.c | 3 +++ ip/iptuntap.c | 1 + lib/rt_names.c | 2 ++ misc/ss.c | 1 + tc/em_cmp.c | 2 +- tc/m_ipt.c | 3 +++ tc/q_choke.c | 2 +- 10 files changed, 22 insertions(+), 6 deletions(-)
Signature · 1 line
1.7.4.4