Fix wrong sanity check in choke_parse_opt()

PATCH In review Thomas Jarosch 1 participant 1 message Oct 3, 2011

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Thomas Jarosch

author

2011-10-03 15:26 UTC #0 lore raw

PATCH 4/11 Fix wrong sanity check in choke_parse_opt()

Detected by cppcheck.

Signed-off-by Thomas Jarosch <[email protected]>

---
 tc/q_choke.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

tc/q_choke.c +1 -1

index 6e54cb7..04a864f 100644
@@ -122,7 +122,7 @@ static int choke_parse_opt(struct qdisc_util *qu, int argc, char **argv,
 		return -1;
 	}
 
-	if (opt.qth_min > opt.qth_min) {
+	if (opt.qth_min >= opt.qth_max) {
 		fprintf(stderr, "\"min\" is not smaller than \"max\"\n");
 		return -1;
 	}

Signature · 1 line

1.7.4.4