Skip to contentSkip to conversation

Fix file descriptor leak on error in read_igmp()

PATCH In review Thomas Jarosch 2 participants 2 messages Oct 3, 2011 – Oct 7, 2011

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Thomas Jarosch

author
#0 lore raw

PATCH 11/11 Fix file descriptor leak on error in read_igmp()

Detected by cppcheck.

Signed-off-by Thomas Jarosch <[email protected]>
---
 ip/ipmaddr.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
ip/ipmaddr.c +3 -1
index 5a52c85..3ae9478 100644
@@ -128,8 +128,10 @@ void read_igmp(struct ma_info **result_p)
 	if (!fp)
 		return;
 	memset(&m, 0, sizeof(m));
-	if (!fgets(buf, sizeof(buf), fp))
+	if (!fgets(buf, sizeof(buf), fp)) {
+		fclose(fp);
 		return;
+	}
 
 	m.addr.family = AF_INET;
 	m.addr.bitlen = 32;
Signature · 1 line
1.7.4.4