Skip to contentSkip to conversation

Staging: iio/light/tsl2563: fix compile warning

PATCH In review Dan Carpenter 2 participants 2 messages Oct 6, 2011

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 Staging: iio/light/tsl2563: fix compile warning

This fixes a compile warning:
drivers/staging/iio/light/tsl2563.c:696:2:
warning: initialization from incompatible pointer type [enabled by default]
drivers/staging/iio/light/tsl2563.c:696:2:
warning: (near initialization for ‘tsl2563_info.write_event_value’) [enabled by default]

The tsl2563_write_thresh() function returns zero on success and error codes on failure, so nothing is lost by making the return type int instead of ssize_t.

drivers/staging/iio/light/tsl2563.c +1 -1
index 8977f58..a5e08b3 100644
@@ -569,7 +569,7 @@ static int tsl2563_read_thresh(struct iio_dev *indio_dev,
 	return 0;
 }
 
-static ssize_t tsl2563_write_thresh(struct iio_dev *indio_dev,
+static int tsl2563_write_thresh(struct iio_dev *indio_dev,
 				  u64 event_code,
 				  int val)
 {
Acked-by on v1 2/2
#1 lore raw
Quoted 3 lines · Dan Carpenter

This fixes a compile warning:
drivers/staging/iio/light/tsl2563.c:696:2:
warning: initialization from incompatible pointer type [enabled by d=

efault]

Quoted 2 lines

drivers/staging/iio/light/tsl2563.c:696:2:

	warning: (near initialization for =E2=80=98tsl2563_info.write_event_=

value=E2=80=99) [enabled by default]

Quoted 4 lines

=20
The tsl2563_write_thresh() function returns zero on success and error codes on failure, so nothing is lost by making the return type int instead of ssize_t.

You are quite right. This is a silly cut and paste mistake on my part. Thanks.

Quoted 2 lines

=20

drivers/staging/ii=

Quoted 2 lines

=20

drivers/staging/ii= renamed from drivers/staging/iio/light/tsl2563.c +0 -0

o/light/tsl2563.c

drivers/staging/iio/light/tsl2563.c static int tsl2563_read_thresh(struct iio_dev *in=

Quoted 4 lines

index 8977f58..a5e08b3 100644

drivers/staging/iio/light/tsl2563.c +0 -0
@@ -569,7 +569,7 @@ static int tsl2563_read_thresh(struct iio_dev *in=

dio_dev,

Quoted 9 lines
drivers/staging/iio/light/tsl2563.c +0 -0
 	return 0;
 }

=20

drivers/staging/iio/light/tsl2563.c +1 -1
-static ssize_t tsl2563_write_thresh(struct iio_dev *indio_dev,
+static int tsl2563_write_thresh(struct iio_dev *indio_dev,
 				  u64 event_code,
 				  int val)
 {

=20