ALSA: firewire: Neaten cmp_error function
A message that is not in the archive (sent off-list or not yet received): 1319086869.28078.6.camel@Joe-Laptop
Review
Quoted 5 lines · Joe Perches
Use an actual struct
va_formatinstead of casting
an array of pointers.(quoted diff) +0
-2- dev_err(&c->resources.unit->device, "%cPCR%u: %pV", - 'i', c->pcr_index, &(struct va_format){ fmt, &va });
There is no cast. This compound literal _is_ an actual struct va_format.
Quoted 1 line
Move a constant char argument to the format string.
Good catch, but this module is going to be extended to handle oPCRs, too.
Regards,
Clemens