Skip to contentSkip to conversation

ALSA: firewire: Neaten cmp_error function

PATCH Clemens Ladisch 1 participant 1 message Oct 20, 2011 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Review

Quoted 5 lines · Joe Perches

Use an actual struct va_format instead of casting
an array of pointers.

(quoted diff) +0 -2
-	dev_err(&c->resources.unit->device, "%cPCR%u: %pV",
-		'i', c->pcr_index, &(struct va_format){ fmt, &va });

There is no cast. This compound literal _is_ an actual struct va_format.

Quoted 1 line

Move a constant char argument to the format string.

Good catch, but this module is going to be extended to handle oPCRs, too.

Regards,
Clemens