mtd: nand: Include IMX6 in the list of supported SoCs
Fabio Estevam
reviewerPATCH v2 1/3 mtd: nand: Include IMX6 in the list of supported SoCs
From: Fabio Estevam <[email protected]>
Include IMX6 in the list of supported SoCs.
---
Changes since v1:
- No changes
drivers/mtd/nand/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/Kconfig +1 -1
@@ -464,7 +464,7 @@ config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) help - Enables NAND Flash support for IMX23 or IMX28. + Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCH module, it can do the hardware ECC. The GPMI supports several NAND flashs at the same time. The GPMI may conflicts with other
Signature · 1 line
1.7.1
Fabio Estevam
reviewerPATCH v2 2/3 mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA
From: Fabio Estevam <[email protected]>
MTD_NAND_GPMI_NAND driver depends on MXS_DMA to be selected, otherwise the following error happens for imx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
---
Changes since v1:
- Use 'depends' rather than 'select'
drivers/mtd/nand/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mtd/nand/Kconfig +1 -0
@@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + depends on MXS_DMA help Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCH
Signature · 1 line
1.7.1
PATCH v2 2/3 mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA
I think we can merget the patch 1 and patch 2 to one patch.
Huang Shijie
Quoted 36 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
MTD_NAND_GPMI_NANDdriver depends onMXS_DMAto be selected, otherwise the following error happens forimx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Use 'depends' rather than 'select'drivers/mtd/nand/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mtd/nand/Kconfig +1
-1@@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + depends on MXS_DMA help Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCH --1.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerPATCH v2 2/3 mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA
Quoted 1 line · Huang Shijie
I think we can merget the patch 1 and patch 2 to one patch.
I am not sure on this, as they have clearly different purposes.
Patch 1 fixes the text file and include mx6.
Patch 2 fixes a build issue for mx6.
I prefer to keep them as seperate patches.
Regards,
Fabio Estevam
PATCH v2 2/3 mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA
In reply to Fabio EstevamQuoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
MTD_NAND_GPMI_NANDdriver depends onMXS_DMAto be selected, otherwise the following error happens forimx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1Signed-off-by Fabio Estevam <[email protected]>
Quoted 27 lines
---
Changes since v1:
- Use 'depends' rather than 'select'drivers/mtd/nand/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mtd/nand/Kconfig +1
-0@@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + depends on MXS_DMA help Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCHSignature · 7 lines
1.7.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Sascha Hauer
maintainerPATCH v2 2/3 mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA
In reply to Fabio EstevamQuoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
MTD_NAND_GPMI_NANDdriver depends onMXS_DMAto be selected, otherwise the following error happens forimx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1Signed-off-by Fabio Estevam <[email protected]>
As mentioned elsewhere in this thread: We should not select user visible options, so this patch is the only thing we can do atm (apart from 'fixing the tools' as David mentioned, but this is out of scope for an -rc kernel)
Additionally the imx_v6_v7_defconfig should be adjusted so that the gpmi nand driver actually gets built.
Sascha
Quoted 22 lines
---
Changes since v1:
- Use 'depends' rather than 'select'drivers/mtd/nand/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mtd/nand/Kconfig +1
-0@@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + depends on MXS_DMA help Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCHSignature · 1 line
1.7.1
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH v2 2/3 mtd: nand: Let MTD_NAND_GPMI_NAND depend on MXS_DMA
Quoted 10 lines · Sascha Hauer
Quoted 9 lines · Fabio Estevam
From: Fabio Estevam<[email protected]>
MTD_NAND_GPMI_NANDdriver depends onMXS_DMAto be selected, otherwise the following error happens forimx_v6_v7_defconfig:
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1
Quoted 8 lines
Quoted 1 line
Signed-off-by Fabio Estevam<[email protected]>Acked-by Sascha Hauer<[email protected]>As mentioned elsewhere in this thread: We should not select user visible options, so this patch is the only thing we can do atm (apart from 'fixing the tools' as David mentioned, but this is out of scope for an -rc kernel)
I asked Shawn about this and it seems that this patch is the way to go for the moment. So:
David: Artem: Building recent 3.6-rc1mainline with imx_v6_v7_defconfig is broken. We need this patch to get it working, again.
It would be nice if this patch could go as a fix into 3.6-rcX mainline asap. Could you help with this?
Many thanks and best regards
Dirk
Quoted 28 lines
Additionally the
imx_v6_v7_defconfigshould be adjusted so that the gpmi nand driver actually gets built.Sascha
Quoted 22 lines
---
Changes since v1:
- Use 'depends' rather than 'select'drivers/mtd/nand/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/mtd/nand/Kconfig +1
-1@@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + depends on MXS_DMA help Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCH --1.7.1
Fabio Estevam
reviewerPATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Let MXS_DMA be selected by default.
---
Changes since v1:
- No changes. Newly introduced in this series
arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
@@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=y CONFIG_RTC_DRV_MXC=y CONFIG_DMADEVICES=y CONFIG_IMX_SDMA=y +CONFIG_MXS_DMA=y CONFIG_COMMON_CLK_DEBUG=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT2_FS=y
Signature · 1 line
1.7.1
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Hi Fabio:
Quoted 16 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Let
MXS_DMAbe selected by default.Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- No changes. Newly introduced in this seriesarch/arm/configs/imx_v6_v7_defconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/configs/imx_v6_v7_defconfig +0
-0
arch/arm/configs/imx_v6_v7_defconfig CONFIG_RTC_DRV_MC13XXX=y · line 195
Quoted 4 lines
arch/arm/configs/imx_v6_v7_defconfig +1
-0@@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=y CONFIG_RTC_DRV_MXC=y CONFIG_DMADEVICES=y CONFIG_IMX_SDMA=y +CONFIG_MXS_DMA=y
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q. this patch makes the kernel built-in the mxs-dma, even the gpmi-nand is not enabled.
Huang Shijie
Quoted 11 lines
arch/arm/configs/imx_v6_v7_defconfig +0
-1CONFIG_COMMON_CLK_DEBUG=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT2_FS=y --1.7.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerPATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 3 lines · Huang Shijie
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q. this patch makes the kernel built-in the mxs-dma, even the gpmi-nand is not enabled.
Well, as the driver currently stands: yes, it is needed.
Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
This is why I thought that 'select MXS_DMA' was the way to go, but according to the thread you pointed me at, it was Nacked by Shawn.
Regards,
Fabio Estevam
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 9 lines · Fabio Estevam
Quoted 3 lines · Huang Shijie
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q. this patch makes the kernel built-in the mxs-dma, even the gpmi-nand is not enabled.
Well, as the driver currently stands: yes, it is needed.
Without
CONFIG_MXS_DMA, the GPMI driver cannot even be built.
But you have added "depend on MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
Huang Shijie
Quoted 7 lines
This is why I thought that 'select
MXS_DMA' was the way to go, but according to the thread you pointed me at, it was Nacked by Shawn.Regards,
Fabio Estevam
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 7 lines · Huang Shijie
Quoted 6 lines · Fabio Estevam
Quoted 3 lines · Huang Shijie
Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q. this patch makes the kernel built-in the mxs-dma, even the gpmi-nand is not enabled.
Quoted 8 lines
Quoted 3 lines
Well, as the driver currently stands: yes, it is needed.
Without
CONFIG_MXS_DMA, the GPMI driver cannot even be built.But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
How about using 'select MXS_DMA'?
drivers/mtd/nand/Kconfig +1 -0
@@ -481,6 +481,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + select MXS_DMA help
Then we do not need this patch and does not have the issue that MXS_DMA is still compiled even GPMI_NAND is not selected.
Regards
Dong Aisheng
Fabio Estevam
reviewerPATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 1 line · Dong Aisheng
How about using 'select
MXS_DMA'?
Ok, I prefer this way too. Will resubmit it soon. Hopefully it is OK with Shawn.
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 5 lines · Fabio Estevam
Quoted 1 line · Dong Aisheng
How about using 'select
MXS_DMA'?Ok, I prefer this way too. Will resubmit it soon. Hopefully it is OK with Shawn.
No. For your information, the following is whatDocumentation/kbuild/kconfig-language.txt tell.
Note:
select should be used with care. select will force a symbol to a value without visiting the dependencies. By abusing select you are able to select a symbol FOO even if FOO depends on BAR that is not set.
In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies. That will limit the usefulness but on the other hand avoid the illegal configurations all over.
Signature · 2 lines
Regards, Shawn
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
In reply to Huang ShijieQuoted 2 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the gpmi-nand.
That's an issue with the 'make *config' tools. I recommend fixing those instead; it's horrid to use 'select' on an option which *is* user-visible, such as CONFIG_MXS_DMA.
In the mid-1990s, there was a variant of the tcl 'make xconfig' which would *show* you the dependencies for things, and would allow you to turn them on with a single click. Is that really so hard for us to do?
Signature · 8 lines
dwmw2 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6171 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120726/07b8ffc0/attachment.bin>
Fabio Estevam
reviewerPATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
In reply to Huang ShijieQuoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
So how CONFIG_MXS_DMA would be selected if not via defconfig?
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 8 lines · Fabio Estevam
Quoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.So how
CONFIG_MXS_DMAwould be selected if not via defconfig?
Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
Huang Shijie
Fabio Estevam
reviewerPATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 8 lines · Huang Shijie
Quoted 7 lines · Fabio Estevam
Quoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.
Quoted 4 lines
Quoted 1 line
So how
CONFIG_MXS_DMAwould be selected if not via defconfig?Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select this option.
mxs_defconfig also selects CONFIG_MXS_DMA.
Can't we do the same here and let imx_v6_v7_defconfig be built again?
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 12 lines · Fabio Estevam
Quoted 11 lines · Huang Shijie
Quoted 8 lines · Fabio Estevam
Quoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.So how
CONFIG_MXS_DMAwould be selected if not via defconfig?Use the make menuconfig ARCH=arm:
Quoted 8 lines
Quoted 1 line
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select this option.
mxs_defconfigalso selectsCONFIG_MXS_DMA.
In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
Quoted 2 lines
Can't we do the same here and let
imx_v6_v7_defconfigbe built again?
Shawn, do you have any opinion about this?
Huang Shijie
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
Quoted 20 lines · Huang Shijie
Quoted 19 lines · Fabio Estevam
Quoted 8 lines · Huang Shijie
Quoted 7 lines · Fabio Estevam
Quoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.Quoted 4 lines
Quoted 1 line
So how
CONFIG_MXS_DMAwould be selected if not via defconfig?Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select this option.
Quoted 6 lines
Quoted 1 line
mxs_defconfigalso selectsCONFIG_MXS_DMA.In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
Quoted 2 lines
Can't we do the same here and let
imx_v6_v7_defconfigbe built again?Shawn, do you have any opinion about this?
Most drivers should be kernel modules. mxs_dma needs changes to support building as module.
Thanks
Richard
Quoted 8 lines
Huang Shijie
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
In reply to Huang ShijieQuoted 15 lines · Huang Shijie
Quoted 14 lines · Fabio Estevam
Quoted 11 lines · Huang Shijie
Quoted 7 lines · Fabio Estevam
Quoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.So how
CONFIG_MXS_DMAwould be selected if not via defconfig?Use the make menuconfig ARCH=arm:
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
Quoted 8 lines
Quoted 4 lines
It is not obvious for the end user that they need to manually select this option.
mxs_defconfigalso selectsCONFIG_MXS_DMA.In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
Quoted 1 line
Can't we do the same here and let
imx_v6_v7_defconfigbe built again?Shawn, do you have any opinion about this?
First, I think Shawn is on holiday at the moment.
Second, recent kernel mainline from today building imx_v6_v7_defconfig is broken due to this.
So to make it build again, we have to enable CONFIG_MXS_DMA anyhow. As it seems that GPMI_NAND needs it to build, I would vote for the
depends on MXS_DMA
fix proposed by Richard
http://www.spinics.net/lists/arm-kernel/msg186111.html
Anyhow, any chance to get the kernel mainline fixed asap?
Many thanks and best regards
Dirk
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
? 2012?07?27? 17:30, Dirk Behme ??:
Quoted 27 lines · Huang Shijie
Quoted 26 lines
Quoted 14 lines · Fabio Estevam
Quoted 12 lines · Huang Shijie
Quoted 8 lines · Fabio Estevam
Quoted 4 lines · Huang Shijie
But you have added "depend on
MXS_DMA". So If you do not select the mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.So how
CONFIG_MXS_DMAwould be selected if not via defconfig?Use the make menuconfig ARCH=arm:
Quoted 7 lines
Quoted 1 line
"device drivers"-->"DMA engine support" -->"mxs dma support"
I prefer to have selected in the defconfig by default instead.
It is not obvious for the end user that they need to manually select this option.
mxs_defconfigalso selectsCONFIG_MXS_DMA.In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.
Quoted 7 lines
Quoted 2 lines
Quoted 1 line
Can't we do the same here and let
imx_v6_v7_defconfigbe built again?Shawn, do you have any opinion about this?
First, I think Shawn is on holiday at the moment.
Second, recent kernel mainline from today building
imx_v6_v7_defconfigis broken due to this.
Sascha did not CC to me when he submitted the patch 3def84ed9 "ARM:imx_v6_v7_defconfig: ..".
I would check this patch if he CCed to me.
BR
Huang Shijie
Quoted 17 lines
So to make it build again, we have to enable
CONFIG_MXS_DMAanyhow. As it seems thatGPMI_NANDneeds it to build, I would vote for thedepends on
MXS_DMAfix proposed by Richard
http://www.spinics.net/lists/arm-kernel/msg186111.html
Anyhow, any chance to get the kernel mainline fixed asap?
Many thanks and best regards
Dirk
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
In reply to Fabio EstevamQuoted 2 lines · Fabio Estevam
It is not obvious for the end user that they need to manually select this option.
I repeat:
THIS IS A TOOLS ISSUE. FIX THE TOOLS.
Signature · 8 lines
dwmw2 -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/x-pkcs7-signature Size: 6171 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120726/3b7828fa/attachment-0001.bin>
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
In reply to Fabio EstevamQuoted 16 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Let
MXS_DMAbe selected by default.Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- No changes. Newly introduced in this seriesarch/arm/configs/imx_v6_v7_defconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/configs/imx_v6_v7_defconfig +0
-0
arch/arm/configs/imx_v6_v7_defconfig CONFIG_RTC_DRV_MC13XXX=y · line 198
Quoted 7 lines
arch/arm/configs/imx_v6_v7_defconfig +1
-0@@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=y CONFIG_RTC_DRV_MXC=y CONFIG_DMADEVICES=y CONFIG_IMX_SDMA=y +CONFIG_MXS_DMA=y CONFIG_COMMON_CLK_DEBUG=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT2_FS=y
Building mainline 3.6-rc1 with imx_v6_v7_defconfig this is still broken due to
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xab170): undefined reference to `mxs_dma_is_apbh'
Is any fix for this on its way to mainline? Either the above or any other one?
Best regards
Dirk
PATCH v2 3/3 ARM: imx_v6_v7_defconfig: Select MXS_DMA
? 2012?08?03? 16:40, Dirk Behme ??:
Quoted 33 lines · Fabio Estevam
Quoted 17 lines
From: Fabio Estevam <[email protected]>
Let
MXS_DMAbe selected by default.Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- No changes. Newly introduced in this seriesarch/arm/configs/imx_v6_v7_defconfig| 1 +1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/configs/imx_v6_v7_defconfig +0
-0@@ -192,6 +192,7 @@ CONFIG_RTC_DRV_MC13XXX=yQuoted 7 lines
CONFIG_RTC_DRV_MXC=yCONFIG_DMADEVICES=yCONFIG_IMX_SDMA=y
+CONFIG_MXS_DMA=yCONFIG_COMMON_CLK_DEBUG=y
#CONFIG_IOMMU_SUPPORTis not setCONFIG_EXT2_FS=yBuilding mainline 3.6-rc1 with
imx_v6_v7_defconfigthis is still broken due to
drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xab170): undefined reference to `mxs_dma_is_apbh'
Quoted 7 lines
Is any fix for this on its way to mainline? Either the above or any other one?
Best regards
Dirk
Since the gpmi has been enabled in the config file, I think it's better to select the mxs-dma in the config file too.
Huang Shijie
PATCH v2 1/3 mtd: nand: Include IMX6 in the list of supported SoCs
In reply to Fabio EstevamQuoted 16 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Include IMX6 in the list of supported SoCs.
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- No changesdrivers/mtd/nand/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/mtd/nand/Kconfig +0
-0
drivers/mtd/nand/Kconfig config MTD_NAND_GPMI_NAND · line 465
Quoted 2 lines
drivers/mtd/nand/Kconfig +0
-0@@ -464,7 +464,7 @@ config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
We don't need to list all SoCs. Shall we just check MXC or MXS ?
Thanks
Richard
Quoted 15 lines
drivers/mtd/nand/Kconfig +1
-1help - Enables NAND Flash support for IMX23 or IMX28. + Enables NAND Flash support for IMX23, IMX28 or IMX6. The GPMI controller is very powerful, with the help of BCH module, it can do the hardware ECC. The GPMI supports several NAND flashs at the same time. The GPMI may conflicts with otherSignature · 7 lines
1.7.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 1/3 mtd: nand: Include IMX6 in the list of supported SoCs
? 2012?07?27? 17:30, Richard Zhao ??:
Quoted 1 line
We don't need to list all SoCs. Shall we just check MXC or MXS ?
The gpmi nand controller only exits in mx23/mx23/mx50/mx6q. In mx53/mx35, we use the mxc-nand controller.
So it's better to list all the supported SoCs here.
Best Regards
Huang Shijie
PATCH v2 1/3 mtd: nand: Include IMX6 in the list of supported SoCs
In reply to Fabio EstevamQuoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Include IMX6 in the list of supported SoCs.
Signed-off-by Fabio Estevam <[email protected]>
Pushed this one to l2-mtd.git, thanks!
Signature · 9 lines
Best Regards, Artem Bityutskiy -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120817/cef18020/attachment.sig>