of/spi: Honour "status=disabled" property of device
PATCH 2/2 of/spi: Honour "status=disabled" property of device
From: Alexander Sverdlin <[email protected]>
of/spi: Honour "status=disabled" property of device
Currently of_register_spi_devices() function registers all SPI devices, independetly from their status property in device tree. According to "ePAPR 1.1" spec, device should only be registered if there is no "status" property, or it has "ok" (or "okay") value (see of_device_is_available()). In case of "platform devices", of_platform_device_create_pdata() checks for "status" and ensures that disabled devices are not pupulated. But such check for SPI buses was missing until now. Fix it.
---
drivers/spi/spi.c +1 -1
@@ -819,7 +819,7 @@ static void of_register_spi_devices(struif (!master->dev.of_node)return ; -for_each_child_of_node (master->dev.of_node, nc) { +for_each_available_child_of_node (master->dev.of_node, nc) {/* Alloc an spi_device */ spi =spi_alloc_device (master);if (!spi) {
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 13 lines · Alexander Sverdlin
From: Alexander Sverdlin <[email protected]>
of/spi: Honour "status=disabled" property of device
Currently
of_register_spi_devices()function registers all SPI devices, independetly from their status property in device tree. According to "ePAPR 1.1" spec, device should only be registered if there is no "status" property, or it has "ok" (or "okay") value (seeof_device_is_available()). In case of "platform devices",of_platform_device_create_pdata()checks for "status" and ensures that disabled devices are not pupulated. But such check for SPI buses was missing until now. Fix it.
Quoted 2 lines
Signed-off-by Alexander Sverdlin <[email protected]>---
This is under spi, but I've applied with the rest of the series (mdio and i2c). It all goes to Grant anyway.
BTW, there's a problem that the subject line is duplicated in your patches. I've fixed that up.
Rob
Quoted 11 lines
drivers/spi/spi.c +1
-1@@ -819,7 +819,7 @@ static void of_register_spi_devices(struif (!master->dev.of_node)return ; -for_each_child_of_node (master->dev.of_node, nc) { +for_each_available_child_of_node (master->dev.of_node, nc) {/* Alloc an spi_device */ spi =spi_alloc_device (master);if (!spi) {
Quoted 5 lines
_______________________________________________
devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
VERIFY Test and improve your parallel project with help from experts and peers. http://goparallel.sourceforge.net