Skip to contentSkip to conversation

ARM:kernel: a bug for perf by a redundancy character ';'

PATCH Superseded Chen Gang 2 participants 3 messages Feb 17, 2013

Subsystems (3)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH v2 1/1 ARM:kernel: a bug for perf by a redundancy character ';'

delete the redundancy character ';', which will cause issue.

---
 arch/arm/kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/kernel/perf_event.c +1 -1
index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
 	}
 
 	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
 			return -EINVAL;
 	}
 
Signature · 1 line
1.7.7.6
#1 lore raw

PATCH v2 1/1 ARM:kernel: a bug for perf by a redundancy character ';'

Am 17.02.2013 05:27, schrieb Chen Gang:

Quoted 5 lines

delete the redundancy character ';', which will cause issue.

I would prefer Will's version of the subject and commit message

http://git.kernel.org/?p=linux/kernel/git/will/linux.git;a=commitdiff;h=21fa771c94c4359807bb92dc8532b25c323ac543

And, btw, the Ack was for Will's version ;)

Dirk

Quoted 18 lines
---
  arch/arm/kernel/perf_event.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/kernel/perf_event.c +1 -1
index 31e0eb3..a892067 100644
@@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
  	}
 
  	if (event->group_leader != event) {
-		if (validate_group(event) != 0);
+		if (validate_group(event) != 0)
  			return -EINVAL;
  	}