mx23/mxs pending patches
v5 cover mx23/mxs pending patches
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and mx23_olinuxino boards. This depends on Marek's patchset which has included most of the previous patches in this patchset.
Changes in v5:
- Adapt code to newer multiport support
- Adapt code to newer multiport support
Changes in v2:
- Add changes for allow use of the USB hub
- Remove extra newline
Otavio Salvador (3):
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet support
board/olimex/mx23_olinuxino/mx23_olinuxino.c | 5 +++ board/olimex/mx23_olinuxino/spl_boot.c | 4 +++ include/configs/mx23_olinuxino.h | 50 ++++++++++++++++++++++++++-- include/configs/mx23evk.h | 11 ++++++ 4 files changed, 67 insertions(+), 3 deletions(-)
Signature · 1 line
1.8.1
PATCH v5 1/3 mx23evk: Enable USB support
This enabled USB support for the mx23evk board.
---
Changes in v5:
- Adapt code to newer multiport support
Changes in v2: None
include/configs/mx23evk.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/configs/mx23evk.h +11 -0
@@ -58,6 +58,7 @@#define CONFIG_CMD_FAT #define CONFIG_CMD_GPIO #define CONFIG_CMD_MMC +#define CONFIG_CMD_USB #define CONFIG_CMD_BOOTZ /* Memory configurations */
@@ -122,6 +123,16 @@#define CONFIG_MXS_MMC #endif +/* USB */ +#ifdef CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_MXS +#define CONFIG_EHCI_MXS_PORT0 +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1 +#define CONFIG_EHCI_IS_TDI +#define CONFIG_USB_STORAGE +#endif +/* Boot Linux */ #define CONFIG_CMDLINE_TAG #define CONFIG_SETUP_MEMORY_TAGS
Signature · 1 line
1.8.1
PATCH v5 1/3 mx23evk: Enable USB support
Quoted 4 lines · Otavio Salvador
This enabled USB support for the mx23evk board.
Signed-off-by Otavio Salvador <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 2/3 mx23_olinuxino: Enable USB support
In reply to Otavio SalvadorThis enabled USB support for the mx23_olinuxino board.
---
Changes in v5:
- Adapt code to newer multiport support
Changes in v2:
- Add changes for allow use of the USB hub
board/olimex/mx23_olinuxino/mx23_olinuxino.c | 5 +++++ board/olimex/mx23_olinuxino/spl_boot.c | 4 ++++ include/configs/mx23_olinuxino.h | 11 +++++++++++ 3 files changed, 20 insertions(+)
board/olimex/mx23_olinuxino/mx23_olinuxino.c +5 -0
@@ -45,6 +45,11 @@ int board_early_init_f(void)/* SSP0 clock at 96MHz */ mxs_set_sspclk (MXC_SSPCLK0 ,96000 ,0 ); +#ifdef CONFIG_CMD_USB +/* Enable LAN9512 */ +gpio_direction_output (MX23_PAD_GPMI_ALE__GPIO_0_17 ,1 ); +#endif +return 0 ; }
board/olimex/mx23_olinuxino/spl_boot.c +4 -0
@@ -95,6 +95,10 @@ const iomux_cfg_t iomux_setup[] = {MX23_PAD_SSP1_DATA2__SSP1_DATA2 |MUX_CONFIG_SSP ,MX23_PAD_SSP1_DATA3__SSP1_DATA3 |MUX_CONFIG_SSP ,MX23_PAD_SSP1_SCK__SSP1_SCK |MUX_CONFIG_SSP , + +/* Ethernet */ +MX23_PAD_GPMI_ALE__GPIO_0_17 | + (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL), };void board_init_ll (void )
include/configs/mx23_olinuxino.h +11 -0
@@ -60,6 +60,7 @@#define CONFIG_CMD_GPIO #define CONFIG_CMD_LED #define CONFIG_CMD_MMC +#define CONFIG_CMD_USB /* * Memory configurations
@@ -140,6 +141,16 @@*/ #define CONFIG_APBH_DMA +/* USB */ +#ifdef CONFIG_CMD_USB +#define CONFIG_USB_EHCI +#define CONFIG_USB_EHCI_MXS +#define CONFIG_EHCI_MXS_PORT0 +#define CONFIG_USB_MAX_CONTROLLER_COUNT 1 +#define CONFIG_EHCI_IS_TDI +#define CONFIG_USB_STORAGE +#endif +/* * Boot Linux */
Signature · 1 line
1.8.1
PATCH v5 2/3 mx23_olinuxino: Enable USB support
Quoted 4 lines · Otavio Salvador
This enabled USB support for the
mx23_olinuxinoboard.Signed-off-by Otavio Salvador <[email protected]>---
Applied to u-boot-imx, but...
board/olimex/mx23_olinuxino/mx23_olinuxino.c int board_early_init_f(void) · line 51
Quoted 7 lines
board/olimex/mx23_olinuxino/mx23_olinuxino.c +4
-0/* SSP0 clock at 96MHz */ mxs_set_sspclk (MXC_SSPCLK0 ,96000 ,0 ); +#ifdef CONFIG_CMD_USB +/* Enable LAN9512 */ +gpio_direction_output (MX23_PAD_GPMI_ALE__GPIO_0_17 ,1 ); +#endif
...the header for gpio is missing. Please send the patch to fix the warning.
mx23_olinuxino.c: In function 'board_early_init_f':
mx23_olinuxino.c:50:2: warning: implicit declaration of function 'gpio_direction_output' [-Wimplicit-function-declaration]
Thanks,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH v5 3/3 mx23_olinuxino: Add ethernet support
In reply to Otavio SalvadorThis adds support to the LAN9512 chip included in the board and extend the environment to easy netboot use.
---
Changes in v5: None
Changes in v2:
- Remove extra newline
include/configs/mx23_olinuxino.h | 39 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-)
include/configs/mx23_olinuxino.h +36 -3
@@ -55,11 +55,13 @@#define CONFIG_DOS_PARTITION #define CONFIG_CMD_CACHE +#define CONFIG_CMD_DHCP #define CONFIG_CMD_EXT2 #define CONFIG_CMD_FAT #define CONFIG_CMD_GPIO #define CONFIG_CMD_LED #define CONFIG_CMD_MMC +#define CONFIG_CMD_NET #define CONFIG_CMD_USB /*
@@ -151,6 +153,12 @@#define CONFIG_USB_STORAGE #endif +/* Ethernet */ +#ifdef CONFIG_CMD_NET +#define CONFIG_USB_HOST_ETHER +#define CONFIG_USB_ETHER_SMSC95XX +#endif +/* * Boot Linux */
@@ -192,6 +200,7 @@"fdt_file=imx23-olinuxino.dtb\0" \"fdt_addr=0x41000000\0" \"boot_fdt=try\0" \ +"ip_dyn=yes\0" \"mmcdev=0\0" \"mmcpart=2\0" \"mmcroot=/dev/mmcblk0p3 rw rootwait\0" \
@@ -217,6 +226,31 @@"fi; " \"else " \"bootm; " \ +"fi;\0" \ +"netargs=setenv bootargs console=${console_mainline},${baudrate} " \ +"root=/dev/nfs " \ +"ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \ +"netboot=echo Booting from net ...; " \ +"usb start; " \ +"run netargs; " \ +"if test ${ip_dyn} = yes; then " \ +"setenv get_cmd dhcp; " \ +"else " \ +"setenv get_cmd tftp; " \ +"fi; " \ +"${get_cmd} ${uimage}; " \ +"if test ${boot_fdt} = yes; then " \ +"if ${get_cmd} ${fdt_addr} ${fdt_file}; then " \ +"bootm ${loadaddr} - ${fdt_addr}; " \ +"else " \ +"if test ${boot_fdt} = try; then " \ +"bootm; " \ +"else " \ +"echo WARN: Cannot load the DT; " \ +"fi;" \ +"fi; " \ +"else " \ +"bootm; " \"fi;\0" #define CONFIG_BOOTCOMMAND \
@@ -226,10 +260,9 @@"else " \"if run loaduimage; then " \"run mmcboot; " \ -"else " \ -"echo ERR: Fail to boot from MMC; " \ +"else run netboot; " \"fi; " \"fi; " \ - "else exit; fi" + "else run netboot; fi"#endif /* __MX23_OLINUXINO_CONFIG_H__ */
Signature · 1 line
1.8.1
PATCH v5 3/3 mx23_olinuxino: Add ethernet support
Quoted 5 lines · Otavio Salvador
This adds support to the LAN9512 chip included in the board and extend the environment to easy netboot use.
Signed-off-by Otavio Salvador <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
v5 cover mx23/mxs pending patches
In reply to Otavio SalvadorQuoted 3 lines · Otavio Salvador
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and
mx23_olinuxinoboards. This depends on
What issues does this patch series fix? I see that it adds USB support, but I don't see any bug fix.
A message that is not in the archive (sent off-list or not yet received): CAP9ODKqBEXtLxKnQdah0h0hqqR2YrdYXn4CK5+w+hA23zdFK=A@mail.gmail.com
v5 cover mx23/mxs pending patches
Quoted 5 lines · Otavio Salvador
Quoted 2 lines
What issues does this patch series fix? I see that it adds USB support, but I don't see any bug fix.
This is the missing patches, which has not been included in Marek series. He has included most patches in his pull request but this one's.
[Adding the list]
Ok, I see, but looks like you forgot to update the cover letter, as there are no bug fixes in this series as stated here.
v5 cover mx23/mxs pending patches
Quoted 5 lines · Fabio Estevam
Quoted 3 lines · Otavio Salvador
Quoted 2 lines
What issues does this patch series fix? I see that it adds USB support, but I don't see any bug fix.
Quoted 7 lines
Quoted 2 lines
This is the missing patches, which has not been included in Marek series. He has included most patches in his pull request but this one's.
[Adding the list]
Ok, I see, but looks like you forgot to update the cover letter, as there are no bug fixes in this series as stated here.
Right; I forgot indeed.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
v5 cover mx23/mxs pending patches
In reply to Otavio SalvadorDear Otavio Salvador,
Quoted 9 lines
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and
mx23_olinuxinoboards. This depends on Marek's patchset which has included most of the previous patches in this patchset.Changes in v5:
- Adapt code to newer multiport support
- Adapt code to newer multiport support
Quoted 8 lines
Changes in v2:
- Add changes for allow use of the USB hub
- Remove extra newlineOtavio Salvador (3):
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet support
I fail to understand what happened with that flurry of patches that was in V4. But maybe this is V5 for other series? I'm confused.
Best regards,
Marek Vasut
v5 cover mx23/mxs pending patches
Quoted 15 lines · Marek Vasut
Dear Otavio Salvador,
Quoted 13 lines
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and
mx23_olinuxinoboards. This depends on Marek's patchset which has included most of the previous patches in this patchset.Changes in v5:
- Adapt code to newer multiport support
- Adapt code to newer multiport supportChanges in v2:
- Add changes for allow use of the USB hub
- Remove extra newline
Quoted 7 lines
Quoted 4 lines
Otavio Salvador (3):
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet supportI fail to understand what happened with that flurry of patches that was in V4. But maybe this is V5 for other series? I'm confused.
The other patches of this serie you picked in your last pull request so I did not resend them to avoid making it more confusing for Stefano.
So these are the 3 other ones.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
v5 cover mx23/mxs pending patches
Quoted 21 lines · Otavio Salvador
Quoted 20 lines · Marek Vasut
Dear Otavio Salvador,
Quoted 17 lines
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and
mx23_olinuxinoboards. This depends on Marek's patchset which has included most of the previous patches in this patchset.Changes in v5:
- Adapt code to newer multiport support
- Adapt code to newer multiport supportChanges in v2:
- Add changes for allow use of the USB hub
- Remove extra newlineOtavio Salvador (3):
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet support
Quoted 6 lines
Quoted 2 lines
I fail to understand what happened with that flurry of patches that was in V4. But maybe this is V5 for other series? I'm confused.
The other patches of this serie you picked in your last pull request so I did not resend them to avoid making it more confusing for Stefano.
Oh, I am stil lquite confused ;-)
I admit I cannot follow the ML in the lastr two weeks due to a urgent project, and I get a flood in my mailbox. Anyway, I have no problems with this series, and no comments are open. I apply it now.
Regards,
Stefano
Quoted 3 lines
So these are the 3 other ones.
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
v5 cover mx23/mxs pending patches
Dear Stefano Babic,
Quoted 25 lines · Otavio Salvador
Quoted 24 lines · Marek Vasut
Quoted 22 lines
Dear Otavio Salvador,
Quoted 9 lines
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and
mx23_olinuxinoboards. This depends on Marek's patchset which has included most of the previous patches in this patchset.Changes in v5:
- Adapt code to newer multiport support
- Adapt code to newer multiport supportQuoted 8 lines
Changes in v2:
- Add changes for allow use of the USB hub
- Remove extra newlineOtavio Salvador (3):
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet supportI fail to understand what happened with that flurry of patches that was in V4. But maybe this is V5 for other series? I'm confused.
Quoted 8 lines
Quoted 3 lines
The other patches of this serie you picked in your last pull request so I did not resend them to avoid making it more confusing for Stefano.
Oh, I am stil lquite confused ;-)
I admit I cannot follow the ML in the lastr two weeks due to a urgent project, and I get a flood in my mailbox.
No kidding, same here.
Quoted 2 lines
Anyway, I have no problems
with this series, and no comments are open. I apply it now.
Check u-boot-testing :: mx233 if it helps, I picked all patches that shall be applied in there.
Quoted 4 lines
Regards,
StefanoQuoted 1 line
So these are the 3 other ones.
Best regards,
Marek Vasut
v5 cover mx23/mxs pending patches
Quoted 36 lines · Marek Vasut
Dear Stefano Babic,
Quoted 25 lines · Otavio Salvador
Quoted 24 lines · Marek Vasut
Quoted 22 lines
Dear Otavio Salvador,
Quoted 9 lines
This patchset includes the pending patches we have in our tree. It fixes issues for mx23evk and
mx23_olinuxinoboards. This depends on Marek's patchset which has included most of the previous patches in this patchset.Changes in v5:
- Adapt code to newer multiport support
- Adapt code to newer multiport supportQuoted 8 lines
Changes in v2:
- Add changes for allow use of the USB hub
- Remove extra newlineOtavio Salvador (3):
mx23evk: Enable USB support
mx23_olinuxino: Enable USB support
mx23_olinuxino: Add ethernet supportI fail to understand what happened with that flurry of patches that was in V4. But maybe this is V5 for other series? I'm confused.
Quoted 8 lines
Quoted 3 lines
The other patches of this serie you picked in your last pull request so I did not resend them to avoid making it more confusing for Stefano.
Oh, I am stil lquite confused ;-)
I admit I cannot follow the ML in the lastr two weeks due to a urgent project, and I get a flood in my mailbox.
Quoted 7 lines
No kidding, same here.
Quoted 2 lines
Anyway, I have no problems
with this series, and no comments are open. I apply it now.Check u-boot-testing :: mx233 if it helps, I picked all patches that shall be applied in there.
There're patches which where not send for review there (as Makefile change)
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
v5 cover mx23/mxs pending patches
Quoted 4 lines · Otavio Salvador
Quoted 2 lines
Check u-boot-testing :: mx233 if it helps, I picked all patches that shall be applied in there.
There're patches which where not send for review there (as
Makefilechange)
Of course, such patches (I have find only what you mention) cannot be picked up at all if not reviewed here.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
v5 cover mx23/mxs pending patches
Dear Stefano Babic,
Quoted 9 lines · Otavio Salvador
Quoted 5 lines
Quoted 2 lines
Check u-boot-testing :: mx233 if it helps, I picked all patches that shall be applied in there.
There're patches which where not send for review there (as
Makefilechange)Of course, such patches (I have find only what you mention) cannot be picked up at all if not reviewed here.
Sorry about that, that one convenience patch slipped in. I see you managed to pick the rest of those, thanks!
Best regards,
Marek Vasut