Skip to contentSkip to conversation

arm: at91: dt: at91sam9x5: correct NAND pins comments

PATCH New Richard Genoud 3 participants 4 messages Mar 11, 2013 – Mar 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm: at91: dt: at91sam9x5: correct NAND pins comments

Comments on NAND pins where inverted.

---
based on 3.9-rc2

 arch/arm/boot/dts/at91sam9x5.dtsi |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91sam9x5.dtsi +2 -2
index aa98e64..9b5d048 100644
@@ -238,8 +238,8 @@
 				nand {
 					pinctrl_nand: nand-0 {
 						atmel,pins =
-							<3 4 0x0 0x1	/* PD5 gpio RDY pin pull_up */
-							 3 5 0x0 0x1>;	/* PD4 gpio enable pin pull_up */
+							<3 4 0x0 0x1	/* PD4 gpio Chip Enable pin pull_up */
+							 3 5 0x0 0x1>;	/* PD5 gpio RDY/BUSY pin pull_up */
 					};
 				};
 
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH 2/2 arm: at91: dt: at91sam9x5: complete NAND pinctrl

There was only chip enable and readdy/busy pins for the nand controller. This add the rest of the pins.
pinctrl_nand_16bits contains the specific muxes for 16 bits NANDs.

---
based on 3.9-rc2

 arch/arm/boot/dts/at91sam9x5.dtsi |   28 ++++++++++++++++++++++++++--
 1 files changed, 26 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91sam9x5.dtsi +26 -2
index 9b5d048..a98c0d5 100644
@@ -238,8 +238,32 @@
 				nand {
 					pinctrl_nand: nand-0 {
 						atmel,pins =
-							<3 4 0x0 0x1	/* PD4 gpio Chip Enable pin pull_up */
-							 3 5 0x0 0x1>;	/* PD5 gpio RDY/BUSY pin pull_up */
+							<3 0 0x1 0x0	/* PD0 periph A Read Enable */
+							 3 1 0x1 0x0	/* PD1 periph A Write Enable */
+							 3 2 0x1 0x0	/* PD2 periph A Address Latch Enable */
+							 3 3 0x1 0x0	/* PD3 periph A Command Latch Enable */
+							 3 4 0x0 0x1	/* PD4 gpio Chip Enable pin pull_up */
+							 3 5 0x0 0x1	/* PD5 gpio RDY/BUSY pin pull_up */
+							 3 6 0x1 0x0	/* PD6 periph A Data bit 0 */
+							 3 7 0x1 0x0	/* PD7 periph A Data bit 1 */
+							 3 8 0x1 0x0	/* PD8 periph A Data bit 2 */
+							 3 9 0x1 0x0	/* PD9 periph A Data bit 3 */
+							 3 10 0x1 0x0	/* PD10 periph A Data bit 4 */
+							 3 11 0x1 0x0	/* PD11 periph A Data bit 5 */
+							 3 12 0x1 0x0	/* PD12 periph A Data bit 6 */
+							 3 13 0x1 0x0>;	/* PD13 periph A Data bit 7 */
+					};
+
+					pinctrl_nand_16bits: nand_16bits-0 {
+						atmel,pins =
+							<3 14 0x1 0x0	/* PD14 periph A Data bit 8 */
+							 3 15 0x1 0x0	/* PD15 periph A Data bit 9 */
+							 3 16 0x1 0x0	/* PD16 periph A Data bit 10 */
+							 3 17 0x1 0x0	/* PD17 periph A Data bit 11 */
+							 3 18 0x1 0x0	/* PD18 periph A Data bit 12 */
+							 3 19 0x1 0x0	/* PD19 periph A Data bit 13 */
+							 3 20 0x1 0x0	/* PD20 periph A Data bit 14 */
+							 3 21 0x1 0x0>;	/* PD21 periph A Data bit 15 */
 					};
 				};
 
Signature · 1 line
1.7.2.5
#2 lore raw

PATCH 1/2 arm: at91: dt: at91sam9x5: correct NAND pins comments

In reply to Richard Genoud
Quoted 3 lines · Richard Genoud

Comments on NAND pins where inverted.

Best Regards,
J.

Quoted 24 lines

---
based on 3.9-rc2

 arch/arm/boot/dts/at91sam9x5.dtsi |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91sam9x5.dtsi +2 -2
index aa98e64..9b5d048 100644
@@ -238,8 +238,8 @@
 				nand {
 					pinctrl_nand: nand-0 {
 						atmel,pins =
-							<3 4 0x0 0x1	/* PD5 gpio RDY pin pull_up */
-							 3 5 0x0 0x1>;	/* PD4 gpio enable pin pull_up */
+							<3 4 0x0 0x1	/* PD4 gpio Chip Enable pin pull_up */
+							 3 5 0x0 0x1>;	/* PD5 gpio RDY/BUSY pin pull_up */
 					};
 				};
 
Signature · 1 line
1.7.2.5
#3 lore raw

PATCH 1/2 arm: at91: dt: at91sam9x5: correct NAND pins comments

In reply to Richard Genoud

On 03/11/2013 03:12 PM, Richard Genoud :

Quoted 15 lines

Comments on NAND pins where inverted.

---
based on 3.9-rc2

 arch/arm/boot/dts/at91sam9x5.dtsi |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/at91sam9x5.dtsi +0 -0
index aa98e64..9b5d048 100644

arch/arm/boot/dts/at91sam9x5.dtsi line 245

Quoted 10 lines
arch/arm/boot/dts/at91sam9x5.dtsi +2 -2
@@ -238,8 +238,8 @@
 				nand {
 					pinctrl_nand: nand-0 {
 						atmel,pins =
-							<3 4 0x0 0x1	/* PD5 gpio RDY pin pull_up */
-							 3 5 0x0 0x1>;	/* PD4 gpio enable pin pull_up */
+							<3 4 0x0 0x1	/* PD4 gpio Chip Enable pin pull_up */
+							 3 5 0x0 0x1>;	/* PD5 gpio RDY/BUSY pin pull_up */
 					};
 				};
 

Thanks, both queued in at91-3.9-fixes branch.

Best regards,

Signature · 1 line
Nicolas Ferre