SCSI: really use SATL version in VPD
A message that is not in the archive (sent off-list or not yet received): satl-driver-version-v2
PATCH 1/1 SCSI: really use SATL version in VPD
As per c78968bb by Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD) We need to provide the SATL driver version and not the disk firmware version
but the code overwrites the driver version with the disk version.
--- drivers/ata/libata-scsi.c | 1 - 1 file changed, 1 deletion(-)
drivers/ata/libata-scsi.c +0 -1
@@ -2126,7 +2126,6 @@ static unsigned int ata_scsiop_inq_89(struct ata_scsi_args *args, u8 *rbuf)memcpy (&rbuf[8 ],"linux " ,8 );memcpy (&rbuf[16 ],"libata " ,16 );memcpy (&rbuf[32 ],DRV_VERSION ,4 ); -ata_id_string (args->id, &rbuf[32 ],ATA_ID_FW_REV ,4 );/* we don't store the ATA device signature, so we fake it */
Signature · 1 line
1.7.10.4
Hello.
On 05-04-2013 18:50, Baruch Even wrote:
When you post a new revision of the patch, this should be marked in the
subject, like this: {PATCH v2].
Quoted 1 line
As per
c78968bbby Jeff Garzik ([libata] SCSI: simulator version, not device version, belongs in VPD)
Please wrap your lines at 80 characters max.
Quoted 4 lines
We need to provide the SATL driver version and not the disk firmware version but the code overwrites the driver version with the disk version.
Signed-off-by Baruch Even <[email protected]>
WBR, Sergei