arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide() which used by 'DECLARE_PCI_FIXUP_HEADER'
PATCH 1/1 arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide() which used by 'DECLARE_PCI_FIXUP_HEADER'
pci_fixup_umc_ide() is for 'DECLARE_PCI_FIXUP_HEADER', so need remove it from init section to normal section.
The related warning (with allmodconfig):
LD arch/frv/mb93090-mb00/built-in.o
WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide to the function .init.text:pci_fixup_umc_ide() The variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide references
a function __init pci_fixup_umc_ide().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __init annotation ofpci_fixup_umc_ide() so it may be used outside an exit section.
--- arch/frv/mb93090-mb00/pci-vdk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/frv/mb93090-mb00/pci-vdk.c +1 -1
@@ -254,7 +254,7 @@ static void __init pcibios_fixup_peer_bridges(void)* Exceptions for specific devices. Usually work-arounds for fatal design flaws. */ -static void __init pci_fixup_umc_ide (struct pci_dev *d) +static void pci_fixup_umc_ide (struct pci_dev *d) {/* * UM8886BF IDE controller sets region type bits incorrectly,
Signature · 1 line
1.7.7.6
Quoted 15 lines · Chen Gang
pci_fixup_umc_ide()is for 'DECLARE_PCI_FIXUP_HEADER', so need remove it from init section to normal section.The related warning (with allmodconfig):
LD
arch/frv/mb93090-mb00/built-in.o
WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable__pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ideto the function .init.text:pci_fixup_umc_ide() The variable__pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_idereferences
a function__initpci_fixup_umc_ide().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the__initannotation ofpci_fixup_umc_ide()so it may be used outside an exit section.
Quoted 1 line
Signed-off-by Chen Gang <[email protected]>
Quoted 19 lines
--- arch/frv/mb93090-mb00/pci-vdk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)arch/frv/mb93090-mb00/pci-vdk.c +1
-2@@ -254,7 +254,7 @@ static void __init pcibios_fixup_peer_bridges(void)* Exceptions for specific devices. Usually work-arounds for fatal design flaws. */ -static void __init pci_fixup_umc_ide (struct pci_dev *d) +static void pci_fixup_umc_ide (struct pci_dev *d) {/* * UM8886BF IDE controller sets region type bits incorrectly, -- 1.7.7.6
Quoted 16 lines · Bjorn Helgaas
Quoted 15 lines · Chen Gang
Quoted 15 lines
pci_fixup_umc_ide()is for 'DECLARE_PCI_FIXUP_HEADER', so need remove it from init section to normal section.The related warning (with allmodconfig):
LD
arch/frv/mb93090-mb00/built-in.o
WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable__pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ideto the function .init.text:pci_fixup_umc_ide() The variable__pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_idereferences
a function__initpci_fixup_umc_ide().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the__initannotation ofpci_fixup_umc_ide()so it may be used outside an exit section.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Chen Gang <[email protected]>Reviewed-by Bjorn Helgaas <[email protected]>
Thanks.
Signature · 3 lines
Chen Gang Asianux Corporation