Skip to contentSkip to conversation

arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide() which used by 'DECLARE_PCI_FIXUP_HEADER'

PATCH In review Chen Gang 2 participants 3 messages Jun 26, 2013 – Jun 27, 2013 Generic include/asm header files

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide() which used by 'DECLARE_PCI_FIXUP_HEADER'

pci_fixup_umc_ide() is for 'DECLARE_PCI_FIXUP_HEADER', so need remove it from init section to normal section.

The related warning (with allmodconfig):

LD arch/frv/mb93090-mb00/built-in.o
WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide to the function .init.text:pci_fixup_umc_ide() The variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide references
a function __init pci_fixup_umc_ide().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __init annotation of
pci_fixup_umc_ide() so it may be used outside an exit section.

---
 arch/frv/mb93090-mb00/pci-vdk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/frv/mb93090-mb00/pci-vdk.c +1 -1
index 0aa35f0..56a3abf 100644
@@ -254,7 +254,7 @@ static void __init pcibios_fixup_peer_bridges(void)
  * Exceptions for specific devices. Usually work-arounds for fatal design flaws.
  */
 
-static void __init pci_fixup_umc_ide(struct pci_dev *d)
+static void pci_fixup_umc_ide(struct pci_dev *d)
 {
 	/*
 	 * UM8886BF IDE controller sets region type bits incorrectly,
Signature · 1 line
1.7.7.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 15 lines · Chen Gang

pci_fixup_umc_ide() is for 'DECLARE_PCI_FIXUP_HEADER', so need remove it from init section to normal section.

The related warning (with allmodconfig):

LD arch/frv/mb93090-mb00/built-in.o
WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide to the function .init.text:pci_fixup_umc_ide() The variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide references
a function __init pci_fixup_umc_ide().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __init annotation of
pci_fixup_umc_ide() so it may be used outside an exit section.

Quoted 1 line
Quoted 19 lines
---
 arch/frv/mb93090-mb00/pci-vdk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/frv/mb93090-mb00/pci-vdk.c +1 -2
index 0aa35f0..56a3abf 100644
@@ -254,7 +254,7 @@ static void __init pcibios_fixup_peer_bridges(void)
  * Exceptions for specific devices. Usually work-arounds for fatal design flaws.
  */
 
-static void __init pci_fixup_umc_ide(struct pci_dev *d)
+static void pci_fixup_umc_ide(struct pci_dev *d)
 {
        /*
         * UM8886BF IDE controller sets region type bits incorrectly,
--

1.7.7.6

author
#2 lore raw
Quoted 16 lines · Bjorn Helgaas
Quoted 15 lines · Chen Gang
Quoted 15 lines

pci_fixup_umc_ide() is for 'DECLARE_PCI_FIXUP_HEADER', so need remove it from init section to normal section.

The related warning (with allmodconfig):

LD arch/frv/mb93090-mb00/built-in.o
WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide to the function .init.text:pci_fixup_umc_ide() The variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide references
a function __init pci_fixup_umc_ide().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __init annotation of
pci_fixup_umc_ide() so it may be used outside an exit section.

Quoted 3 lines
Quoted 1 line
Quoted 1 line

Thanks.

Signature · 3 lines
Chen Gang

Asianux Corporation