Skip to contentSkip to conversation

video: da8xx-fb: driver enhance to support TI am335x SoC

PATCH In review Darren Etheridge 2 participants 2 messages Aug 5, 2013 – Aug 9, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

v3 cover video: da8xx-fb: driver enhance to support TI am335x SoC

Changes in v3:
Address the patch authorship requirements
Pull out the DT changes into a separate series
Fix an issue where FB_MODE_HELPERS was not included in build
but is a dependency.
Include the devm_ changes and error reporting that Prabhakar Lad
had pushed a patch for,
A few more cosmetic changes
Add a patch to remove the use on inline from a number of functions

Changes in v2:
Addressing review comments from Tomi Valkeinen:
Dropped readl/writel patch as it is not necessary for non-cached,
non-buffered memory.
Many cosmetic changes to make code easier to understand

This is primarily a resend of a series of patches that were original submitted to linux-fbdev back in January of 2013 for 3.8 by Afzal Mohammed. I have rebased them on 3.10 and also made sure they apply cleanly to the 'for-next' branch of linux-fbdev git. The patches enable use of the current mainline da8xx-fb driver on the TI AM335x SOC along with some bug fixes and cleanup.

The original patch series can be found here:
https://patchwork.kernel.org/project/linux-fbdev/list/?submitter9101
if you want to see the history.

Afzal Mohammed (11):
video: da8xx-fb: fb_check_var enhancement
video: da8xx-fb: simplify lcd_reset
video: da8xx-fb: use modedb helper to update var
video: da8xx-fb: remove unneeded "var" initialization
video: da8xx-fb: store current display information
video: da8xx-fb: store clk rate even if !CPUFREQ
video: da8xx-fb: store struct device *
video: da8xx-fb: report correct pixclock
video: da8xx-fb: enable sync lost intr for v2 ip
video: da8xx-fb: ensure non-null cfg in pdata
video: da8xx-fb: reorganize panel detection

Darren Etheridge (9):
video: da8xx-fb: pix clk and clk div handling cleanup
video: da8xx-fb: fb_set_par support
video: da8xx-fb: improve readability of code
video: da8xx-fb: fix 24bpp raster configuration
video: da8xx-fb: use devres
video: da8xx-fb: set upstream clock rate (if reqd)
video: da8xx-fb: make clock naming consistent
video: da8xx-fb: let compiler decide what to inline
video: da8xx-fb: adding am33xx as dependency

 drivers/video/Kconfig    |    8 +-
 drivers/video/da8xx-fb.c |  352 +++++++++++++++++++++++++++-------------------
 include/video/da8xx-fb.h |    5 +
 3 files changed, 216 insertions(+), 149 deletions(-)
#1 lore raw

Hi,

Quoted 25 lines · Darren Etheridge

Changes in v3:
Address the patch authorship requirements
Pull out the DT changes into a separate series
Fix an issue where FB_MODE_HELPERS was not included in build
but is a dependency.
Include the devm_ changes and error reporting that Prabhakar Lad
had pushed a patch for,
A few more cosmetic changes
Add a patch to remove the use on inline from a number of functions

Changes in v2:
Addressing review comments from Tomi Valkeinen:
Dropped readl/writel patch as it is not necessary for non-cached,
non-buffered memory.
Many cosmetic changes to make code easier to understand

This is primarily a resend of a series of patches that were original submitted to linux-fbdev back in January of 2013 for 3.8 by Afzal Mohammed. I have rebased them on 3.10 and also made sure they apply cleanly to the 'for-next' branch of linux-fbdev git. The patches enable use of the current mainline da8xx-fb driver on the TI AM335x SOC along with some bug fixes and cleanup.

Quoted 3 lines

The original patch series can be found here:
https://patchwork.kernel.org/project/linux-fbdev/list/?submitter=39101
if you want to see the history.

I think the series looks fine. I've applied it to:

git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git 3.12/da8xx

Tomi