Skip to contentSkip to conversation

ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

PATCH New Koen Kooi 3 participants 12 messages Sep 9, 2013 – Sep 10, 2013

Subsystems (3)
lore
Share & tools
lore

Koen Kooi

author
#0 lore raw

PATCH 1/1 ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org

---

Changes since v4:
attempting to correctly to the cc: stable@ thing
Changes since v3:
removed stray whitespace, spotted by Matt Porter
added CC: stable
Changes since v2:
Updated commit message to point out that the existing DT will damage the board.
Changes since v1:
Added the Makefile entry for the new dts

 arch/arm/boot/dts/Makefile                |   1 +
 arch/arm/boot/dts/am335x-bone-common.dtsi | 262 ++++++++++++++++++++++++++++++
 arch/arm/boot/dts/am335x-bone.dts         | 256 +----------------------------
 arch/arm/boot/dts/am335x-boneblack.dts    |  17 ++
 4 files changed, 281 insertions(+), 255 deletions(-)
 create mode 100644 arch/arm/boot/dts/am335x-bone-common.dtsi
 create mode 100644 arch/arm/boot/dts/am335x-boneblack.dts
arch/arm/boot/dts/Makefile +1 -0
index 000cf76..d515c54 100644
@@ -183,6 +183,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
 	am335x-evm.dtb \
 	am335x-evmsk.dtb \
 	am335x-bone.dtb \
+	am335x-boneblack.dtb \
 	am3517-evm.dtb \
 	am3517_mt_ventoux.dtb \
 	am43x-epos-evm.dtb
arch/arm/boot/dts/am335x-bone-common.dtsi new file +262 -0

262 lines not on this page · raw message

arch/arm/boot/dts/am335x-bone.dts +1 -255

259 lines not on this page · raw message

arch/arm/boot/dts/am335x-boneblack.dts new file +17 -0
new file mode 100644
index 0000000..197cadf
@@ -0,0 +1,17 @@
+/*
+ * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+/dts-v1/;
+
+#include "am33xx.dtsi"
+#include "am335x-bone-common.dtsi"
+
+&ldo3_reg {
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <1800000>;
+	regulator-always-on;
+};
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 ARM: OMAP2+: am335x-bone*: add DT for BeagleBone Black

Quoted 7 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

Quoted 7 lines

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org

I guess the subject should've included v5? Also, if this is to be stable material, it will likely need rework since I don't think it will apply cleanly to older trees due to DT churn.

Anyways, for this patch...

Even though I've probably already fried my HDMI transciever due to using the original DTS a lot more than a dozen times. (and to TI: yes, I'd accept a new BB black as a sympathy gift.) ;)

Also, I tested this on both BBW and BBW:

Benoit, assuming this looks good to you, can you queue this for v3.12-rc
please? It applies to Linus' HEAD today (which has most of arm-soc
merged), so it should apply cleanly on top of all your stuff.

Kevin

author
#2 lore raw

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 11 lines
Quoted 9 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Quoted 7 lines
Quoted 5 lines
Cc stable at vger.kernel.org

I guess the subject should've included v5?

Yes, I blame it on being monday :)

Quoted 3 lines

Also, if this is to be
stable material, it will likely need rework since I don't think it will apply cleanly to older trees due to DT churn.

Ah right, the preprocessor changes. We'll see what happens with the stable trees. Most older kernels are useless on am335x, but the just released 3.11 is dangerous enough to get this backported.

Quoted 11 lines

Anyways, for this patch...

Even though I've probably already fried my HDMI transciever due to using the original DTS a lot more than a dozen times. (and to TI: yes, I'd accept a new BB black as a sympathy gift.) ;)

Also, I tested this on both BBW and BBW:

Thanks!

regards,

Koen

Quoted 6 lines

Benoit, assuming this looks good to you, can you queue this for v3.12-rc
please? It applies to Linus' HEAD today (which has most of arm-soc
merged), so it should apply cleanly on top of all your stuff.

Kevin

#3 lore raw
Quoted 16 lines · Koen Kooi

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Thanks,

-Joel

author
#4 lore raw

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 25 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

Quoted 7 lines

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

#5 lore raw
Quoted 33 lines · Koen Kooi

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Quoted 5 lines
Quoted 2 lines

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

Regards,

-Joel

#6 lore raw
Quoted 34 lines · Joel Fernandes
Quoted 33 lines · Koen Kooi

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

I noticed - there were still some comments from Felipe on the v4 series of this patch regarding RF cape and HDMI may be breaking it. How are you addressing that?

Regards,

-Joel

author
#7 lore raw

Op 9 sep. 2013, om 21:50 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 41 lines · Joel Fernandes
Quoted 40 lines · Koen Kooi
Quoted 38 lines

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 25 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

Quoted 7 lines

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

Quoted 6 lines
Quoted 3 lines

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

I noticed - there were still some comments from Felipe on the v4 series of this patch regarding RF cape and HDMI may be breaking it. How are you addressing that?

Capes will never go into the .dts and HDMI support needs some serious patching before it can get enabled in the DT. And the RF cape isn't being sold since it has no sw support. No need to worry about things in the 3.15/3.16 timeframe. Unless you want this LDO3 fix not to go in ASAP.

Joel, is there anything relevant *right now* blocking this patch going in? If not, please test it and add your Tested-by: line.

#8 lore raw
Quoted 48 lines · Koen Kooi

Op 9 sep. 2013, om 21:50 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 45 lines · Joel Fernandes
Quoted 43 lines · Koen Kooi
Quoted 33 lines

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Quoted 5 lines
Quoted 2 lines

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

Quoted 7 lines
Quoted 2 lines

I noticed - there were still some comments from Felipe on the v4 series of this patch regarding RF cape and HDMI may be breaking it. How are you addressing that?

Capes will never go into the .dts and HDMI support needs some serious patching before it can get enabled in the DT. And the RF cape isn't being sold since it has no sw support. No need to worry about things in the 3.15/3.16 timeframe. Unless you want this LDO3 fix not to go in ASAP.

Joel, is there anything relevant *right now* blocking this patch going in? If not, please test it and add your Tested-by: line.

We don't merge things in hurry and focus is to do things the right way.. I just want to make sure that all possible comments have been addressed.

Otherwise patch looks OK and hope everyone else thinks so too. I am dealing with some merge conflicts right now with my series on top of this though, but they should be easy enough to fix up. That's delaying my testing, but otherwise as such I don't have any objection to this patch (provided the conclusion is that all comments have been addressed..). Thanks!

Regards,

-Joel

Tested-by
#9 lore raw
Quoted 57 lines · Joel Fernandes
Quoted 48 lines · Koen Kooi

Op 9 sep. 2013, om 21:50 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 45 lines · Joel Fernandes
Quoted 43 lines · Koen Kooi
Quoted 33 lines

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Quoted 5 lines
Quoted 2 lines

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

Quoted 7 lines
Quoted 2 lines

I noticed - there were still some comments from Felipe on the v4 series of this patch regarding RF cape and HDMI may be breaking it. How are you addressing that?

Capes will never go into the .dts and HDMI support needs some serious patching before it can get enabled in the DT. And the RF cape isn't being sold since it has no sw support. No need to worry about things in the 3.15/3.16 timeframe. Unless you want this LDO3 fix not to go in ASAP.

Joel, is there anything relevant *right now* blocking this patch going in? If not, please test it and add your Tested-by: line.

Quoted 8 lines

We don't merge things in hurry and focus is to do things the right way.. I just want to make sure that all possible comments have been addressed.

Otherwise patch looks OK and hope everyone else thinks so too. I am dealing with some merge conflicts right now with my series on top of this though, but they should be easy enough to fix up. That's delaying my testing, but otherwise as such I don't have any objection to this patch (provided the conclusion is that all comments have been addressed..). Thanks!

Koen,

One note though, since I don't use HDMI (or BBB much for that matter), I was ok with taking a risk of upping the ldo3 regulator voltage to 3.3v on my board which I needed to do to get to the boot prompt.

I applied my AM335x DMA and MMC patches and tried to boot with rootfs as MMC1.

With 1.8v, I get the following during boot:

[    2.236043] mmc0: host doesn't support card's voltages
[    2.241659] mmc0: error -22 whilst initialising SD card

That's strange because I do have an SDHC card. With 3.3v it works fine.

I will add a note about this to my series. Since this more of an MMC issue than anything, and your patch series doesn't enable MMC, you can add my tested-by:

Later on, the regulator voltage may need to be tweaked for MMC support.

Regards,

-Joel

author
#10 lore raw

Op 10 sep. 2013, om 01:42 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 78 lines · Joel Fernandes
Quoted 57 lines · Koen Kooi
Quoted 48 lines

Op 9 sep. 2013, om 21:50 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 45 lines · Joel Fernandes
Quoted 43 lines · Koen Kooi
Quoted 33 lines

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Quoted 5 lines
Quoted 2 lines

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

Quoted 7 lines
Quoted 2 lines

I noticed - there were still some comments from Felipe on the v4 series of this patch regarding RF cape and HDMI may be breaking it. How are you addressing that?

Capes will never go into the .dts and HDMI support needs some serious patching before it can get enabled in the DT. And the RF cape isn't being sold since it has no sw support. No need to worry about things in the 3.15/3.16 timeframe. Unless you want this LDO3 fix not to go in ASAP.

Joel, is there anything relevant *right now* blocking this patch going in? If not, please test it and add your Tested-by: line.

Quoted 8 lines

We don't merge things in hurry and focus is to do things the right way.. I just want to make sure that all possible comments have been addressed.

Otherwise patch looks OK and hope everyone else thinks so too. I am dealing with some merge conflicts right now with my series on top of this though, but they should be easy enough to fix up. That's delaying my testing, but otherwise as such I don't have any objection to this patch (provided the conclusion is that all comments have been addressed..). Thanks!

Koen,

One note though, since I don't use HDMI (or BBB much for that matter), I was ok with taking a risk of upping the ldo3 regulator voltage to 3.3v on my board which I needed to do to get to the boot prompt.
I applied my AM335x DMA and MMC patches and tried to boot with rootfs as MMC1.

With 1.8v, I get the following during boot:

[    2.236043] mmc0: host doesn't support card's voltages
[    2.241659] mmc0: error -22 whilst initialising SD card
Quoted 8 lines

That's strange because I do have an SDHC card. With 3.3v it works fine.

I will add a note about this to my series. Since this more of an MMC issue than anything, and your patch series doesn't enable MMC, you can add my tested-by:

Later on, the regulator voltage may need to be tweaked for MMC support.

See https://lkml.org/lkml/2013/9/6/95 and https://lkml.org/lkml/2013/9/6/183

#11 lore raw
Quoted 80 lines · Koen Kooi

Op 10 sep. 2013, om 01:42 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 77 lines · Joel Fernandes
Quoted 54 lines · Koen Kooi
Quoted 46 lines

Op 9 sep. 2013, om 21:50 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 43 lines · Joel Fernandes
Quoted 41 lines · Koen Kooi
Quoted 33 lines

Op 9 sep. 2013, om 20:27 heeft Joel Fernandes <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi
Quoted 16 lines

Op 9 sep. 2013, om 17:23 heeft Kevin Hilman <[email protected]> het volgende geschreven:

Quoted 13 lines
Quoted 11 lines · Koen Kooi

The BeagleBone Black is basically a regular BeagleBone with eMMC and HDMI added, so create a common dtsi both can use.

IMPORTANT: booting the existing am335x-bone.dts will blow up the HDMI transceiver after a dozen boots with an uSD card inserted because LDO will be at 3.3V instead of 1.8.

MMC support for AM335x still isn't in, so only the LDO change has been added.

Cc stable at vger.kernel.org
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I guess the subject should've included v5?

Yes, I blame it on being monday :)

The series you're posting will require rebasing on the current MMC DT series that is being discussed last couple of weeks on the mailing list which were waiting until now as DMA support was missing. Now that DMA support is pulled in, it is safe to apply those patches so I will be reposting them shortly.

Quoted 4 lines
Quoted 2 lines

Please hold off any changes until those patches are posted. This will avoid unnecessary conflicts.

Or you can rebase on top of this patch since it has no dependencies *and* fixes blowing up boards. FWIW, git-rebase, git-cherry-pick and git-am -3 track the rename in my patch just fine.

That's fair enough, since Kevin Acked and Benoit is pulling it, I'm fine with rebasing on top of it and we avoid any merge conflicts.

Quoted 6 lines
Quoted 2 lines

I noticed - there were still some comments from Felipe on the v4 series of this patch regarding RF cape and HDMI may be breaking it. How are you addressing that?

Capes will never go into the .dts and HDMI support needs some serious patching before it can get enabled in the DT. And the RF cape isn't being sold since it has no sw support. No need to worry about things in the 3.15/3.16 timeframe. Unless you want this LDO3 fix not to go in ASAP.

Joel, is there anything relevant *right now* blocking this patch going in? If not, please test it and add your Tested-by: line.

Quoted 8 lines

We don't merge things in hurry and focus is to do things the right way.. I just want to make sure that all possible comments have been addressed.

Otherwise patch looks OK and hope everyone else thinks so too. I am dealing with some merge conflicts right now with my series on top of this though, but they should be easy enough to fix up. That's delaying my testing, but otherwise as such I don't have any objection to this patch (provided the conclusion is that all comments have been addressed..). Thanks!

Koen,

One note though, since I don't use HDMI (or BBB much for that matter), I was ok with taking a risk of upping the ldo3 regulator voltage to 3.3v on my board which I needed to do to get to the boot prompt.
I applied my AM335x DMA and MMC patches and tried to boot with rootfs as MMC1.

With 1.8v, I get the following during boot:

[    2.236043] mmc0: host doesn't support card's voltages
[    2.241659] mmc0: error -22 whilst initialising SD card

That's strange because I do have an SDHC card. With 3.3v it works fine.

Quoted 8 lines
Quoted 6 lines

I will add a note about this to my series. Since this more of an MMC issue than anything, and your patch series doesn't enable MMC, you can add my tested-by:

Later on, the regulator voltage may need to be tweaked for MMC support.

See https://lkml.org/lkml/2013/9/6/95 and https://lkml.org/lkml/2013/9/6/183

Ok since you said in above thread you'll rebase the card detect and the regulator fixes , I'll let you do that and drop my drop my hacked mmc1 patch for BBB from my series.

Regards,

-Joel