Skip to contentSkip to conversation

ARM: dts: dra7-evm: add support for sd, eMMC

PATCH Superseded Balaji T K 4 participants 7 messages Aug 26, 2013 – Sep 27, 2013 Device tree bindings

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Balaji T K

author
#0 lore raw

cover ARM: dts: dra7-evm: add support for sd, eMMC

Add mmc1, mmc2 dt node to dra7-evm

Balaji T K (2):
ARM: dts: dra7-evm: Add mmc1 node for micro-sd support
ARM: dts: dra7-evm: Add mmc2 node for eMMC support

 arch/arm/boot/dts/dra7-evm.dts |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 1/2 ARM: dts: dra7-evm: Add mmc1 node for micro-sd support

Add mmc1 dt node to dra7-evm board.
Input for ldo1 regulator is controlled by gpio 5 of pcf8575 chip (0x21) on i2c1 bus. When dt support for gpio-pcf857x is available, input supply will be modelled as cascaded regulator.

---
Patch has dependency on [1] for ldo1_reg
[1] [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes
https://lkml.org/lkml/2013/8/26/21

 arch/arm/boot/dts/dra7-evm.dts |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +6 -0
index 32f8534..a59bbd0 100644
@@ -251,3 +251,9 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart3_pins>;
 };
+
+&mmc1 {
+	status = "okay";
+	vmmc-supply = <&ldo1_reg>;
+	bus-width = <4>;
+};
Signature · 1 line
1.7.5.4
author
#2 lore raw

PATCH 2/2 ARM: dts: dra7-evm: Add mmc2 node for eMMC support

In reply to Balaji T K

Add mmc2 dt node to dra7-evm board
and model eMMC vcc as fixed regulator.

---
 arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +14 -0
index a59bbd0..2062724 100644
@@ -17,6 +17,13 @@
 		device_type = "memory";
 		reg = <0x80000000 0x60000000>; /* 1536 MB */
 	};
+
+	mmc2_3v3: fixedregulator-mmc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "mmc2_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
 };
 
 &dra7_pmx_core {
@@ -257,3 +264,10 @@
 	vmmc-supply = <&ldo1_reg>;
 	bus-width = <4>;
 };
+
+&mmc2 {
+	status = "okay";
+	vmmc-supply = <&mmc2_3v3>;
+	bus-width = <8>;
+	ti,non-removable;
+};
Signature · 1 line
1.7.5.4
#3 lore raw

PATCH 2/2 ARM: dts: dra7-evm: Add mmc2 node for eMMC support

+ Sekhar

Hi Balaji,

Quoted 27 lines · Balaji T K

Add mmc2 dt node to dra7-evm board
and model eMMC vcc as fixed regulator.

---
  arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
  1 files changed, 14 insertions(+), 0 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +7 -0
index a59bbd0..2062724 100644
@@ -17,6 +17,13 @@
  		device_type = "memory";
  		reg = <0x80000000 0x60000000>; /* 1536 MB */
  	};
+
+	mmc2_3v3: fixedregulator-mmc2 {
+		compatible = "regulator-fixed";
+		regulator-name = "mmc2_3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
  };
 
  &dra7_pmx_core {

arch/arm/boot/dts/dra7-evm.dts line 272

Quoted 9 lines
arch/arm/boot/dts/dra7-evm.dts +6 -0
@@ -257,3 +264,10 @@
  	vmmc-supply = <&ldo1_reg>;
  	bus-width = <4>;
  };
+
+&mmc2 {
+	status = "okay";
+	vmmc-supply = <&mmc2_3v3>;
+	bus-width = <8>;
+	ti,non-removable;

Sekhar just posted a series to replace that with a non-TI attribute:
non-removable.

I'm not sure if this got merged, but it might be good to use the standard attribute instead.

Regards,
Benoit

author
#4 lore raw

PATCH 2/2 ARM: dts: dra7-evm: Add mmc2 node for eMMC support

Quoted 44 lines · Benoit Cousson

+ Sekhar

Hi Balaji,

Quoted 27 lines · Balaji T K

Add mmc2 dt node to dra7-evm board
and model eMMC vcc as fixed regulator.

---
  arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
  1 files changed, 14 insertions(+), 0 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +7 -0
index a59bbd0..2062724 100644
@@ -17,6 +17,13 @@
          device_type = "memory";
          reg = <0x80000000 0x60000000>; /* 1536 MB */
      };
+
+    mmc2_3v3: fixedregulator-mmc2 {
+        compatible = "regulator-fixed";
+        regulator-name = "mmc2_3v3";
+        regulator-min-microvolt = <3300000>;
+        regulator-max-microvolt = <3300000>;
+    };
  };
 
  &dra7_pmx_core {

arch/arm/boot/dts/dra7-evm.dts line 272

Quoted 9 lines
arch/arm/boot/dts/dra7-evm.dts +6 -0
@@ -257,3 +264,10 @@
      vmmc-supply = <&ldo1_reg>;
      bus-width = <4>;
  };
+
+&mmc2 {
+    status = "okay";
+    vmmc-supply = <&mmc2_3v3>;
+    bus-width = <8>;
+    ti,non-removable;

Sekhar just posted a series to replace that with a non-TI attribute: non-removable.

Quoted 1 line

I'm not sure if this got merged, but it might be good to use the standard attribute instead.

Hi Benoit,

Those patches are not merged yet, standard attribute is good, but few cleanups are needed before ti,non-removable can be replaced by standard non-removable, no_regulator_off_init flag set under ti,non-removable is needed to detect eMMC during boot on OMAP4 devices to keep regulator ON during init. Given that eMMC on dra7-evm is powered by always ON regulator, ti,non-removable and standard attribute will behave same way. Let me know if you want to remove ti,non-removable attribute from this patch.

Quoted 3 lines

Regards,
Benoit

#5 lore raw

PATCH 2/2 ARM: dts: dra7-evm: Add mmc2 node for eMMC support

Quoted 52 lines · Balaji T K
Quoted 46 lines · Benoit Cousson

+ Sekhar

Hi Balaji,

Quoted 28 lines · Balaji T K

Add mmc2 dt node to dra7-evm board
and model eMMC vcc as fixed regulator.

---
  arch/arm/boot/dts/dra7-evm.dts |   14 ++++++++++++++
  1 files changed, 14 insertions(+), 0 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +7 -0
index a59bbd0..2062724 100644
@@ -17,6 +17,13 @@
          device_type = "memory";
          reg = <0x80000000 0x60000000>; /* 1536 MB */
      };
+
+    mmc2_3v3: fixedregulator-mmc2 {
+        compatible = "regulator-fixed";
+        regulator-name = "mmc2_3v3";
+        regulator-min-microvolt = <3300000>;
+        regulator-max-microvolt = <3300000>;
+    };
  };
 
  &dra7_pmx_core {

arch/arm/boot/dts/dra7-evm.dts line 272

Quoted 9 lines
arch/arm/boot/dts/dra7-evm.dts +6 -0
@@ -257,3 +264,10 @@
      vmmc-supply = <&ldo1_reg>;
      bus-width = <4>;
  };
+
+&mmc2 {
+    status = "okay";
+    vmmc-supply = <&mmc2_3v3>;
+    bus-width = <8>;
+    ti,non-removable;

Sekhar just posted a series to replace that with a non-TI attribute:
non-removable.

Quoted 2 lines

I'm not sure if this got merged, but it might be good to use the standard attribute instead.

Hi Benoit,

Quoted 11 lines

Those patches are not merged yet, standard attribute is good, but few cleanups are needed
before ti,non-removable can be replaced by standard non-removable, no_regulator_off_init flag set under ti,non-removable is needed to detect eMMC
during boot on OMAP4 devices to keep regulator ON during init. Given that eMMC on dra7-evm
is powered by always ON regulator, ti,non-removable and standard attribute will behave same
way. Let me know if you want to remove ti,non-removable attribute from this patch.

I dont think its an issue if ti,non-removable and non-removable behave exactly the same. In fact, it will be confusing if they behave differently.

I understand there is a need to clean-up the code around no_regulator_off_init, but I am hoping that can be kept separate from moving to a generic binding. The two clean-ups can be done independent of each other.

Thanks,
Sekhar

#6 lore raw

cover ARM: dts: dra7-evm: add support for sd, eMMC

In reply to Balaji T K
Quoted 9 lines · Balaji T K

Add mmc1, mmc2 dt node to dra7-evm

Balaji T K (2):
ARM: dts: dra7-evm: Add mmc1 node for micro-sd support
ARM: dts: dra7-evm: Add mmc2 node for eMMC support

 arch/arm/boot/dts/dra7-evm.dts |   20 ++++++++++++++++++++
 1 files changed, 20 insertions(+), 0 deletions(-)

Series:

Thanks. this is needed for MMC boot on DRA7 evm.

Signature · 2 lines
Regards,
Nishanth Menon