Skip to contentSkip to conversation

i2c-mux-gpio: don't ignore of_get_named_gpio errors

PATCH In review Ionut Nicu 2 participants 2 messages Oct 8, 2013

Subsystems (3)
lore
Share & tools
lore

Ionut Nicu

author
#0 lore raw

PATCH 2/2 i2c-mux-gpio: don't ignore of_get_named_gpio errors

of_get_named_gpio could return -E_PROBE_DEFER or another error code. This error should be passed further instead of being ignored.

---
 drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)
drivers/i2c/muxes/i2c-mux-gpio.c +7 -3
index eb99f04..6370b47 100644
@@ -66,7 +66,7 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
 	struct device_node *adapter_np, *child;
 	struct i2c_adapter *adapter;
 	unsigned *values, *gpios;
-	int i = 0;
+	int i = 0, ret;
 
 	if (!np)
 		return -ENODEV;
@@ -116,8 +116,12 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
 		return -ENOMEM;
 	}
 
-	for (i = 0; i < mux->data.n_gpios; i++)
-		gpios[i] = of_get_named_gpio(np, "mux-gpios", i);
+	for (i = 0; i < mux->data.n_gpios; i++) {
+		ret = of_get_named_gpio(np, "mux-gpios", i);
+		if (ret < 0)
+			return ret;
+		gpios[i] = ret;
+	}
 
 	mux->data.gpios = gpios;
 
Signature · 1 line
1.7.1
maintainer Acked-by on v1 2/2
#1 lore raw
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"IN" == Ionut Nicu <[email protected]> writes:

IN> of_get_named_gpio could return -E_PROBE_DEFER or another IN> error code. This error should be passed further instead IN> of being ignored.

--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>