Skip to contentSkip to conversation

ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

PATCH Applied Jean-Francois Moine 3 participants 3 messages Oct 8, 2013 – Oct 9, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ARM: Dove: fix bad properties of the si5351 clkout2 used by Cubox audio

As defined in the DT, clkout2 is not allowed to change the pll inside si5351.

This patch extends the properties of clkout2 so that it works as the external clock of the audio device in the Cubox.

Also, as the second si5351 clock is not used in the Cubox, its definition is removed.

---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)

---
 arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
arch/arm/boot/dts/dove-cubox.dts +2 -8
index bb38a24..3dd8844 100644
@@ -99,18 +99,12 @@
 			silabs,pll-master;
 		};
 
-		clkout1 {
-			reg = <1>;
-			silabs,drive-strength = <8>;
-			silabs,multisynth-source = <1>;
-			silabs,clock-source = <0>;
-			silabs,pll-master;
-		};
-
 		clkout2 {
 			reg = <2>;
+			silabs,drive-strength = <8>;
 			silabs,multisynth-source = <1>;
 			silabs,clock-source = <0>;
+			silabs,pll-master;
 		};
 	};
 };
Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
Acked-by on v2 1/1
#1 lore raw
Quoted 10 lines · Jean-Francois Moine

As defined in the DT, clkout2 is not allowed to change the pll inside si5351.

This patch extends the properties of clkout2 so that it works as the external clock of the audio device in the Cubox.

Also, as the second si5351 clock is not used in the Cubox, its definition is removed.

Already gave my

which you should add to help us keep track of them next time.

Quoted 34 lines

---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)

---
  arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
  1 file changed, 2 insertions(+), 8 deletions(-)
arch/arm/boot/dts/dove-cubox.dts +2 -8
index bb38a24..3dd8844 100644
@@ -99,18 +99,12 @@
  			silabs,pll-master;
  		};
 
-		clkout1 {
-			reg = <1>;
-			silabs,drive-strength = <8>;
-			silabs,multisynth-source = <1>;
-			silabs,clock-source = <0>;
-			silabs,pll-master;
-		};
-
  		clkout2 {
  			reg = <2>;
+			silabs,drive-strength = <8>;
  			silabs,multisynth-source = <1>;
  			silabs,clock-source = <0>;
+			silabs,pll-master;
  		};
  	};
  };
Applied
#2 lore raw
In reply to Jean-Francois Moine
Quoted 9 lines · Jean-Francois Moine

As defined in the DT, clkout2 is not allowed to change the pll inside si5351.

This patch extends the properties of clkout2 so that it works as the external clock of the audio device in the Cubox.

Also, as the second si5351 clock is not used in the Cubox, its definition is removed.

Quoted 7 lines

---
v2:
- remove clkout1 which is not used in the Cubox (Sebastian Hesselbarth)

---
 arch/arm/boot/dts/dove-cubox.dts | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Applied to mvebu/dt with Sebastian's Ack.

thx,

Jason.