jfs: simplify lmNextPage() via list_last_entry_or_null()

PATCH In review Jeff Liu 1 participant 1 message Nov 15, 2013

Subsystems (2)

Memory technology devices (MTD) JFS filesystem

lore

Share & tools

lore

Jeff Liu

author

2013-11-15 04:34 UTC #0 lore raw

PATCH 5/6 jfs: simplify lmNextPage() via list_last_entry_or_null()

From: Jie Liu <[email protected]>

Simplify the code in lmNextPage via list_last_entry_or_null().

Signed-off-by Jie Liu <[email protected]>

---
 fs/jfs/jfs_logmgr.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

fs/jfs/jfs_logmgr.c +1 -4

index 360d27c..7b565d0 100644
@@ -591,10 +591,7 @@ static int lmNextPage(struct jfs_log * log)
 	 *	write or queue the full page at the tail of write queue
 	 */
 	/* get the tail tblk on commit queue */
-	if (list_empty(&log->cqueue))
-		tblk = NULL;
-	else
-		tblk = list_entry(log->cqueue.prev, struct tblock, cqueue);
+	tblk = list_last_entry_or_null(&log->cqueue, struct tblock, cqueue);
 
 	/* every tblk who has COMMIT record on the current page,
 	 * and has not been committed, must be on commit queue

Signature · 1 line

1.8.3.2