Skip to content

list: introduce list_last_entry_or_null()

Jeff Liu cluster-devel linux-mtd linux-xfs lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6list: introduce list_last_entry_or_null()include/linux/list.h+11 -00 replies
2/6xfs: simplify xfs_ail_max() via list_last_entry_or_null()fs/xfs/xfs_trans_ail.c fs/xfs/xfs_trans_priv.h+12 -140 replies
3/6gfs2: simplify current_tail() via list_last_entry_or_null()fs/gfs2/log.c+3 -73 replies
4/6ubifs: simplify drop_last_node() via list_last_entry_or_null()fs/ubifs/recovery.c+3 -50 replies
5/6jfs: simplify lmNextPage() via list_last_entry_or_null()fs/jfs/jfs_logmgr.c+1 -40 replies
6/6jfs: simplify lmLogSync() via list_last_entry_or_null()fs/jfs/jfs_logmgr.c+3 -71 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] list: introduce list_last_entry_or_null()

Hi Folks,

This patch is trying to introduce a new list helper to retrieve the last entry or return NULL if the list is empty corresponding to it, which is inspired by Jiri Pirko's list_first_entry_or_null().

With this trivial helper, we could get a little benefit to simplify the code logic of xfs_ail_max() and make the code looks a bit more consistent with xfs_ail_min() which has already been simplified via list_first_entry_or_null().

Moreover, as a per simple grep against fs as well as driver's tree, I think there are some other places could make use of it for similar purpose, here I spread this helper over some file systems as well.

Any comments are welcome!

Thanks,
-Jeff