Skip to contentSkip to conversation

ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)

PATCH New Peter Ujfalusi 4 participants 5 messages Nov 28, 2013 – Dec 5, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)

Since in DT booted kernel dummy regulators are no longer supported we need to provide valid phandle for the regulator needed by the backlight. On the board VBAT is used to power the LCD backlight(s).

---
Hi,

This patch is needed for 3.13 to get the LCD backlight to work again.

Regards,
Peter

 arch/arm/boot/dts/omap4-sdp.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap4-sdp.dts +1 -0
index 5fc3f43..6f86db2 100644
@@ -104,6 +104,7 @@
 				100 110 120 127
 				>;
 		default-brightness-level = <13>;
+		power-supply = <&vbat>;
 	};
 
 	sound {
Signature · 1 line
1.8.4.2
#1 lore raw

PATCH 1/1 ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)

Hi Peter,

Quoted 9 lines · Peter Ujfalusi

Since in DT booted kernel dummy regulators are no longer supported we need to provide valid phandle for the regulator needed by the backlight. On the board VBAT is used to power the LCD backlight(s).

---
Hi,

This patch is needed for 3.13 to get the LCD backlight to work again.

OK, so this is a fix for the next -rc?

Regards,
Benoit

Quoted 20 lines

Regards,
Peter

  arch/arm/boot/dts/omap4-sdp.dts | 1 +
  1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap4-sdp.dts +1 -0
index 5fc3f43..6f86db2 100644
@@ -104,6 +104,7 @@
  				100 110 120 127
  				>;
  		default-brightness-level = <13>;
+		power-supply = <&vbat>;
  	};
 
  	sound {
Signature · 4 lines
Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
#2 lore raw

PATCH 1/1 ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)

Hi Benoit,

Quoted 7 lines · Benoit Cousson

Hi Peter,

Quoted 4 lines · Peter Ujfalusi

Since in DT booted kernel dummy regulators are no longer supported we need to provide valid phandle for the regulator needed by the backlight. On the board VBAT is used to power the LCD backlight(s).

Quoted 7 lines
Quoted 5 lines

---
Hi,

This patch is needed for 3.13 to get the LCD backlight to work again.

OK, so this is a fix for the next -rc?

Yes, it would be really great if this can make it to the next -rc.

Quoted 26 lines

Regards,
Benoit

Quoted 20 lines

Regards,
Peter

  arch/arm/boot/dts/omap4-sdp.dts | 1 +
  1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap4-sdp.dts +1 -0
index 5fc3f43..6f86db2 100644
@@ -104,6 +104,7 @@
                  100 110 120 127
                  >;
          default-brightness-level = <13>;
+        power-supply = <&vbat>;
      };
 
      sound {
Signature · 1 line
P?ter
#3 lore raw

PATCH 1/1 ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)

In reply to Peter Ujfalusi
Quoted 9 lines · Peter Ujfalusi

Since in DT booted kernel dummy regulators are no longer supported we need to provide valid phandle for the regulator needed by the backlight. On the board VBAT is used to power the LCD backlight(s).

---
Hi,

This patch is needed for 3.13 to get the LCD backlight to work again.

Is this usage of power supply a mandatory requirement?

There is a thread which discusses this issue[1]:
http://www.spinics.net/lists/arm-kernel/msg288215.html

According to the above, regulator framework have support in 3.13-rc1 to returns
a dummy regulator if there is none specified in the dts data. Thierry told that there seems to be a bug in regulator in handling these case.

Though, I also posted a patch on pwm a couple of days ago[2] [2]: https://patchwork.kernel.org/patch/3246711/

I posted it without "power-supply" by testing it with the solution proposed in [1].
If I dont use the solution[1], it fails for me also.

#4 lore raw

PATCH 1/1 ARM: DTS: omap4-sdp: Add regulator for LCD backlight (pwm-backlight)

Quoted 21 lines · Sourav Poddar
Quoted 9 lines · Peter Ujfalusi

Since in DT booted kernel dummy regulators are no longer supported we need to provide valid phandle for the regulator needed by the backlight. On the board VBAT is used to power the LCD backlight(s).

---
Hi,

This patch is needed for 3.13 to get the LCD backlight to work again.

Is this usage of power supply a mandatory requirement?

There is a thread which discusses this issue[1]:
http://www.spinics.net/lists/arm-kernel/msg288215.html

According to the above, regulator framework have support in 3.13-rc1 to returns
a dummy regulator if there is none specified in the dts data. Thierry told that there seems to be a bug in regulator in handling these case.

Quoted 6 lines

Though, I also posted a patch on pwm a couple of days ago[2] [2]: https://patchwork.kernel.org/patch/3246711/

I posted it without "power-supply" by testing it with the solution proposed in [1].
If I dont use the solution[1], it fails for me also.

Hmm so if this is not needed, I'll mark this thread as read in my inbox. If you guys need it please repost.

Regards,

Tony