net: plip: slight optimization of addr compare

PATCH In review Ding Tianhong 1 participant 1 message Dec 30, 2013

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Ding Tianhong

author

2013-12-30 07:41 UTC #0 lore raw

PATCH v3 19/19 net: plip: slight optimization of addr compare

Use possibly more efficient ether_addr_equal_64bits to instead of memcmp.

Cc "David S. Miller" <[email protected]>

Signed-off-by Ding Tianhong <[email protected]>

---
 drivers/net/plip/plip.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/net/plip/plip.c +2 -2

index 7b4ff35..040b897 100644
@@ -547,9 +547,9 @@ static __be16 plip_type_trans(struct sk_buff *skb, struct net_device *dev)
 	skb_pull(skb,dev->hard_header_len);
 	eth = eth_hdr(skb);
 
-	if(*eth->h_dest&1)
+	if(is_multicast_ether_addr(eth->h_dest))
 	{
-		if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0)
+		if(ether_addr_equal_64bits(eth->h_dest, dev->broadcast))
 			skb->pkt_type=PACKET_BROADCAST;
 		else
 			skb->pkt_type=PACKET_MULTICAST;

Signature · 1 line

1.6.0.2