Skip to content

slight optimization of addr compare for net modules

Ding Tianhong lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest19 patches 3 repliesIn review
  2. v220 patches 15 repliesSuperseded
  3. v120 patches 15 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19net: 3com: slight optimization of addr comparedrivers/net/ethernet/3com/3c509.c+1 -20 replies
2/19net: bnx2x: slight optimization of addr comparedrivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c+6 -80 replies
3/19net: cxgb3: slight optimization of addr comparedrivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c drivers/net/ethernet/chelsio/cxgb3/l2t.c+2 -20 replies
4/19net: enic: slight optimization of addr comparedrivers/net/ethernet/cisco/enic/enic_pp.c+1 -12 replies
5/19net: benet: slight optimization of addr comparedrivers/net/ethernet/emulex/benet/be_main.c+1 -10 replies
6/19net: igbvf: slight optimization of addr comparedrivers/net/ethernet/intel/igbvf/netdev.c+1 -10 replies
7/19net: ixgbe: slight optimization of addr comparedrivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c+1 -20 replies
8/19net: mlx4: slight optimization of addr comparedrivers/net/ethernet/mellanox/mlx4/en_netdev.c drivers/net/ethernet/mellanox/mlx4/resource_tracker.c+3 -30 replies
9/19net: ksz884x: slight optimization of addr comparedrivers/net/ethernet/micrel/ksz884x.c+4 -50 replies
10/19net: vxge: slight optimization of addr comparedrivers/net/ethernet/neterion/vxge/vxge-main.c+1 -10 replies
11/19net: packetengines: slight optimization of addrdrivers/net/ethernet/packetengines/yellowfin.c+10 -70 replies
12/19net: netxen: slight optimization of addr comparedrivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c+1 -10 replies
13/19net: qlcnic: slight optimization of addr comparedrivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c+6 -60 replies
14/19net: renesas: slight optimization of addr comparedrivers/net/ethernet/renesas/sh_eth.c+1 -10 replies
15/19net: seeq: slight optimization of addr comparedrivers/net/ethernet/seeq/sgiseeq.c+1 -10 replies
16/19net: sun: optimization of addr comparedrivers/net/ethernet/sun/sunvnet.c+1 -10 replies
17/19net: ti: slight optimization of addr comparedrivers/net/ethernet/ti/cpsw_ale.c+1 -10 replies
18/19net: fddi: slight optimization of addr comparedrivers/net/fddi/skfp/fplustm.c+2 -10 replies
19/19net: plip: slight optimization of addr comparedrivers/net/plip/plip.c+2 -20 replies

Reviews trailers per patch

2 of 19 patches have a Reviewed-by or Acked-by.

PatchAmir VadaiGovindarajulu Varadarajan
1/19
2/19
3/19
4/19A-b
5/19
6/19
7/19
8/19A-b
9/19
10/19
11/19
12/19
13/19
14/19
15/19
16/19
17/19
18/19
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 00/19] slight optimization of addr compare for net modules

This is the second patchset for slight optimization of address compare, mainly for net tree, just following the Joe's opinion, it will help review the code for maintainers and supports.

v2: Change some style for patch 2.
According Eric's suggestion, use the ether_addr_equal_64bits to instead of ether_addr_equal for patch 19.
In fact, there are a lot of places which could use ether_addr_equal_64bits to instead of ether_addr_equal, but not this time, thanks for Joe's opinion.

v3: Change some style for patch 11/19:
(net: packetengines: slight optimization of addr compare).
Joe pointed out that is_broadcast_ether_addr(addr) would be appropriate here, but this should be left alone and not in this patch, so fix it later.

In the patch (net: caif: slight optimization of addr compare), the operand for memcmp is not mac address, so it is unsuitable to use the ether_addr_equal to compare a non mac address, so remove the patch from the series.

Best Regards
Ding

Ding Tianhong (19):
net: 3com: slight optimization of addr compare
net: bnx2x: slight optimization of addr compare
net: cxgb3: slight optimization of addr compare
net: enic: slight optimization of addr compare
net: benet: slight optimization of addr compare
net: igbvf: slight optimization of addr compare
net: ixgbe: slight optimization of addr compare
net: mlx4: slight optimization of addr compare
net: ksz884x: slight optimization of addr compare
net: vxge: slight optimization of addr compare
net: packetengines: slight optimization of addr compare
net: netxen: slight optimization of addr compare
net: qlcnic: slight optimization of addr compare
net: renesas: slight optimization of addr compare
net: seeq: slight optimization of addr compare
net: sun: optimization of addr compare
net: ti: slight optimization of addr compare
net: fddi: slight optimization of addr compare
net: plip: slight optimization of addr compare

 drivers/net/ethernet/3com/3c509.c                     |  3 +--
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c        | 10 ++++------
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c     |  2 +-
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.c      |  2 +-
 drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.c    |  2 +-
 drivers/net/ethernet/chelsio/cxgb3/l2t.c              |  2 +-
 drivers/net/ethernet/cisco/enic/enic_pp.c             |  2 +-
 drivers/net/ethernet/emulex/benet/be_main.c           |  2 +-
 drivers/net/ethernet/intel/igbvf/netdev.c             |  2 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c        |  3 +--
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c        |  4 ++--
 drivers/net/ethernet/mellanox/mlx4/resource_tracker.c |  2 +-
 drivers/net/ethernet/micrel/ksz884x.c                 |  9 ++++-----
 drivers/net/ethernet/neterion/vxge/vxge-main.c        |  2 +-
 drivers/net/ethernet/packetengines/yellowfin.c        |  8 ++------
 drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c    |  2 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c        |  4 ++--
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c        |  4 ++--
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c      |  4 ++--
 drivers/net/ethernet/renesas/sh_eth.c                 |  2 +-
 drivers/net/ethernet/seeq/sgiseeq.c                   |  2 +-
 drivers/net/ethernet/sun/sunvnet.c                    |  2 +-
 drivers/net/ethernet/ti/cpsw_ale.c                    |  2 +-
 drivers/net/fddi/skfp/fplustm.c                       |  3 ++-
 drivers/net/plip/plip.c                               |  2 +-
 25 files changed, 37 insertions(+), 45 deletions(-)
Signature · 1 line
1.8.0